This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
fix(templating.js): reset caused duplicate template contents (#1945) #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaliatech
force-pushed
the
issue-1945-reset-dup-templates
branch
from
15effaa to
6d908d4
Compare
rnicholus
approved these changes
Dec 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1945. Calling render resulted in duplicate template renders in the container. This bug was introduced in the 5.15.3 release due to a change whereby templates renders are now appended to the container instead of replacing the innerHTML.
PR includes a simple unit test to verify calling render no longer results in duplicate contents.