fix(templating.js): reset caused duplicate template contents (#1945)

FineUploader · Dec 21, 2017 · 15effaa · 15effaa
1 parent 8d25ba3
commit 15effaa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/client/js/templating.js b/client/js/templating.js
@@ -650,6 +650,7 @@ qq.Templating = function(spec) {
         },
 
         reset: function() {
+            container.innerHTML = "";
             this.render();
         },
 

diff --git a/test/unit/templating.js b/test/unit/templating.js
@@ -328,6 +328,11 @@ describe("templating.js", function() {
             assert.ok(!$fixture.find(".qq-upload-pause-selector").hasClass(HIDE_CSS));
             assert.ok(!$fixture.find(".qq-upload-spinner-selector").hasClass(HIDE_CSS));
         });
+
+        it("reset clears contents before appending new render", function() {
+            templating.reset()
+            assert.equal($fixture.find(".qq-uploader").length, 1);
+        });
     });
 
     describe("permanently hidden files tests", function() {
-Original file line number
+Diff line change
@@ Expand Up / @@ -650,6 +650,7 @@ qq.Templating = function(spec) { @@
             },
             reset: function() {
+                container.innerHTML = "";
                 this.render();
             },
@@ Expand Down @@