Add more 7.0 sample files #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7 that exercise parts of GEDCOM 7.0 that aren't in other sample files. Combined atsign.ged into the esiting escapes.ged. Some files not copied include: * char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files are UTF-8 with a BOM. * date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample. * enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample. * obsolete.ged and tiny.ged are the same as the existing minimal70.ged. Addresses part of issue FamilySearch#132 Signed-off-by: Dave Thaler <[email protected]>
Filed FamilySearch/GEDCOM#420 while working on this. Signed-off-by: Dave Thaler <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
clarkegj,
tychonievich and
lynchrs3
as code owners
dthaler
pushed a commit
to dthaler/GEDCOM
that referenced
this pull request
Mar 7, 2024
The proposed recommendation is consistent with sample files: * https://gedcom.io/testfiles/gedcom70/maximal70.ged has MEDIA, OTHER, and ELECTRONIC. * FamilySearch/GEDCOM.io#151 adds obje-1.ged with PHOTO and VIDEO, as copied from https://github.com/gedcom7code/test-files/blob/main/7/obje-1.ged Fixes FamilySearch#316 since it addresses the last piece that wasn't already done Signed-off-by: Dave Thaler <[email protected]>
dthaler
added a commit
to FamilySearch/GEDCOM
that referenced
this pull request
Mar 7, 2024
The proposed recommendation is consistent with sample files: * https://gedcom.io/testfiles/gedcom70/maximal70.ged has MEDIA, OTHER, and ELECTRONIC. * FamilySearch/GEDCOM.io#151 adds obje-1.ged with PHOTO and VIDEO, as copied from https://github.com/gedcom7code/test-files/blob/main/7/obje-1.ged Fixes #316 since it addresses the last piece that wasn't already done Signed-off-by: Dave Thaler <[email protected]> Co-authored-by: Dave Thaler <[email protected]>
dthaler
commented
Mar 7, 2024
|
Ok to merge after renaming lang-all.ged to lang.ged, per discussion March 7, 2024 |
Signed-off-by: Dave Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to factor PR #136 into multiple smaller PRs.
This PR includes files with no currently outstanding comments.