Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gedcom7code/test-files vs FamilySearch/GEDCOM.io/testfiles #132

Open
dthaler opened this issue Dec 20, 2023 · 2 comments
Open

gedcom7code/test-files vs FamilySearch/GEDCOM.io/testfiles #132

dthaler opened this issue Dec 20, 2023 · 2 comments

Comments

@dthaler
Copy link
Collaborator

dthaler commented Dec 20, 2023

https://gedcom.io/tools/ points to a number of sample FamilySearch GEDCOM 7.0 and GEDZIP files.

https://github.com/gedcom7code/test-files/tree/main/7 also has some 7.0 GEDCOM files that test some things not currently covered by files in https://github.com/FamilySearch/GEDCOM.io/tree/master/testfiles/gedcom70

Options:

  1. Update https://github.com/FamilySearch/GEDCOM.io/blob/master/_pages/tools.md#example-familysearch-gedcom-70-files to also point to files in the gedcom7code/test-files repository.
  2. Copy such files into the FamilySearch/GEDCOM.io repository. (This would be my preference.)

If we go with option 2, we should also consider copying GEDCOM 5.5.1 files from https://github.com/gedcom7code/test-files/tree/main/5 to say https://github.com/FamilySearch/GEDCOM.io/tree/master/testfiles/gedcom551 (which doesn't currently exist).

@dthaler dthaler changed the title gedcom7code/test-files vs gedcom7code/test-files vs FamilySearch/GEDCOM.io/testfiles Dec 20, 2023
@dthaler
Copy link
Collaborator Author

dthaler commented Dec 28, 2023

Discussion 12/28/2023:
We think it would be useful to also have sample files from older GEDCOM versions, to facilitate testing converters to 7.0, like the gedcom7code repository has 5.5.1 files for that purpose. James and Dave both have some older samples.
We will come back to this next meeting for more discussion.

@dthaler
Copy link
Collaborator Author

dthaler commented Jan 4, 2024

Discussion 1/4/2024:

dthaler pushed a commit to dthaler/GEDCOM.io that referenced this issue Jan 7, 2024
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7
that exercise parts of GEDCOM 7.0 that aren't in other sample files.

Combined atsign.ged into the esiting escapes.ged.

Some files not copied include:
* char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files
  are UTF-8 with a BOM.
* date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample.
* enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample.
* obsolete.ged and tiny.ged are the same as the existing minimal70.ged.

Addresses part of issue FamilySearch#132

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM.io that referenced this issue Mar 7, 2024
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7
that exercise parts of GEDCOM 7.0 that aren't in other sample files.

Combined atsign.ged into the esiting escapes.ged.

Some files not copied include:
* char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files
  are UTF-8 with a BOM.
* date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample.
* enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample.
* obsolete.ged and tiny.ged are the same as the existing minimal70.ged.

Addresses part of issue FamilySearch#132

Signed-off-by: Dave Thaler <[email protected]>
dthaler added a commit that referenced this issue Mar 7, 2024
* Add more 7.0 sample files

Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7
that exercise parts of GEDCOM 7.0 that aren't in other sample files.

Combined atsign.ged into the esiting escapes.ged.

Some files not copied include:
* char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files
  are UTF-8 with a BOM.
* date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample.
* enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample.
* obsolete.ged and tiny.ged are the same as the existing minimal70.ged.

Addresses part of issue #132

Signed-off-by: Dave Thaler <[email protected]>

* Update age-all.ged per PR feedback

Filed
FamilySearch/GEDCOM#420
while working on this.

Signed-off-by: Dave Thaler <[email protected]>

* Update testfiles/gedcom70/escapes.ged

Co-authored-by: Luther Tychonievich <[email protected]>

* Update testfiles/gedcom70/lang-all.ged

Co-authored-by: Luther Tychonievich <[email protected]>

* Update testfiles/gedcom70/lang-all.ged

Co-authored-by: Luther Tychonievich <[email protected]>

* PR feedback

Signed-off-by: Dave Thaler <[email protected]>

* Remove lines without @

Signed-off-by: Dave Thaler <[email protected]>

* PR feedback

Signed-off-by: Dave Thaler <[email protected]>

* Update age.ged

Signed-off-by: Dave Thaler <[email protected]>

* Update escapes.ged

Signed-off-by: Dave Thaler <[email protected]>

* Remove files that still have open issues on them

Signed-off-by: Dave Thaler <[email protected]>

* Rename lang-all.ged to lang.ged

Signed-off-by: Dave Thaler <[email protected]>

---------

Signed-off-by: Dave Thaler <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
Co-authored-by: Luther Tychonievich <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM.io that referenced this issue Mar 21, 2024
Copy 8 files from https://github.com/gedcom7code/test-files/tree/main/7
that exercise parts of GEDCOM 7.0 that aren't in other sample files.

Combined atsign.ged into the esiting escapes.ged.

Some files not copied include:
* char*.ged only make sense once there are corresponding 5.5.1 samples in the repository, since all 7.0 files
  are UTF-8 with a BOM.
* date-dual.ged likewise only makes sense as a 7.0 derivative of a 5.5.1 sample.
* enum-ext.ged likewise looked like it only made sense along with a 5.5.1 sample.
* obsolete.ged and tiny.ged are the same as the existing minimal70.ged.

Addresses part of issue FamilySearch#132

Signed-off-by: Dave Thaler <[email protected]>
dthaler pushed a commit to dthaler/GEDCOM.io that referenced this issue Mar 21, 2024
tychonievich pushed a commit that referenced this issue Mar 28, 2024
* Add sample file testing FILE payloads

Derived from file in https://github.com/gedcom7code/test-files/tree/main/7

Addresses part of issue #132

Signed-off-by: Dave Thaler <[email protected]>

* Add explanatory NOTEs

Signed-off-by: Dave Thaler <[email protected]>

---------

Signed-off-by: Dave Thaler <[email protected]>
Co-authored-by: Dave Thaler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant