Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed french locale: using "de " instead of "d'" before Jellyseerr #356

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fixed french locale: using "de " instead of "d'" before Jellyseerr #356

merged 1 commit into from
Mar 25, 2023

Conversation

GeoffreyCoulaud
Copy link
Contributor

@GeoffreyCoulaud GeoffreyCoulaud commented Mar 25, 2023 •
edited
Loading

Description

Correcting a bug in the french locale, where an Overseerr reused translation is wrong.
In french, de means of , and before a vowel it's replaced by d'.
Jellyseer doesn't start with a vowel, but Overseerr does, so the string must be changed.

I checked the locale file with this regex for anomalies d'[^aeiouyhêèéà] and fixed the occurences that appear.
Note that accentuated characters are treated the same and d'h is valid because h is silent.

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

Fallenbagel
Fallenbagel approved these changes Mar 25, 2023
View reviewed changes
Copy link
Owner

@Fallenbagel Fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! (For the PR and the explanation of the grammar. Learned something new) 😊

@Fallenbagel Fallenbagel merged commit 53f6a89 into Fallenbagel:develop Mar 25, 2023
@GeoffreyCoulaud GeoffreyCoulaud deleted the geoffrey-fix branch March 25, 2023 18:50
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Fallenbagel
Copy link
Owner

@all-contributors please add @GeoffreyCoulaud for translation

@allcontributors allcontributors bot mentioned this pull request Nov 7, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@Fallenbagel

I've put up a pull request to add @GeoffreyCoulaud! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fallenbagel Fallenbagel Fallenbagel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

French develp version status broken
2 participants
@GeoffreyCoulaud @Fallenbagel