Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle non-existent rottentomatoes rating for movies #1169

Conversation

benhaney
Copy link
Contributor

Description

This fixes a bug where some movies don't have any rottentomatoes ratings, which causes ratings from other services to not show

Screenshot (if UI-related)

Before this change:
Screen Shot 2024-12-20 at 12 37 49 AM

After this change:
Screen Shot 2024-12-20 at 12 34 05 AM

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

This fixes a bug where some movies don't have any rottentomatoes
ratings, which causes ratings from other services to not show
@Fallenbagel Fallenbagel merged commit 347a24a into Fallenbagel:develop Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ratingscombined endpoint 500s when missing RT data
3 participants