ratingscombined endpoint 500s when missing RT data

[benhaney]

Description

The rotten tomatoes algolia search API used by jellyseerr does not guarantee that the objects in results.hits will contain a rottenTomatoes entry, but jellyseerr's RottenTomatoes API client's getMovieRatings function tries to access keys within the rottenTomatoes object without checking if it exists first. If it doesn't exist, the whole function throws, which causes jellyseerr's ratingscombined endpoint to 500 even if there are other valid ratings from other sources.

Version

Latest develop

Steps to Reproduce

Go the movie details page for any movie which is currently on RT but has no official ratings, such as /movie/791042 (which corresponds to this RT page). Observe in dev tools that the ratingscombined API request 500s and no other ratings (except for TMDB's) are visible, even if they should exist.

Screenshots

Jellyseerr ratings box for movie 791042:

Dev tools for same page:

Ratings box for the same page after a local fix (note the unrelated IMDB rating now appears):

Logs

[debug][API]: Something went wrong retrieving movie ratings {"errorMessage":"[RT API] Failed to retrieve movie ratings: Cannot read properties of undefined (reading 'certifiedFresh')","movieId":"791042"}

Platform

desktop

Database

None

Device

Mac

Operating System

macOS

Browser

Chromium

Additional Context

No response

Code of Conduct

• I agree to follow Jellyseerr's Code of Conduct

[benhaney]

I just noticed this problem is identical to #1018 but for movies instead of tv shows