Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge audit-fixes-2 to main #59

Merged
merged 95 commits into from
Sep 28, 2023
Merged

Merge audit-fixes-2 to main #59

merged 95 commits into from
Sep 28, 2023

Conversation

p0p3yee
Copy link
Contributor

@p0p3yee p0p3yee commented Sep 27, 2023

No description provided.

p0p3yee and others added 30 commits June 14, 2023 19:27
@p0p3yee
Update default pep nonce to 1 #23
ccf2a63
@p0p3yee
Update register validator to get bonded validators for validation #20
4a10cd8
@p0p3yee
Add minimum bonded token check on register validator #21
257883b
@p0p3yee
Add status & err msg to MsgSendKeyshareResponse #34
a86d001
@p0p3yee
Add gas deduction & json tx decoding
92b43f6
@p0p3yee
Update test files & hermes config file for gas deduction fix
80e7daa
@ap0calypse644
fix:issue #38; removing duplicate ValidateBasic
866e1e0
@ap0calypse644
fix:issue #36; replacing GetAllValidators with GetValidator
ded6712
@ap0calypse644
fix:issue #35; replace with constants
bbbe359
@ap0calypse644
fix:issue #31; missing validation of genesis state
09277a3
@ap0calypse644
fix:issue #29; missing validation of keyshare params
a01b2e6
@ap0calypse644
fix:issue #25; removed modifying state from the execution of MsgCreat…
0ab69dc 
…eAggregatedKeyShare
@ap0calypse644
fix:issue #39; add interfaces for external functions
6229d3a
@p0p3yee
Update send keyshare & pubkey msg & keyshare verification mechanism
c9f5cf1
@p0p3yee
Remove commitment in keyshare
1bef14d
@ap0calypse644
fix:issue #33; replacing with
b150e5f
@p0p3yee
Update keyshare module beginblock get validator logic
df3a758
@p0p3yee
Update tx fee deduction logic in pep module
d1e9c80
@p0p3yee
Update keyshare module begin block logic
e1505c6
@p0p3yee
Update submit pub key logic
0d22790
@p0p3yee
Finish off update keyshare verify logic #54
34ed9d1
@ap0calypse644
fix:issue #37; adding usage instruction for all cli commands
5d9a43e
@ap0calypse644
fix:issue #27; add counterparty check before updating keys
963d1be
@ap0calypse644
fix:issue #35; replace constants with parameterized values
73ad915
@ap0calypse644
fix:issue #27; clean up
f07db67
@p0p3yee
Add slashing idle validators #55
af54c3c
@p0p3yee
Add gas deduction & test for pep module #24
6df7057
@p0p3yee
Add validateBasic to submit keyshare & pub key msg #54
e6eacb6
@p0p3yee
Add logic to prevent new validator be slashed immedately #55
3744374
@p0p3yee
Register amino codec #32
9122a23
p0p3yee and others added 21 commits August 23, 2023 14:37
@p0p3yee
Update test validator bonded amount
1d7331a
@p0p3yee
Add gas deduction when submitting encrypted tx & refund on execution
7452cd2
@p0p3yee
Fix scripts & hermes config
9855fbb
@p0p3yee
Add min gas price params to pep module for charging gas when submitti…
3463d85 
…ng encrypted tx
@p0p3yee
Add gas refund on failed tx & fix gas consumed calculation logic
8d3dd82
@p0p3yee
Update to get mingasprice params directly from keeper
c28786c
@p0p3yee
Remove iterating thru tx fee coins, update to get the first tx fee coin
9b1df5e
@p0p3yee
Update to charge gas fee set from params instead of getting it from t…
ed329b9 
…x gas limit
@p0p3yee
Update to GasMeter()
a721278
@p0p3yee
Update to only allow keyshare height to be current block + 1 max
b240128
@p0p3yee
Merge fix/issue#24
0be4bca
@p0p3yee
Merge branch 'fix/issue#23' into audit-fixes-2
85a52a7
@p0p3yee
merge fix/issue#54 into audit-fixes-2
9ddf490
@p0p3yee
Merge branch 'fix/issue#55' into audit-fixes-2
0e372f5
@p0p3yee
Update test script & fix parsing error in cli client
7cd0b43
@p0p3yee
Remove old fairblock nonce files
92a69db
@p0p3yee
Add key pep nonce
9a62d7d
@p0p3yee
Fix pep script not able to submit encrypted tx
1d27fe1
@p0p3yee
Merge branch 'feature/authorize-address' into 'audit-fixes-2
962b6b1
@p0p3yee
Update pb.go to cosmos gogoproto
72743c1
@p0p3yee
Fix error getting commitment
3090440
bowenyou
bowenyou reviewed Sep 27, 2023
View reviewed changes
testutil/utils.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of all this unused code if it's not needed anymore

bowenyou
bowenyou approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@bowenyou bowenyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it was a large PR so I may have missed something.

@p0p3yee p0p3yee merged commit c3daf93 into main Sep 28, 2023
1 check passed
@bowenyou bowenyou deleted the audit-fixes-2 branch October 3, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenyou bowenyou bowenyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0p3yee @bowenyou @ap0calypse644