Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of magic numbers decreases maintainability #35

Closed
p0p3yee opened this issue Jun 14, 2023 · 0 comments
Closed

Use of magic numbers decreases maintainability #35

p0p3yee opened this issue Jun 14, 2023 · 0 comments
Assignees
@ap0calypse644
Labels
Review Waiting for review

Comments

@p0p3yee
Copy link
Contributor

p0p3yee commented Jun 14, 2023 •
edited
Loading 

k.stakingKeeper.Slash(ctx, consAddr, ctx.BlockHeight()-1, 100, sdk.NewDecWithPrec(5, 1))

x/keyshare/keeper/msg_server_send_keyshare.go:51
@ap0calypse644 ap0calypse644 self-assigned this Jun 15, 2023
ap0calypse644 added a commit that referenced this issue Jun 20, 2023
@ap0calypse644
fix:issue #35; replace with constants
bbbe359
@ap0calypse644 ap0calypse644 mentioned this issue Jun 20, 2023
Merged
@ap0calypse644 ap0calypse644 added enhancement New feature or request Review Waiting for review and removed enhancement New feature or request labels Jun 20, 2023
ap0calypse644 added a commit that referenced this issue Jun 23, 2023
@ap0calypse644
fix:issue #35; replace constants with parameterized values
73ad915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ap0calypse644 ap0calypse644

Labels
Review Waiting for review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bowenyou @p0p3yee @ap0calypse644