Entity Lifespan API #3713
Closed
Entity Lifespan API #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Apr 16, 2024
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/mixin/item/ItemEntityMixin.java
Outdated
Show resolved
Hide resolved
maityyy
reviewed
Apr 16, 2024
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
Juuxel
suggested changes
Apr 16, 2024
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItemStack.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItemStack.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItemStack.java
Outdated
Show resolved
Hide resolved
fabric-item-api-v1/src/main/java/net/fabricmc/fabric/api/item/v1/FabricItem.java
Outdated
Show resolved
Hide resolved
Juuxel
added
enhancement
…v1/FabricItem.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItem.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItem.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItemStack.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItem.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItemStack.java Co-authored-by: Juuz <[email protected]>
…v1/FabricItemStack.java Co-authored-by: Juuz <[email protected]>
maityyy
approved these changes
Apr 16, 2024
|
Game tests still pending! |
apple502j
reviewed
Apr 17, 2024
| @@ -119,15 +123,27 @@ default ItemStack getRecipeRemainder(ItemStack stack) { | |||
| * <p>Note that this method is only called <em>after</em> the {@link EnchantmentEvents#ALLOW_ENCHANTING} event, and | |||
| * only if none of the listeners to that event override the result.</p> | |||
| * | |||
| * @param stack the current stack | |||
| * @param stack the current stack | |||
There was a problem hiding this comment.
Please revert those changes
FabricMC#3735) (cherry picked from commit 0dca034)
(cherry picked from commit be5d88b)
|
Someone else can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just so you know, Im not the greatest mixin guy.
Fixes #3636