Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always get the latest ServerPlayerEntity from ServerPlayNetworkHandler #3735

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Always get the latest ServerPlayerEntity from ServerPlayNetworkHandler #3735

merged 1 commit into from
Apr 26, 2024

Conversation

modmuss50
Copy link
Member

The player instance in ServerPlayNetworkHandler is replaced when the player dies and respawns.

@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Apr 26, 2024
mysticdrew
mysticdrew approved these changes Apr 26, 2024
View reviewed changes
Copy link

@mysticdrew mysticdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@modmuss50 modmuss50 merged commit 0dca034 into FabricMC:1.20.6 Apr 26, 2024
4 checks passed
modmuss50 added a commit that referenced this pull request Apr 26, 2024
@modmuss50
Always get the latest ServerPlayerEntity from ServerPlayNetworkHandler (
bd46f3a 
#3735)

(cherry picked from commit 0dca034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysticdrew mysticdrew mysticdrew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modmuss50 @mysticdrew