Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse control stops responding when toggled and not visible #10

Closed
azreal1983 opened this issue Jun 26, 2020 · 1 comment · Fixed by #11
Closed

Collapse control stops responding when toggled and not visible #10

azreal1983 opened this issue Jun 26, 2020 · 1 comment · Fixed by #11
Labels
bug Something isn't working

Comments

@azreal1983
Copy link

azreal1983 commented Jun 26, 2020 •
edited
Loading

Screenshot 2020-06-26 at 19 35 39
Calibration RMS: 0.080 Min: -0.276 Max: 0.240
but cannot see what is changing.
@Fabi0San
Copy link
Owner

I've seen this happen when the probing finishes and the tab is not active.
I blame the javascript collapse control I used.
We could look into using a different solution more friendly to KO bindings.

@Fabi0San Fabi0San changed the title loading of new settings not showing Collapse control stops responding when toggled and not visible Jun 26, 2020
@Fabi0San Fabi0San added the bug Something isn't working label Jun 26, 2020
@Fabi0San Fabi0San mentioned this issue Jun 28, 2020
Merged
Fabi0San added a commit that referenced this issue Jun 28, 2020
@Fabi0San
Merge pull request #11 from Fabi0San/devel
56a9eb2 
* Moving away from Bootstrap 2 collapsible controls as they are buggy, Fixes #10
* Leveraging Marlin's [newly introduced](MarlinFirmware/Marlin#18423) ability to configure DIAGONAL_ROD_TRIM via M665. Fixes #6
* Instructs Marling to not raise the probe on every probe point, especially helpful to manually deployed probes. Fixes #3
* Improves instructions, mentions useful Marlin configs.
* Discontinue use of deprecated THREE.js API issuing warning on console.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes Fabi0San/DuCalibrator
2 participants
@Fabi0San @azreal1983