Tweak vector FCMP helpers so we can reuse in AVX128 #3744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any time we get the value of Literal, we want to assert that it's actually a literal. We've been open coding this pattern sporadically throughout the opcodedispatcher. Let's add an ergonomic helper to fetch the value of literal, asserting that the value is indeed literal. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Signed-off-by: Alyssa Rosenzweig <[email protected]>
I told Ryan to change this for AVX, but it needs to be changed in the original to match! Signed-off-by: Alyssa Rosenzweig <[email protected]>
so it's suitable for AVX128 Signed-off-by: Alyssa Rosenzweig <[email protected]>
so AVX128 can reuse it. Signed-off-by: Alyssa Rosenzweig <[email protected]>
alyssarosenzweig
force-pushed
the
refactor/fcmp-for-avx
branch
from
381c573 to
a16c751
Compare
|
We'll merge this with #3740 itself, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #3743 for conflicts, for #3740