Forcefully terminate all processes with a configured shutdown timeout #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the stage for a new, more generic BuildCommandContext.
We start all procs as CommandContexts instead of Commands, with a WithCancel context attached. A context cancellation handler which tries to stop the application gracefully, waits the specified amount of time, and subsequently SIGKILLs if the process hasn't stopped already is attached to the CommandContext. The CommandContext type internally has some synchronization to try to minimize the chances of races between the context cancellation handler, and normal termination of applications.
anrddh
force-pushed
the
forced-termination
branch
from
5ab22e0 to
7abd809
Compare
|
|
Resolved as part of 891f742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
I'm not entirely convinced this change is race free, but it should be. I would appreciate if someone double checked my handling of the
p.waitDonechannel.I assume that a modification to the docs is in order. I can take a look at that once this change is otherwise accepted.