Force terminate apps if shutdown.timeout_seconds is defined, without requiring shutdown.command to be defined

[anrddh]

Feature Request

Use Case:

I drive a number of processes that don't reliably shutdown on SIGTERM. Usually, this is down to buggy behavior on the part of those processes. It would be nice if Process Compose was robust to such processes, and provided a way to kill them reliably.

Proposed Change:

If shutdown.timeout_seconds is defined for a process, then SIGKILL it after that many seconds, if it hasn't shutdown by then.

Who Benefits From The Change(s)?

Anyone driving processes that don't shutdown gracefully reliably.

Alternative Approaches

We can use pkill -9 in shutdown.command to get by for now, but this feels like a bit of a hack. It requires care to ensure processes running outside Process Compose with similar names don't get accidentally killed.

[anrddh]

If this seems like a reasonable feature, then I am happy to look into the source code and try and come up with a fix for this myself.

[F1bonacc1]

Hi @anrddh,

That sounds like a valid use case and a very relevant feature.

[anrddh]

Here's a rough cut of the change: main...anrddh:process-compose:forced-termination

I've never written Go before, so please do look carefully! It seems to pass a simple test. (This is not a great unit test BTW and could be flaky if run on machines under heavy load, but I don't know of a straightforward way to sidestep the calls to sleep.)

I ended up using command contexts because it seemed to be the best way to avoid kills racing with waiting for the dead process.

Longer term, I think it would be nice if we could support cgroups on Linux to handle all kinds of edge cases properly.

I'm about to head to bed, but I'll look tomorrow and refine the change further before opening a PR.

[anrddh]

I've been kept busy the last few days, but my branch above fails one of the tests. I know what the issue is, and I'll try and get it up to snuff by the weekend

[F1bonacc1]

Added in v1.27.0

Thank you @anrddh for taking the time to contribute to this project. I appreciate your effort and interest in improving the codebase. While I've decided to go in a different direction for this feature, your engagement is valuable and I hope you'll continue to be involved with the project.

Cheers!

[anrddh]

Thanks for implementing it!