Fix: Add integer validation to card limit #51011

twilight2294 · 2024-10-17T12:20:42Z

Details

Fixed Issues

$ #50788
PROPOSAL: #50788 (comment)

Tests

Pre-condition: Enable expensify card and add a VBA

Open App
Tap profile icon-- workspaces- workspace
Tap expensify cards
Tap +issue card - select a user -- physical card
Note smart limit checked
Tap next
Enter a decimal number and tap next

Verify that you get the error: Please enter a whole dollar amount before continuing.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Pre-condition: Enable expensify card and add a VBA

Go to https://staging.new.expensify.com/home
Tap profile icon-- workspaces- workspace
Tap expensify cards
Tap +issue card - select a user -- physical card
Note smart limit checked
Tap next
Enter a decimal number and tap next

Verify that you get the error: Please enter a whole dollar amount before continuing.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-17T12:20:46Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2024-10-17T12:41:15Z

@rayane-djouah PR with a single line change was given $125 bounty(issue) where as our PR contains multiple changes and still lower bounty, can you please request for a bounty increase on our issue to be fair?

rayane-djouah · 2024-10-18T19:45:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rayane-djouah · 2024-10-18T19:48:56Z

src/languages/es.ts

@@ -946,6 +946,7 @@ const translations = {
        error: {
            invalidCategoryLength: 'La longitud de la categoría escogida excede el máximo permitido (255). Por favor, escoge otra categoría o acorta la categoría primero.',
            invalidAmount: 'Por favor, ingresa un importe válido antes de continuar.',
+            invalidIntegerAmount: 'Por favor, introduce una cantidad en dólares completos antes de continuar.',


Can you use https://chatgpt.com/g/g-2dgOQl5VM-english-to-spanish-translator to get the translation and then ask for confirmation on our Slack channel?

I did translate from chatGPT, can you ask on slack? my invite is still pending due to some issue with expensify and slack, i requested to join but they are still to add me

Got Por favor introduce una cantidad entera en dólares antes de continuar. with JamesGPT. I asked for confirmation here: https://expensify.slack.com/archives/C01GTK53T8Q/p1729289783370669

@twilight2294 , can you please fill out this form? Once we have invites for Slack we'll invite you https://docs.google.com/forms/d/e/1FAIpQLSeZ1JyVRYUrHugT8SyIL6b7dFYUgR3TEa1jigccREqD2hfLxQ/viewform

Thx

@rayane-djouah any updates ?

Bumped the Slack thread

The correct translation is:

Por favor, introduce una cantidad entera en dólares antes de continuar.

done, can you please complete the checklist

rayane-djouah · 2024-10-25T14:19:52Z

@twilight2294 Can you please merge main branch?

twilight2294 · 2024-10-25T14:29:02Z

Done!

rayane-djouah

LGTM and tests well

rayane-djouah · 2024-10-28T17:53:20Z

@thienlnam all yours!

OSBotify · 2024-10-28T18:54:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-29T09:44:28Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-10-31T11:17:40Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.55-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

twilight2294 added 4 commits October 17, 2024 17:39

Update en.ts

fbda788

add spanish translation

4ea3775

update validation while editing

bc0b808

Update validation while creating

a9934db

twilight2294 requested a review from a team as a code owner October 17, 2024 12:20

melvin-bot bot requested a review from rayane-djouah October 17, 2024 12:20

melvin-bot bot removed the request for review from a team October 17, 2024 12:20

twilight2294 added 4 commits October 17, 2024 17:54

Fix spanish language error

2354e03

Fix english language error

18b8af5

Merge branch 'Expensify:main' into fixintegervalidation

0fb858c

add translation

96adac7

rayane-djouah suggested changes Oct 18, 2024

View reviewed changes

Update es.ts

1123a83

Merge branch 'Expensify:main' into fixintegervalidation

f832d7a

rayane-djouah approved these changes Oct 27, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam October 27, 2024 22:27

thienlnam approved these changes Oct 28, 2024

View reviewed changes

thienlnam merged commit 2a3095e into Expensify:main Oct 28, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 29, 2024

Deploy Checklist: New Expensify 2024-10-29 #51635

Closed

65 tasks

melvin-bot bot mentioned this pull request Oct 31, 2024

[HOLD for payment 2024-11-07] [$100] Expensify Card - improvements to the Set a limit screen #50788

Closed

6 tasks

koko57 mentioned this pull request Nov 5, 2024

[$250] [Workspace Feeds] Auth RequestReplacementExpensifyCard returned an error when deactivating card #50394

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Add integer validation to card limit #51011

Fix: Add integer validation to card limit #51011

twilight2294 commented Oct 17, 2024

melvin-bot bot commented Oct 17, 2024

twilight2294 commented Oct 17, 2024

rayane-djouah commented Oct 18, 2024 •

edited

Loading

rayane-djouah Oct 18, 2024

twilight2294 Oct 18, 2024

rayane-djouah Oct 18, 2024

mallenexpensify Oct 19, 2024

twilight2294 Oct 22, 2024

rayane-djouah Oct 23, 2024

rayane-djouah Oct 23, 2024

twilight2294 Oct 25, 2024

rayane-djouah commented Oct 25, 2024

twilight2294 commented Oct 25, 2024

rayane-djouah left a comment

rayane-djouah commented Oct 28, 2024

OSBotify commented Oct 28, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

Fix: Add integer validation to card limit #51011

Fix: Add integer validation to card limit #51011

Conversation

twilight2294 commented Oct 17, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 17, 2024

twilight2294 commented Oct 17, 2024

rayane-djouah commented Oct 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rayane-djouah commented Oct 25, 2024

twilight2294 commented Oct 25, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

rayane-djouah commented Oct 28, 2024

OSBotify commented Oct 28, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 31, 2024

rayane-djouah commented Oct 18, 2024 •

edited

Loading