[HOLD for payment 2024-10-29] [$125] The Smartlimit description is always cut off

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729070184832209

Action Performed:

1. Have a workspace with expensify cards set up as well as approvers
2. Try to create a new card
3. Proceed up to "Choose a limit type"

Expected Result:

Should be wrapped in 2 lines

Actual Result:

the smart limit option is trimmed even on web with the largest RHP option

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846797861964749988
• Upwork Job ID: 1846797861964749988
• Last Price Increase: 2024-10-17
• Automatic offers:
• allgandalf | Reviewer | 104458329
• daledah | Contributor | 104458330

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-10-17 04:10:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Limit type alternate text is not breaking into new line

What is the root cause of that problem?

In LimitTypeStep, we don't pass isAlternateTextMultilineSupported to RadioListItem:

App/src/pages/workspace/expensifyCard/issueNew/LimitTypeStep.tsx

Lines 104 to 111 in 780e09e

	<SelectionList
	ListItem={RadioListItem}
	onSelectRow={({value}) => setTypeSelected(value)}
	sections={[{data}]}
	shouldSingleExecuteRowSelect
	initiallyFocusedOptionKey={typeSelected}
	shouldUpdateFocusedIndex
	/>

This will make RadioListItem uses the default false value, which will make the alternate text to be displayed only in 1 line:

App/src/components/SelectionList/RadioListItem.tsx

Line 20 in 780e09e

isAlternateTextMultilineSupported = false,

App/src/components/SelectionList/RadioListItem.tsx

Line 76 in 780e09e

numberOfLines={isAlternateTextMultilineSupported ? alternateTextNumberOfLines : 1}

What changes do you think we should make in order to solve the problem?

Pass isAlternateTextMultilineSupported to here:

App/src/pages/workspace/expensifyCard/issueNew/LimitTypeStep.tsx

Lines 104 to 111 in 780e09e

	<SelectionList
	ListItem={RadioListItem}
	onSelectRow={({value}) => setTypeSelected(value)}
	sections={[{data}]}
	shouldSingleExecuteRowSelect
	initiallyFocusedOptionKey={typeSelected}
	shouldUpdateFocusedIndex
	/>

What alternative solutions did you explore? (Optional)

[daledah]

PROPOSAL UPDATED

• Added more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846797861964749988

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Minor change! @allgandalf can you please review?

[allgandalf]

yeah sure!

[allgandalf]

Let's go with @daledah's proposal here, Their RCA is correct and solution works 👍

We forgot to pass isAlternateTextMultilineSupported while creating a card, we pass it when editing the type. So need to update there.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@allgandalf PR is ready.

[allgandalf]

♻️ PR approved

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: The Smartlimit description is always cut off #50975

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment automatic offer (Reviewer)
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@mallenexpensify, @mountiny, @allgandalf, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

I will post the checklist tomorrow, sorry for the delay

[melvin-bot]

@mallenexpensify, @mountiny, @allgandalf, @daledah Still overdue 6 days?! Let's take care of this!

[mountiny]

@allgandalf kind bump

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: [No QA] 1-6 Card Flow UI #44741

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44741/files#r1828902689

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition: Workspace is connected to bank account and expensify card toggle enabled

• Open app
• Go to workspace
• Go to Expensify Card page
• Press Issue new card
• Proceed to the page "Choose a limit type"

Verify that: The smart limit option is displayed in 2 lines

Do we agree 👍 or 👎

[mountiny]

I dont think we need a specific regression test for this minor thing, thank you for recommending

[mallenexpensify]

Contributor: @daledah paid $125 via Upwork
Contributor+: @allgandalf paid @125 via Upwork.

I created a test case cuz QA does monthly runs for design and edge case issues. I added this text to it

• This should either be a monthly test or closed if you you don't think it's worth even checking monthly for

Thanks!

[melvin-bot]

@mallenexpensify @mountiny Be sure to fill out the Contact List!