[QBD] Export out-of-pocket expenses #50234

ZhenjaHorbach · 2024-10-04T12:32:45Z

Details

[QBD] Export out-of-pocket expense

Fixed Issues

$ Related to #49710, will fix it once there aren't TODO items anymore.
PROPOSAL:

Tests

Open app
Open workspace with a set Quickbooks Desktop
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Press on Export out-of-pocket expenses as
Verify that Export out-of-pocket expenses as screen was open
Press on Export as and choose any item
Verify that Export as was open and Mark checks as “print later” is displayed only if Check is selected
Press on Mark checks as “print later” toggle
Verify that toggle is switched
Press on Bank account and choose any item
Verify that Bank account was open and the сurrent value is selected

Verify that no errors appear in the JS console

Offline tests

Open app
Open workspace with a set Quickbooks Desktop
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Press on Export out-of-pocket expenses as
Verify that Export out-of-pocket expenses as screen was open
Press on Export as and choose any item
Verify that Export as was open and Mark checks as “print later” is displayed only if Check is selected
Press on Mark checks as “print later” toggle
Verify that toggle is switched
Press on Bank account and choose any item
Verify that Bank account was open and the сurrent value is selected

QA Steps

Open app
Open workspace with a set Quickbooks Desktop
Navigate to https://dev.new.expensify.com:8082/settings/workspaces/${policyId}/accounting/quickbooks-desktop/export
Press on Export out-of-pocket expenses as
Verify that Export out-of-pocket expenses as screen was open
Press on Export as and choose any item
Verify that Export as was open and Mark checks as “print later” is displayed only if Check is selected
Press on Mark checks as “print later” toggle
Verify that toggle is switched
Press on Bank account and choose any item
Verify that Bank account was open and the сurrent value is selected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…cket

ZhenjaHorbach · 2024-10-04T18:01:04Z

@hoangzinh

Could you please left a comment here ?
In theory if I open a PR for review you will be assigned !

hoangzinh · 2024-10-04T23:24:42Z

Sure @ZhenjaHorbach

src/languages/es.ts

melvin-bot · 2024-10-07T09:14:36Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-10-07T09:15:53Z

@hoangzinh
@lakchote

PR is ready !
But I think we better wait until QBD connection is ready
Since we need to test several requests !

ZhenjaHorbach · 2024-10-07T09:16:15Z

@marcaaron
Sorry for assignment 😅

hoangzinh · 2024-10-07T13:16:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-10.at.23.42.54.android.mov

Android: mWeb Chrome

Screen.Recording.2024-10-10.at.23.33.57.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-10.at.23.41.04.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-10-10.at.23.35.44.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-10.at.23.27.15.web.mov

MacOS: Desktop

Screen.Recording.2024-10-10.at.23.31.46.desktop.mov

hoangzinh

There's a lot of code that refers to QBO, Is it possible to refers all them to QBD in this PR?

src/pages/workspace/accounting/qbd/export/QuickbooksDesktopExportPage.tsx

...ges/workspace/accounting/qbd/export/QuickbooksDesktopOutOfPocketExpenseAccountSelectPage.tsx

ZhenjaHorbach · 2024-10-07T17:25:09Z

@hoangzinh
I removed some TODO and updated translations

src/types/onyx/Policy.ts

src/libs/actions/connections/QuickbooksDesktop.ts

...ges/workspace/accounting/qbd/export/QuickbooksDesktopOutOfPocketExpenseConfigurationPage.tsx

src/types/onyx/Policy.ts

hoangzinh · 2024-10-10T10:49:21Z

Bug 1: Menu item "Export as" and "Account" are not showing pending update when updated in offline mode

Screen.Recording.2024-10-10.at.17.47.26.mov

ZhenjaHorbach · 2024-10-10T10:58:13Z

Bug 1: Menu item "Export as" and "Account" are not showing pending update when updated in offline mode

Screen.Recording.2024-10-10.at.17.47.26.mov

Good point
Done !

hoangzinh · 2024-10-10T16:05:00Z

@ZhenjaHorbach it's weird to me because when I update "Account" menu in offline, it also show pending update for "Export as" menu

Screen.Recording.2024-10-10.at.23.03.28.mov

ZhenjaHorbach · 2024-10-10T16:16:54Z

This is due to the fact that Export As is subscribed to 2 keys

https://github.com/Expensify/App/pull/50234/files#diff-a2a1896f941f858af84260700d5f331e84ef07c099e69d3da7e79603f83022f2R34

And when we update one of them It goes into Update state

https://github.com/Expensify/App/pull/50234/files#diff-a2a1896f941f858af84260700d5f331e84ef07c099e69d3da7e79603f83022f2R75

The same logic we have on QBO

App/src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

Line 65 in c077bd2

subscribedSettings: accountOrExportDestination,

hoangzinh · 2024-10-10T16:27:05Z

Thanks for explanation @ZhenjaHorbach

hoangzinh · 2024-10-10T16:30:57Z

Note: During testing, I found some missing translations in the background. I believe it would be fixed in this issue #49698 (comment)

ZhenjaHorbach · 2024-10-10T16:35:50Z

Note: During testing, I found some missing translations in the background. I believe it would be fixed in this issue #49698 (comment)

Agree
Looks like a part another issue

melvin-bot · 2024-10-10T16:46:31Z

🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #50591.

ZhenjaHorbach · 2024-10-10T19:36:46Z

@lakchote
We are ready to merge !

src/libs/actions/connections/QuickbooksDesktop.ts

ZhenjaHorbach · 2024-10-11T07:27:44Z

@hoangzinh
@lakchote
I updated the PR to use new API commands !

lakchote

I'm glad we're getting rid of DeepPartial 😄

@hoangzinh could you give this a final review please with the new API commands?

ZhenjaHorbach · 2024-10-11T07:55:13Z

I'm glad we're getting rid of DeepPartial 😄

@hoangzinh could you give this a final review please with the new API commands?

Now it doesn't make sense anymore to use DeepPartial 😅

hoangzinh

LGTM, tested again

Screen.Recording.2024-10-11.at.16.52.45.mov

ZhenjaHorbach · 2024-10-11T12:32:44Z

@lakchote
Could we please merge this PR to not block others ? 😃

OSBotify · 2024-10-11T14:58:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:30:35Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-10-16T23:34:19Z

We are blocked with proceeding with this PR. Can it be validated internally?

github-actions · 2024-10-17T01:45:30Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

create draft screens for QuickbooksDesktopOutOfPocket

41dddf2

ZhenjaHorbach changed the title ~~[QBD] [Export] Export out-of-pocket expenses~~ [QBD] Export out-of-pocket expenses Oct 4, 2024

ZhenjaHorbach added 4 commits October 4, 2024 15:42

Merge branch 'main' into qbd-export-settings-quickbooksdesktopoutofpo…

aac8d0f

…cket

refactor screens for using qbd

74d3252

fix ts issues

023b2fd

update routes and connectionName

23f6476

ZhenjaHorbach added 2 commits October 7, 2024 10:52

fix conflicts

bbfb8f8

remove some TODO

bfc726e

ZhenjaHorbach commented Oct 7, 2024

View reviewed changes

src/languages/es.ts Show resolved Hide resolved

ZhenjaHorbach marked this pull request as ready for review October 7, 2024 09:14

ZhenjaHorbach requested a review from a team as a code owner October 7, 2024 09:14

melvin-bot bot requested a review from marcaaron October 7, 2024 09:14

melvin-bot bot removed the request for review from a team October 7, 2024 09:14

hoangzinh reviewed Oct 7, 2024

View reviewed changes

ZhenjaHorbach added 2 commits October 7, 2024 18:30

remove some TODO

29dbcc8

update translates

ec48ed7

hoangzinh reviewed Oct 7, 2024

View reviewed changes

marcaaron removed their request for review October 8, 2024 00:45

ZhenjaHorbach added 2 commits October 8, 2024 08:49

fix comments

93b6ddf

remove buildOnyxDataForMultipleQuickbooksConfigurations

32f2e6f

lakchote reviewed Oct 8, 2024

View reviewed changes

src/types/onyx/Policy.ts Outdated Show resolved Hide resolved

ZhenjaHorbach added 2 commits October 8, 2024 11:16

rename QBDNonReimbursableExportAccountType

233dd9f

rename QBDNonReimbursableExportAccountType x2

b0653c3

fix bug

9cbda7e

ZhenjaHorbach added 2 commits October 10, 2024 14:53

update API for QBD

cd6e9ba

update pendingAction for exportOutOfPocketExpensesCheckToogle

c077bd2

hoangzinh approved these changes Oct 10, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Oct 10, 2024

Payment issue for E/App PR#50234 #50591

Closed

lakchote reviewed Oct 11, 2024

View reviewed changes

src/libs/actions/connections/QuickbooksDesktop.ts Outdated Show resolved Hide resolved

lakchote reviewed Oct 11, 2024

View reviewed changes

src/libs/actions/connections/QuickbooksDesktop.ts Outdated Show resolved Hide resolved

ZhenjaHorbach added 3 commits October 11, 2024 09:02

update code to use new api commands

0b8b5d6

update types

04fbce4

refactor code

f7507be

lakchote approved these changes Oct 11, 2024

View reviewed changes

hoangzinh approved these changes Oct 11, 2024

View reviewed changes

lakchote merged commit 12e41b1 into Expensify:main Oct 11, 2024
17 checks passed

github-actions bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QBD] Export out-of-pocket expenses #50234

[QBD] Export out-of-pocket expenses #50234

ZhenjaHorbach commented Oct 4, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 4, 2024

hoangzinh commented Oct 4, 2024

melvin-bot bot commented Oct 7, 2024

ZhenjaHorbach commented Oct 7, 2024

ZhenjaHorbach commented Oct 7, 2024

hoangzinh commented Oct 7, 2024 •

edited

Loading

hoangzinh left a comment

ZhenjaHorbach commented Oct 7, 2024 •

edited

Loading

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024 •

edited

Loading

hoangzinh commented Oct 10, 2024

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

melvin-bot bot commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

ZhenjaHorbach commented Oct 11, 2024

lakchote left a comment

ZhenjaHorbach commented Oct 11, 2024 •

edited

Loading

hoangzinh left a comment

ZhenjaHorbach commented Oct 11, 2024

OSBotify commented Oct 11, 2024

github-actions bot commented Oct 15, 2024

mvtglobally commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

[QBD] Export out-of-pocket expenses #50234

[QBD] Export out-of-pocket expenses #50234

Conversation

ZhenjaHorbach commented Oct 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ZhenjaHorbach commented Oct 4, 2024

hoangzinh commented Oct 4, 2024

melvin-bot bot commented Oct 7, 2024

ZhenjaHorbach commented Oct 7, 2024

ZhenjaHorbach commented Oct 7, 2024

hoangzinh commented Oct 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

ZhenjaHorbach commented Oct 7, 2024 • edited Loading

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024 • edited Loading

hoangzinh commented Oct 10, 2024

hoangzinh commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

melvin-bot bot commented Oct 10, 2024

ZhenjaHorbach commented Oct 10, 2024

ZhenjaHorbach commented Oct 11, 2024

lakchote left a comment

Choose a reason for hiding this comment

ZhenjaHorbach commented Oct 11, 2024 • edited Loading

hoangzinh left a comment

Choose a reason for hiding this comment

ZhenjaHorbach commented Oct 11, 2024

OSBotify commented Oct 11, 2024

github-actions bot commented Oct 15, 2024

mvtglobally commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

ZhenjaHorbach commented Oct 4, 2024 •

edited

Loading

hoangzinh commented Oct 7, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 7, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 10, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 11, 2024 •

edited

Loading