[HOLD for payment 2024-10-29] [Wave Control] [QBD] Handle the syncing for QBD

[lakchote]

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.1wvr9f4uk5jl

[hoangzinh]

Hi @lakchote can you double check if QBD has the same sync stage as QBO

App/src/CONST.ts

Lines 2332 to 2347 in 521e6dd

	QBO_IMPORT_MAIN: 'quickbooksOnlineImportMain',
	QBO_IMPORT_CUSTOMERS: 'quickbooksOnlineImportCustomers',
	QBO_IMPORT_EMPLOYEES: 'quickbooksOnlineImportEmployees',
	QBO_IMPORT_ACCOUNTS: 'quickbooksOnlineImportAccounts',
	QBO_IMPORT_CLASSES: 'quickbooksOnlineImportClasses',
	QBO_IMPORT_LOCATIONS: 'quickbooksOnlineImportLocations',
	QBO_IMPORT_PROCESSING: 'quickbooksOnlineImportProcessing',
	QBO_SYNC_PAYMENTS: 'quickbooksOnlineSyncBillPayments',
	QBO_IMPORT_TAX_CODES: 'quickbooksOnlineSyncTaxCodes',
	QBO_CHECK_CONNECTION: 'quickbooksOnlineCheckConnection',
	QBO_SYNC_TITLE: 'quickbooksOnlineSyncTitle',
	QBO_SYNC_LOAD_DATA: 'quickbooksOnlineSyncLoadData',
	QBO_SYNC_APPLY_CATEGORIES: 'quickbooksOnlineSyncApplyCategories',
	QBO_SYNC_APPLY_CUSTOMERS: 'quickbooksOnlineSyncApplyCustomers',
	QBO_SYNC_APPLY_PEOPLE: 'quickbooksOnlineSyncApplyEmployees',
	QBO_SYNC_APPLY_CLASSES_LOCATIONS: 'quickbooksOnlineSyncApplyClassesLocations',

I'm going to copy translation text of sync stages but just wanna be confirmed.

[lakchote]

@hoangzinh here are the correct stages for QBD:

    QBD_IMPORT_TITLE("quickbooksDesktopImportTitle"),
    QBD_IMPORT_ACCOUNTS("quickbooksDesktopImportAccounts"),
    QBD_IMPORT_APPROVE_CERTIFICATE("quickbooksDesktopImportApproveCertificate"),
    QBD_IMPORT_DIMENSIONS("quickbooksDesktopImportDimensions"),
    QBD_IMPORT_CLASSES("quickbooksDesktopImportClasses"),
    QBD_IMPORT_CUSTOMERS("quickbooksDesktopImportCustomers"),
    QBD_IMPORT_VENDORS("quickbooksDesktopImportVendors"),
    QBD_IMPORT_EMPLOYEES("quickbooksDesktopImportEmployees"),
    QBD_IMPORT_MORE("quickbooksDesktopImportMore"),
    QBD_IMPORT_GENERIC("quickbooksDesktopImportSavePolicy"),

[hoangzinh]

Thanks @lakchote

[hoangzinh]

Hi @lakchote I'm working on this issue, sorry I couldn't spin up my PR because my init connection PR hasn't been merged yet, but can you check the API command SyncPolicyToQuickbooksDesktop works as expected? I tried to test it locally and Pusher hasn't sent any events to update the status.

Screen.Recording.2024-10-08.at.16.47.31.mov

[lakchote]

Hi @lakchote I'm working on this issue, sorry I couldn't spin up my PR because my init connection PR hasn't been merged yet, but can you check the API command SyncPolicyToQuickbooksDesktop works as expected? I tried to test it locally and Pusher hasn't sent any events to update the status.

Found the issue, thanks for noticing it. I'm raising a backend PR and will let you know once this is deployed.

[lakchote]

@hoangzinh the PR is deployed, you should be able to get pusher updates now.

[hoangzinh]

Thanks @lakchote

[hoangzinh]

@lakchote can you check if we also miss 'quickbooksDesktopWebConnectorReminder'

Screen.Recording.2024-10-11.at.18.08.37.mov

[lakchote]

@lakchote can you check if we also miss 'quickbooksDesktopWebConnectorReminder'

here it is @hoangzinh:

quickbooksDesktopWebConnectorReminder: 'Still syncing data with QuickBooks... Please make sure the Web Connector is running',

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBD] Handle the syncing for QBD #50500

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)

[hoangzinh]

@lakchote can you add @ZhenjaHorbach and BZ team to this issue so we can process payment later.

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lakchote]

@VictoriaExpensify please process payment for both @hoangzinh and @ZhenjaHorbach thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hoangzinh owed $250 via NewDot
• ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@VictoriaExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[VictoriaExpensify]

Hey @lakchote @hoangzinh - can I just confirm that $250 is the correct payment amount here?

[hoangzinh]

Yes @VictoriaExpensify, it would be the same standard payment for all current issues.

[lakchote]

Hey @lakchote @hoangzinh - can I just confirm that $250 is the correct payment amount here?

Yes $250 is the correct payment. Standard payment will apply for all the QBD issues.

[VictoriaExpensify]

Payment summary
Contributor+: @hoangzinh owed $250 via Upwork

@ZhenjaHorbach - I've sent you an offer through Upwork, Can you please accept it and I'll pay you? https://www.upwork.com/nx/wm/offer/104727384

[ZhenjaHorbach]

Payment summary

Contributor+: @hoangzinh owed $250 via Upwork

@ZhenjaHorbach - I've sent you an offer through Upwork, Can you please accept it and I'll pay you? https://www.upwork.com/nx/wm/offer/104727384

Done
Thanks !

[VictoriaExpensify]

Updated Payment summary:
Contributor: @ZhenjaHorbach paid $250 via Upwork
Contributor+: @hoangzinh owed $250 via New Expensify

[melvin-bot]

@lakchote @VictoriaExpensify Be sure to fill out the Contact List!

[garrettmknight]

$250 approved for @hoangzinh