-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Guided Setup Stage 3] Onboarding message not sent when VBBA selected #50052
[Guided Setup Stage 3] Onboarding message not sent when VBBA selected #50052
Conversation
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@cdOut why I don't see pay with expensify? Are there any missing precondition? |
Needs to be USD. |
The sender account has to have its currency set to USD and then you also need to set it to USD for the expense itself. I've added the preconditions and a video to help with setting your accounts currency. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2024-10-02.at.8.13.23.PM.mov |
@trjExpensify @cdOut this works smooth. Do you need videos on all platforms ? I would need to setup my gmail for android and ios then to test native ? or is only MacOS web fine(currently there in the checklist) ? |
This functionality is not platform dependent so I don't think testing it on all platforms is necessary. |
Yeah, agreed. Let's get this over to @deetergp for the secondary review and merge. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, lets get this merged 💪 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick turn around!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.44-0 🚀
|
The reported performance regression can be ignored, see: |
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀
|
Details
Adds a completePaymentOnboarding call directly into AddPaymentMethodMenu so it always runs on payment confirmation, even if the user has to setup bank info afterwards.
Fixed Issues
$ #50027
PROPOSAL:
Tests
Preconditions
Account of the sender has to set it's currency to USD, which you can do by logging into oldDot (expensify.com) and following the example video, setting your account currency to USD at the end.
Screen.Recording.2024-10-02.at.16.35.53.mov
new.expensify.com
todev.new.expensify.com:8082
)Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
CHROME-SMALLER.mov