[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [Performance] Investigate performance regression to app open time (reported by e2e system)

[hannojg]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

What performance issue do we need to solve?

The e2e performance test have reported a performance regression:

Name	Duration
App start TTI	1265.941 ms → 1922.656 ms (+656.715 ms, +51.9%) 🔴🔴
App start contentAppeared_To_screenTTI	540.925 ms → 1235.091 ms (+694.166 ms, +128.3%) 🔴🔴

The regressions are testing from commit a6ff319 against version https://github.com/Expensify/App/releases/tag/9.0.43-4

In between those changes must be a regression

What is the impact of this on end-users?

App start time is delayed by ~600ms

List any benchmarks that show the severity of the issue

See e2e tests

Proposed solution (if any)

None yet. We need to find the faulty commit first.

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

E2e test results should improve

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

[melvin-bot]

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

[hannojg]

please assign to me

[hannojg]

This is very likely being fixed here:

• Fix performance of SearchRouter #50143

[melvin-bot]

Current assignee @luacmartins is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

Draft PR here, should be ready for review soon

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[jasperhuangg]

@hannojg @luacmartins Were we able to retest this?

[rayane-djouah]

@jasperhuangg Yes, this is fixed. relevant discussion:

• https://expensify.slack.com/archives/C05LX9D6E07/p1727962274213859?thread_ts=1727910192.774079&cid=C05LX9D6E07
• https://expensify.slack.com/archives/C05LX9D6E07/p1727963201933999?thread_ts=1727910192.774079&cid=C05LX9D6E07

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix performance of SearchRouter #50143

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)

[rayane-djouah]

@jasperhuangg @luacmartins we can remove DeployBlockerCash label and close this issue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix performance of SearchRouter #50143

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)