-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBR display in LHN, Inbox and Workspace list #46575
Conversation
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
code looks good and tests well |
But I can't reproduce the original bug. Is it fixed? |
@dukenv0307 did you try the test steps of the PR? Btw, #46416 (comment). |
@rezkiy37 Yah, I can reproduce by following the steps in the PR, but not for steps in the OP
|
@dukenv0307 Yes, the OP is still being investigated. I found this bug related to the issue as well. |
@dukenv0307, I just have a friendly question: will you review this PR? |
@rezkiy37 Yes |
@rezkiy37 Code looks good and tests well, but I can't reproduce the initial bug. Do we need to wait for that? |
@dukenv0307 the initial bug of this PR or the issue? Because they are similar but not the same. |
@rezkiy37 When can I start reviewing this PR? |
@dukenv0307, I've synced up. Also, I tested it again and it works properly in both modes. RBR.mp4 |
will start review in a hour |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-09.at.10.54.45.movAndroid: mWeb ChromeScreen.Recording.2024-08-09.at.10.52.25.moviOS: NativeScreen.Recording.2024-08-09.at.10.54.22.moviOS: mWeb SafariScreen.Recording.2024-08-09.at.10.50.00.movMacOS: Chrome / SafariScreen.Recording.2024-08-09.at.10.43.47.movMacOS: DesktopScreen.Recording.2024-08-09.at.10.57.41.mov |
@rezkiy37 I found the following bug
web-resize.mp4 |
@dukenv0307, I've fixed - 6d86ef9. There was a problem with BottomTabBar not reacting to violation changes. Updates.mp4 |
…/46416-rbr-display
Thank you @rezkiy37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
The PR fixes a case when the Inbox and Workspace list detect RBR for one transaction thread report.
Fixed Issues
$ #46416
PROPOSAL: N/A
Tests
Offline tests
Same as "Tests".
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.mp4
Android: mWeb Chrome
Android.Chrome.mp4
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS.Safari.mp4
MacOS: Chrome / Safari
Chrome.mp4
MacOS: Desktop
Desktop.mp4