Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBR displayed in LHN in Most recent mode #46416

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 29, 2024 · 26 comments
Closed
1 of 6 tasks

RBR displayed in LHN in Most recent mode #46416

m-natarajan opened this issue Jul 29, 2024 · 26 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1721709354021959

Action Performed:

  1. Launch the app
  2. Observe LHN

Expected Result:

LHN status same in both preference mode

Actual Result:

RBR status in Most recent mode and no RBR in focus mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

CleanShot 2024-07-23 at 14 34 52@2x

CleanShot 2024-07-23 at 14 34 02@2x

CleanShot 2024-07-23 at 14 36 42@2x

onyx-state (1).txt

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jul 29, 2024
Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Jul 29, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 29, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@rezkiy37
Copy link
Contributor

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

@rezkiy37
Copy link
Contributor

I've tested it on my account. Looks like I have the inverted bug. RBR is not displayed, but there is a report with an error. Continue investigation.

Bug.mp4

@rezkiy37
Copy link
Contributor

I've fixed a case when the Inbox and Workspace list detect RBR for one transaction thread report. Opened a draft PR (#46575). Continue investigation.

Fix.mp4

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 1, 2024

Preparing the draft PR.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2024
@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 2, 2024

I've opened the PR (#46575) for review. Also, I am still working on reproducing the initial bug.

@trjExpensify
Copy link
Contributor

What's the latest here, are we ready to close this out after the regression period for #46575?

@dubielzyk-expensify
Copy link
Contributor

Just FYI that I still have this bug

@rezkiy37
Copy link
Contributor

I am continuing the investigation.

@rezkiy37
Copy link
Contributor

rezkiy37 commented Aug 16, 2024

Other tasks occupied me, I will post updates next week.

@rezkiy37
Copy link
Contributor

Actively working on the issue.
@dubielzyk-expensify, can you please generate a new Onyx state file, because the old one is deprecated for the current app version? By the way, please check which kind of RBR you have for reports in the most recent mode. Is it a transaction either DM or workspace chat?

@rezkiy37
Copy link
Contributor

I've found missed RBRs during testing on a high-traffic account ([email protected]).

Details

Screenshot 2024-08-19 at 14 52 03 Screenshot 2024-08-19 at 14 52 40

@dubielzyk-expensify
Copy link
Contributor

The error was here for ages, but it seems like it's now gone away :( Still want me to generate Onyx?

@rezkiy37
Copy link
Contributor

@dubielzyk-expensify if it has gone away so let's close the issue. The bug was fixed.

@dubielzyk-expensify
Copy link
Contributor

Yeah sounds good to me. I'll let y'all know if it reappears

@rezkiy37
Copy link
Contributor

Certainly!

@rezkiy37
Copy link
Contributor

@m-natarajan, please close the issue.

@trjExpensify
Copy link
Contributor

Closing!

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Aug 26, 2024
@dukenv0307
Copy link
Contributor

dukenv0307 commented Oct 1, 2024

@rezkiy37 @trjExpensify I think we forgot to process payment. I was not assigned to this issue but I have reviewed the PR

@rezkiy37
Copy link
Contributor

rezkiy37 commented Oct 1, 2024

Honestly, I don't manage payments.

@trjExpensify
Copy link
Contributor

Payment summary as follows:

Offer sent.

@dukenv0307
Copy link
Contributor

@trjExpensify Thanks for assisting, I accepted the offer.

@trjExpensify
Copy link
Contributor

Paid!

@trjExpensify
Copy link
Contributor

There was an Upwork bug, so I've just paid you a bonus for the amount that should have been paid @dukenv0307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

7 participants