-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Hide video playback controls on auto-playing videos #43349
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
944c6ed
fix Hide video playback controls on auto-playing videos
tienifr fe167aa
fix lint
tienifr 9caa203
fix update controlsStatus
tienifr 8a7993d
fix use runOnJS
tienifr 6bf5ec3
fix merge main
tienifr 19c70fc
fix merge main
tienifr cf99a4c
fix auto hide controls after playing video 2s
tienifr 964a0d2
fix missing condition
tienifr 5daecf0
fix lint
tienifr cfe687a
fix lint
tienifr 54fa6d5
fix merge main
tienifr f1f9bea
fix do not play video on tap
tienifr 61dacf5
fix merge main
tienifr 801707f
fix reset the debounce once click on video
tienifr b92b079
fix merge main
tienifr 2fc8759
fix do not hide control if popover is opening
tienifr ab2d8ed
Merge branch 'Expensify:main' into fix/42323
tienifr 6a871f3
merge main
tienifr 80504a8
remove canToggleControlOnTap and fix lint
tienifr 1cb1e81
fix type
tienifr f73f558
fix lint
tienifr e274b3a
merge main
tienifr b81117f
fix hover over video should display control in dekstop
tienifr dd15a3d
fix lint
tienifr 53f69d6
do not delay hide control & hide control on tap
tienifr 8f5c197
reduce hide delay to 1500
tienifr 7034385
Merge branch 'main' of https://github.com/tienifr/App into fix/42323
tienifr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need an early return here. Otherwise,
showControl
will trigger the timer to hide the controls for large screen devices.