Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

eucool · 2024-04-19T10:13:20Z

Details

Fixed Issues

$ #40539
$ #32000 (comment)
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

323932364-01479404-684f-4264-8966-a70b3aa8dd12.mov

MacOS: Desktop

Screen.Recording.2024-04-19.at.3.48.45.PM.mov

Android: Native

Cannot drag and drop on this device

Android: mWeb Chrome

Cannot drag and drop on this device

iOS: Native

Cannot drag and drop on this device

iOS: mWeb Safari

Cannot drag and drop on this device

melvin-bot · 2024-04-19T10:13:25Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-04-19T10:21:09Z

@codinggeek2023 Could you explain why the issue occurred in the first place? I'm not convinced that this is the root cause of the problem because the style on the view existed prior to the conversion to TypeScript.

eucool · 2024-04-19T10:22:41Z

https://github.com/Expensify/App/pull/36314/files#diff-4e0b0580248f90ba465db30bd004e2d10dd5be5da9a2908dc5c57bff576062a3L420-R429

Here we change this from top to y as we don't have a property called as top in typescript for nativeEvent.layout

eucool · 2024-04-19T10:27:06Z

One other option is we put a @ts-expect-error exception, that will make sure the correct style is applied, do we proceed this way ? @akinwale

MonilBhavsar

Can you update title to meaningful phrase please

eucool · 2024-04-19T10:29:06Z

@MonilBhavsar

One other option is we put a @ts-expect-error exception, that will make sure the correct style is applied, do we proceed this way ?

Do we want to do go this way?

MonilBhavsar · 2024-04-19T10:55:00Z

Okay, I tested and looks like this is still not a ideal fix. The image before drop and while dropping should have same position, which is not the case with this branch

eucool · 2024-04-19T10:55:14Z

@MonilBhavsar , I think we need to follow the pattern we used in native where zoom property didn't exit but we still used it as it was needed:

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 101 to 102 in 305f12c

    
           // @ts-expect-error there is a type mismatch in typescipt types for MediaStreamTrack microsoft/TypeScript#39010 
        
           .getUserMedia({video: {facingMode: {exact: 'environment'}, zoom: {ideal: 1}}})

eucool · 2024-04-19T10:57:40Z

Okay, I tested and looks like this is still not a ideal fix. The image before drop and while dropping should have same position, which is not the case with this branch

I tested if we use top here and put an exception then we get the ui drop at the exact same place:

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 489 in 305f12c

    
           <View onLayout={({nativeEvent}) => setReceiptImageTopPosition(PixelRatio.roundToNearestPixel(nativeEvent.layout.y))}>

Screen.Recording.2024-04-19.at.4.28.01.PM.mov

MonilBhavsar · 2024-04-19T10:59:32Z

I think we need to follow the pattern we used in native where zoom property didn't exit but we still used it as it was needed:

Looking...

I tested if we use top here and put an exception then we get the ui drop at the exact same place:

I don't think that's the ideal way

MonilBhavsar · 2024-04-19T11:32:22Z

Okay, I tried if we can derive top from other properties of layout object, but no dice
I think we can ignore ts error as top is defined https://expensify.slack.com/archives/C01GTK53T8Q/p1713526245267319?thread_ts=1712578137.578349&cid=C01GTK53T8Q

eucool · 2024-04-19T11:48:33Z

pushed the latest changes @akinwale @MonilBhavsar :)

MonilBhavsar · 2024-04-19T12:44:37Z

src/pages/iou/request/step/IOURequestStepScan/index.tsx

@@ -486,7 +486,10 @@ function IOURequestStepScan({

    const desktopUploadView = () => (
        <>
-            <View onLayout={({nativeEvent}) => setReceiptImageTopPosition(PixelRatio.roundToNearestPixel(nativeEvent.layout.y))}>
+            <View
+                // @ts-expect-error `LayoutChangeEvent` doesn't contain a `top` property, but it is needed in the code to set the position of the receipt image


LayoutChangeEvent doesn't contain a top property

This is not true. It has a top property but not defined in the types(I haven't closely looked at this)

https://expensify.slack.com/archives/C01GTK53T8Q/p1713526934258789?thread_ts=1712578137.578349&cid=C01GTK53T8Q

yes you’re right

@codinggeek2023 , i think you should instead change the comment that we have don’t have top defined on types!

akinwale · 2024-04-19T16:07:10Z

@codinggeek2023 Please update the PR based on https://expensify.slack.com/archives/C01GTK53T8Q/p1713539777823679?thread_ts=1712578137.578349&cid=C01GTK53T8Q as that's a much cleaner approach. Thanks.

eucool · 2024-04-19T16:49:34Z

I did go through the conversation, i’m out currently, will update the latest changes As soon as I get back to my laptop

…

On Fri, Apr 19, 2024 at 9:37 PM Akinwale Ariwodola ***@***.***> wrote: @codinggeek2023 <https://github.com/codinggeek2023> Please update the PR based on https://expensify.slack.com/archives/C01GTK53T8Q/p1713539777823679?thread_ts=1712578137.578349&cid=C01GTK53T8Q as that's a much cleaner approach. Thanks. — Reply to this email directly, view it on GitHub <#40545 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BFJXGIZBNPYROJICP23AF3LY6E6MJAVCNFSM6AAAAABGO4UFDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHA3TMNBRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

MonilBhavsar · 2024-04-22T18:04:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-04-24T00:07:47Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:46:06Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Update ReceiptDropUI.tsx

fb442dd

eucool requested a review from a team as a code owner April 19, 2024 10:13

melvin-bot bot requested review from akinwale and removed request for a team April 19, 2024 10:13

MonilBhavsar reviewed Apr 19, 2024

View reviewed changes

eucool mentioned this pull request Apr 19, 2024

[HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40539

Closed

6 tasks

eucool changed the title ~~[Fix]: https://github.com/Expensify/App/issues/40539~~ [Fix]: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP Apr 19, 2024

MonilBhavsar changed the title ~~[Fix]: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP~~ [CP Staging] Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP Apr 19, 2024

eucool added 2 commits April 19, 2024 17:12

Update index.tsx

3de0402

Update ReceiptDropUI.tsx

bdc4872

eucool and others added 2 commits April 19, 2024 17:22

Update index.tsx

18b065c

Fix lint

78fac91

MonilBhavsar reviewed Apr 19, 2024

View reviewed changes

eucool and others added 3 commits April 20, 2024 02:10

Update index.tsx

36dae00

Merge branch 'Expensify:main' into main

4492af1

Add DOMRect

7aa7b2e

MonilBhavsar approved these changes Apr 22, 2024

View reviewed changes

MonilBhavsar merged commit c395466 into Expensify:main Apr 22, 2024
15 checks passed

MonilBhavsar changed the title ~~[CP Staging] Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP~~ Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP Apr 22, 2024

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

melvin-bot bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-02] [$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript #32000

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

eucool commented Apr 19, 2024 •

edited

Loading

melvin-bot bot commented Apr 19, 2024

akinwale commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

MonilBhavsar left a comment

eucool commented Apr 19, 2024 •

edited

Loading

MonilBhavsar commented Apr 19, 2024

eucool commented Apr 19, 2024

eucool commented Apr 19, 2024 •

edited

Loading

MonilBhavsar commented Apr 19, 2024

MonilBhavsar commented Apr 19, 2024

eucool commented Apr 19, 2024

MonilBhavsar Apr 19, 2024

allgandalf Apr 19, 2024

akinwale commented Apr 19, 2024

eucool commented Apr 19, 2024 via email

MonilBhavsar commented Apr 22, 2024 •

edited

Loading

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

Conversation

eucool commented Apr 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 19, 2024

akinwale commented Apr 19, 2024 • edited Loading

eucool commented Apr 19, 2024 • edited Loading

eucool commented Apr 19, 2024 • edited Loading

MonilBhavsar left a comment

Choose a reason for hiding this comment

eucool commented Apr 19, 2024 • edited Loading

MonilBhavsar commented Apr 19, 2024

eucool commented Apr 19, 2024

eucool commented Apr 19, 2024 • edited Loading

MonilBhavsar commented Apr 19, 2024

MonilBhavsar commented Apr 19, 2024

eucool commented Apr 19, 2024

MonilBhavsar Apr 19, 2024

Choose a reason for hiding this comment

allgandalf Apr 19, 2024

Choose a reason for hiding this comment

akinwale commented Apr 19, 2024

eucool commented Apr 19, 2024 via email

MonilBhavsar commented Apr 22, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

eucool commented Apr 19, 2024 •

edited

Loading

akinwale commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

eucool commented Apr 19, 2024 •

edited

Loading

MonilBhavsar commented Apr 22, 2024 •

edited

Loading