[HOLD for payment 2024-05-02] [$250] [TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/EditRequestReceiptPage.js	10
src/pages/iou/ReceiptDropUI.js	8
src/pages/iou/ReceiptSelector/index.native.js	27
src/pages/iou/ReceiptSelector/index.js	30
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.native.js	4
src/pages/iou/ReceiptSelector/NavigationAwareCamera/index.js	5
src/pages/iou/ReceiptSelector/CameraPermission/index.js	0
src/pages/iou/ReceiptSelector/CameraPermission/index.ios.js	1
src/pages/iou/ReceiptSelector/CameraPermission/index.android.js	1

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01420471b55c08c38c
• Upwork Job ID: 1750848104777138176
• Last Price Increase: 2024-01-26
• Automatic offers:
• akinwale | Reviewer | 28123473

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[blazejkustra]

@abzokhattab @shahinyan11 Have you read Vit message on slack? 😅

[eucool]

dibs Slack

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01420471b55c08c38c

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[eucool]

dibs slack

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @codinggeek2023 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[eucool]

Please review this day after tomorrow,

we are having merge conflicts in the whole file, will need to remigrate it to typescript :)

Major components were changed so have to remigrate few files :)

[eucool]

@akinwale, thanks for the wait, fixed most of it, left few comments too, can you address them when you find time please :)

[eucool]

PR is ready for review @akinwale !

[Christinadobrzyn]

hi @akinwale can you provide an update? Thank you!

[akinwale]

@Christinadobrzyn Left some feedback yesterday.

cc @codinggeek2023

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40545

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @codinggeek2023 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[Christinadobrzyn]

@akinwale do we need a regression test for this?

[akinwale]

@Christinadobrzyn Yes, we do. I'll complete the checklist today.

[akinwale]

• [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Steps

1. Launch Expensify
2. Click on the global create menu and select Submit expense
3. Switch to the Scan tab if not already active
4. Execute the following steps based on the platform

Web Safari/Chrome and Desktop

• Upload an image.
• Verify that the image was successfully uploaded and the app can navigate to the confirmation page afterwards.

Native Android / iOS and mWeb

• Select a photo from the gallery or take a new picture.
• Verify that the photo was successfully selected or taken, and the app can navigate to the confirmation page afterwards.

Do we agree 👍 or 👎?

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/392952

Payouts due:

• Contributor: $250 @codinggeek2023 (can you please accept this offer - https://www.upwork.com/nx/wm/offer/102143503)

• Contributor+: $250 @akinwale (paid in Upwork here - https://www.upwork.com/nx/wm/workroom/36147749/overview)

• @akinwale just a heads up that the price for this job was listed at $500 but we pay $250 for these TS Migration jobs so I adjusted the price in the offer. let me know if you have any questions about that!

Upwork posting - https://www.upwork.com/ab/applicants/1750848104777138176/job-details

[akinwale]

• @akinwale just a heads up that the price for this job was listed at $500 but we pay $250 for these TS Migration jobs so I adjusted the price in the offer. let me know if you have any questions about that!

I was aware of this. Thanks!

[eucool]

Accepted the offer @Christinadobrzyn

[Christinadobrzyn]

Awesome! this is paid out based on this payment summary - #32000 (comment)

Closing - let me know if I missed anything!