Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

FitseTLT · 2024-03-23T18:48:59Z

Details

Fixed Issues

$ #38044
PROPOSAL: #38044 (comment)

Tests

Precondition:

User is an employee of Collect workspaces.
Tag requirement is toggled on.
Upload a new set of independent multilevel tags.
One last thing change the order of the tags (for instance push the second tag up into the first spot)

Go to staging.new.expensify.com
Go to workspace chat.
Create a manual request without tags.
Go to request details page.
Select all the tags.
Verify that no longer valid violation is not displayed

Verify that no errors appear in the JS console

Offline tests

same

QA Steps

same

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

nativ.mp4

Android: mWeb Chrome

and.we.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-03-23T18:49:04Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-03-25T04:42:16Z

@FitseTLT Pls use getSortedTagKeys in other places as well

src/libs/PolicyUtils.ts

FitseTLT · 2024-03-25T13:03:26Z

@FitseTLT Pls use getSortedTagKeys in other places as well

No other place that fits with the function. The closest is this one

App/src/libs/PolicyUtils.ts

Lines 196 to 198 in e72e186

    
           return Object.values(policyTagList) 
        
               .filter((policyTagListValue) => policyTagListValue !== null) 
        
               .sort((tagA, tagB) => tagA.orderWeight - tagB.orderWeight);

But it is taking a policy object and returning ordered policy array.

dukenv0307 · 2024-03-25T15:28:48Z

@FitseTLT I believe we need to update other places as well. You can search const policyTagKeys = to find them. If not we can face with the following bug:

Screen.Recording.2024-03-25.at.22.26.19.mov

dukenv0307 · 2024-03-27T02:53:15Z

will review in a few hours

dukenv0307 · 2024-03-27T05:30:28Z

@FitseTLT What about that place

App/src/libs/Violations/ViolationsUtils.ts

Lines 19 to 20 in 9d9757f

    
           const policyTagKeys = Object.keys(policyTagList); 
        
           const policyTagListName = policyTagKeys[0];

We're getting the first tag key, so I think it should be sorted

We also need to sort policyTagKeys here

App/src/libs/ModifiedExpenseMessage.ts

Line 197 in 9d9757f

Object.keys(policyTags).forEach((policyTagKey, index) => {

to preserve the sort order

FitseTLT · 2024-03-27T09:24:45Z

First one is a single level tag no need for sorting
Second place also not necessary the logic BTW policyTagKey is unused variable. and the loop is there only to find the tag that has changed. So as the ordering exists in getTagListName

App/src/libs/PolicyUtils.ts

Lines 189 to 190 in 9012606

    
           const policyTagKeys = getSortedTagKeys(policyTagList ?? {}); 
        
           const policyTagKey = policyTagKeys[tagIndex] ?? '';

It gets the right tag name ,and the other place it uses the index is on splittedTag splittedOldTag which are also ordered.

FitseTLT · 2024-03-27T09:31:45Z

For the second one you pointed I have applied it for logic clarity but it wasn't necessary as I explained it ^

dukenv0307 · 2024-03-28T04:20:36Z

For the second one you pointed I have applied it for logic clarity but it wasn't necessary as I explained it ^

@FitseTLT Thanks for your explanation, I didn't realize that policyTagKey is unused variable. Our target is to get the value, but I don't know why we have to do that logic below while we can get the value directly

App/src/libs/ModifiedExpenseMessage.ts

Line 198 in 9d9757f

    
           const policyTagListName = PolicyUtils.getTagListName(policyTags, index) || localizedTagListName;

Even though you fixed the order problem, it seems redundant to me since we have to sort the tagKeys 2 times and there's a unused variable. Here's my suggestion

        PolicyUtils.getSortedTagKeys(policyTags).forEach((policyTagKey, index) => {
            const policyTagListName = policyTags[policyTagKey].name || localizedTagListName

dukenv0307 · 2024-03-28T04:26:57Z

There's only one point that needs to improve. The rest looks good to me

FitseTLT · 2024-03-28T17:49:42Z

U can proceed

dukenv0307 · 2024-03-29T03:31:31Z

code looks good, starting to record videos now

dukenv0307 · 2024-03-29T03:33:34Z

@FitseTLT Pls update Offline test and QA tests. We can simply add Same as above

dukenv0307 · 2024-03-29T03:42:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

web-resize.mp4

Android: mWeb Chrome

web-resize.mp4

iOS: Native

web-resize.mp4

iOS: mWeb Safari

web-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

web-resize.mp4

dukenv0307 · 2024-03-29T08:23:09Z

@FitseTLT Pls ping/tag C+ whenever you need to review again. Thanks

JmillsExpensify · 2024-03-29T14:18:33Z

@cead22 You're up when you get a chance!

cead22 · 2024-03-29T17:17:13Z

src/libs/actions/Policy.ts

@@ -2403,7 +2403,7 @@ function buildOptimisticPolicyRecentlyUsedTags(policyID?: string, transactionTag
        }

        const tagListKey = policyTagKeys[index];
-        newOptimisticPolicyRecentlyUsedTags[tagListKey] = [...new Set([...tag, ...(policyRecentlyUsedTags[tagListKey] ?? [])])];
+        newOptimisticPolicyRecentlyUsedTags[tagListKey] = [...new Set([tag, ...(policyRecentlyUsedTags[tagListKey] ?? [])])];


Why this change?

I got another bug and fixed. spreading tag means every letter in the tag will be included in the list that's why recently used tags now doesn't work BTW.

melvin-bot · 2024-03-29T22:21:58Z

@cead22 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

cead22 · 2024-03-29T22:23:45Z

This is the second time this has happened to me this week, so I think we may have a bug and maybe we should mark approveAndMerge as passed, and not as skipped. All the checks than ran passed, and this is not an emergency change

OSBotify · 2024-03-29T22:28:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-02T11:14:33Z

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T10:55:05Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

order tags for multilevel tag violation

e72e186

FitseTLT requested a review from a team as a code owner March 23, 2024 18:49

melvin-bot bot requested review from dukenv0307 and removed request for a team March 23, 2024 18:49

dukenv0307 reviewed Mar 25, 2024

View reviewed changes

src/libs/PolicyUtils.ts Outdated Show resolved Hide resolved

FitseTLT added 2 commits March 26, 2024 11:19

Merge branch 'main' into fix-unordered-tags-on-violation-bug

65d1759

used sorted keys on other places

9012606

FitseTLT requested a review from dukenv0307 March 26, 2024 09:07

used sorted keys for logic clarity

fb64691

FitseTLT added 2 commits March 28, 2024 20:36

Merge branch 'main' into fix-unordered-tags-on-violation-bug

ab1b4f2

updated modifiedexpense logic

c6343c8

FitseTLT mentioned this pull request Mar 28, 2024

[FIXED] on IOU - The TAG from a new IOU created is not displayed in the Recent list #39205

Closed

6 tasks

dukenv0307 approved these changes Mar 29, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 March 29, 2024 08:23

cead22 reviewed Mar 29, 2024

View reviewed changes

cead22 approved these changes Mar 29, 2024

View reviewed changes

cead22 merged commit d6a36d3 into Expensify:main Mar 29, 2024
20 checks passed

melvin-bot bot added the Emergency label Mar 29, 2024

cead22 removed the Emergency label Mar 29, 2024

ntdiary mentioned this pull request Apr 1, 2024

fix: tag name in RHP is not correct #38988

Merged

50 tasks

github-actions bot mentioned this pull request Apr 2, 2024

Deploy Checklist: New Expensify 2024-04-02 #39399

Closed

87 tasks

lanitochka17 mentioned this pull request Apr 3, 2024

Tag - Tag selection cleared if selected before missing tag violation appears #39498

Closed

6 tasks

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [Violations] [$500] Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38044

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

FitseTLT commented Mar 23, 2024 •

edited

Loading

melvin-bot bot commented Mar 23, 2024

dukenv0307 commented Mar 25, 2024

FitseTLT commented Mar 25, 2024

dukenv0307 commented Mar 25, 2024

dukenv0307 commented Mar 27, 2024

dukenv0307 commented Mar 27, 2024

FitseTLT commented Mar 27, 2024

FitseTLT commented Mar 27, 2024

dukenv0307 commented Mar 28, 2024 •

edited

Loading

dukenv0307 commented Mar 28, 2024

FitseTLT commented Mar 28, 2024

dukenv0307 commented Mar 29, 2024

dukenv0307 commented Mar 29, 2024

dukenv0307 commented Mar 29, 2024 •

edited

Loading

dukenv0307 commented Mar 29, 2024

JmillsExpensify commented Mar 29, 2024

cead22 Mar 29, 2024

FitseTLT Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

cead22 commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

Conversation

FitseTLT commented Mar 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 23, 2024

dukenv0307 commented Mar 25, 2024

FitseTLT commented Mar 25, 2024

dukenv0307 commented Mar 25, 2024

dukenv0307 commented Mar 27, 2024

dukenv0307 commented Mar 27, 2024

FitseTLT commented Mar 27, 2024

FitseTLT commented Mar 27, 2024

dukenv0307 commented Mar 28, 2024 • edited Loading

dukenv0307 commented Mar 28, 2024

FitseTLT commented Mar 28, 2024

dukenv0307 commented Mar 29, 2024

dukenv0307 commented Mar 29, 2024

dukenv0307 commented Mar 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Mar 29, 2024

JmillsExpensify commented Mar 29, 2024

cead22 Mar 29, 2024

Choose a reason for hiding this comment

FitseTLT Mar 29, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Mar 29, 2024

cead22 commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

OSBotify commented Apr 8, 2024

FitseTLT commented Mar 23, 2024 •

edited

Loading

dukenv0307 commented Mar 28, 2024 •

edited

Loading

dukenv0307 commented Mar 29, 2024 •

edited

Loading