[HOLD for payment 2024-04-15] [Violations] [$500] Multilevel tags - "no longer valid" violation is shown after selecting all the tags

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspaces that have independent and dependent multilevel tags.
• Tag requirement is toggled on.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request without tags.
4. Go to request details page.
5. Select all the tags.

Expected Result:

Tag violation will disappear after selecting the tags.

Actual Result:

After selecting all the tag, the last tag shows "no longer valid".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409633_1710163056343.20240311_211507.mp4

Bug6409633_1710163006169!independant_tag.csv

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dukenv0307

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e30e5ceb96930999
• Upwork Job ID: 1767604738588979200
• Last Price Increase: 2024-03-19
• Automatic offers:
• dukenv0307 | Contributor | 0
• FitseTLT | Contributor | 0

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kavimuru]

@grgia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave6-collect-submitters. cc @greg-schroeder

[grgia]

Maybe related to #37461

[grgia]

Asked in slack https://expensify.slack.com/archives/C07J32337/p1710167047439949

[cead22]

Taking over because this definitely comes from my PR. That said, let's not block deploys on this since violations are in beta

[cead22]

I found the problem with this, and it's that we're not using the tag lists orderWeight to check the tag lists in the right order when getTagViolationsForMultiLevelTags, and the following diff seems to solve the problem

diff --git a/src/libs/Violations/ViolationsUtils.ts b/src/libs/Violations/ViolationsUtils.ts
index fe2e5af537..b6aa513072 100644
--- a/src/libs/Violations/ViolationsUtils.ts
+++ b/src/libs/Violations/ViolationsUtils.ts
@@ -55,7 +55,11 @@ function getTagViolationsForMultiLevelTags(
     policyRequiresTags: boolean,
     policyTagList: PolicyTagList,
 ): TransactionViolation[] {
-    const policyTagKeys = Object.keys(policyTagList);
+    let orderedTagList = new Array(Object.keys(policyTagList).length);
+    for (const tagList in policyTagList) {
+        orderedTagList[policyTagList[tagList].orderWeight] = policyTagList[tagList].name;
+    }
+    const policyTagKeys = orderedTagList;
     const selectedTags = updatedTransaction.tag?.split(CONST.COLON) ?? [];
     let newTransactionViolations = [...transactionViolations];
     newTransactionViolations = newTransactionViolations.filter(

I'm going to label this External to get a proper proposal and move this forward

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e30e5ceb96930999

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@FitseTLT Waiting for your PR

[JmillsExpensify]

PR is on staging, so we'll start the regression period as soon as this hits production.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38881

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dukenv0307] Determine if we should create a regression test for this bug.
• [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• Contributor: $500 - @FitseTLT paid via Upwork
• C+: $500 - @dukenv0307 paid via Upwork

[laurenreidexpensify]

Waiting on @dukenv0307 to complete checklist and confirm regression steps

[laurenreidexpensify]

Bump for checklist @dukenv0307

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. No
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[dukenv0307]

@laurenreidexpensify Sorry for the delay. I completed the checklist ^