Fix money request amount input is partially visible after going back from currency selection page #34787

bernhardoj · 2024-01-19T08:37:19Z

Details

We use auto grow width for the amount input and setting the width based on the width of the text. But when the page is unfocused by going to another page, the width will becomes 0 and we set a minimum of 8 of width, so it's partially visible.

Fixed Issues

$ #33465
PROPOSAL: #33465 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open money request page
Enter any long amount
Press the currency button and select any currency
Verify when going back from currency selection page, the amount input is fully visible

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-19.at.16.17.57.mov

Android: mWeb Chrome

Screen.Recording.2024-01-19.at.16.20.13.mov

iOS: Native

Screen.Recording.2024-01-19.at.16.29.07.mov

iOS: mWeb Safari

Screen.Recording.2024-01-19.at.16.25.35.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-19.at.16.13.48.mov

MacOS: Desktop

Screen.Recording.2024-01-19.at.16.16.24.mov

melvin-bot · 2024-01-19T08:37:23Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-01-19T08:37:25Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-01-26T11:47:45Z

@situchan please review this when you got the chance 🙇

situchan · 2024-01-26T13:54:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome-before-fix.mov

mchrome1.mov

mchrome2.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan

marcochavezf

Thanks guys, LGTM

OSBotify · 2024-01-26T22:40:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2024-01-27T01:29:27Z

This caused a minor regression:

web.mov

roryabraham · 2024-01-27T01:32:45Z

Can be fixed like so:

diff --git a/src/components/TextInput/BaseTextInput/index.native.tsx b/src/components/TextInput/BaseTextInput/index.native.tsx
index afd796d8c8..7a230bc90f 100644
--- a/src/components/TextInput/BaseTextInput/index.native.tsx
+++ b/src/components/TextInput/BaseTextInput/index.native.tsx
@@ -426,7 +426,7 @@ function BaseTextInput(
                         styles.visibilityHidden,
                     ]}
                     onLayout={(e) => {
-                        if (e.nativeEvent.layout.width === 0) {
+                        if (e.nativeEvent.layout.width === 0 && e.nativeEvent.layout.height === 0) {
                             return;
                         }
                         setTextInputWidth(e.nativeEvent.layout.width);
diff --git a/src/components/TextInput/BaseTextInput/index.tsx b/src/components/TextInput/BaseTextInput/index.tsx
index 4fa47eff41..7ca8c69153 100644
--- a/src/components/TextInput/BaseTextInput/index.tsx
+++ b/src/components/TextInput/BaseTextInput/index.tsx
@@ -447,7 +447,7 @@ function BaseTextInput(
                         styles.visibilityHidden,
                     ]}
                     onLayout={(e) => {
-                        if (e.nativeEvent.layout.width === 0) {
+                        if (e.nativeEvent.layout.width === 0 && e.nativeEvent.layout.height === 0) {
                             return;
                         }
                         let additionalWidth = 0;

situchan · 2024-01-27T02:03:48Z

Thanks for the suggestion. But that didn't work either 😞

Screen.Recording.2024-01-27.at.8.02.29.AM.mov

@bernhardoj I think we should revert this

marcochavezf · 2024-01-27T02:11:58Z

Oh interesting, yeah I think it would be better to revert atm and figure out an ultimate solution

marcochavezf · 2024-01-27T02:13:25Z

PR for straight revert #35273 cc @roryabraham

bernhardoj · 2024-01-27T03:55:27Z

I see. I forget to consider the auto-grow height case. The suggestion from @roryabraham actually works or we can handle it case by case

if (e.nativeEvent.layout.width > 0) {
    // set the new width
}

if (e.nativeEvent.layout.height > 0) {
    // set the new height
}

@situchan which one you prefer.

OSBotify · 2024-01-29T19:24:51Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

…ment-1912900085

OSBotify · 2024-01-31T02:31:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ignore width if 0

72b4fb9

bernhardoj requested a review from a team as a code owner January 19, 2024 08:37

melvin-bot bot requested review from situchan and removed request for a team January 19, 2024 08:37

situchan approved these changes Jan 26, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf January 26, 2024 13:55

marcochavezf approved these changes Jan 26, 2024

View reviewed changes

marcochavezf merged commit 8a55c77 into Expensify:main Jan 26, 2024
16 checks passed

roryabraham mentioned this pull request Jan 27, 2024

[HOLD for payment 2024-02-07] [$500] IOU - App works with little delay when change the currency in Request money BNP #33465

Closed

6 tasks

marcochavezf mentioned this pull request Jan 27, 2024

Revert "Fix money request amount input is partially visible after going back from currency selection page" #35273

Merged

situchan mentioned this pull request Jan 29, 2024

Fix money request amount input is partially visible after going back from currency selection page #35297

Merged

50 tasks

github-actions bot mentioned this pull request Jan 29, 2024

Deploy Checklist: New Expensify 2024-01-29 #35328

Closed

roryabraham referenced this pull request Jan 30, 2024

Fix regression: https://github.com/Expensify/App/pull/34787\#issuecom…

6f7026f

…ment-1912900085

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix money request amount input is partially visible after going back from currency selection page #34787

Fix money request amount input is partially visible after going back from currency selection page #34787

bernhardoj commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

bernhardoj commented Jan 26, 2024

situchan commented Jan 26, 2024

situchan left a comment

marcochavezf left a comment

OSBotify commented Jan 26, 2024

roryabraham commented Jan 27, 2024

roryabraham commented Jan 27, 2024

situchan commented Jan 27, 2024

marcochavezf commented Jan 27, 2024

marcochavezf commented Jan 27, 2024

bernhardoj commented Jan 27, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024

Fix money request amount input is partially visible after going back from currency selection page #34787

Fix money request amount input is partially visible after going back from currency selection page #34787

Conversation

bernhardoj commented Jan 19, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 19, 2024

melvin-bot bot commented Jan 19, 2024

bernhardoj commented Jan 26, 2024

situchan commented Jan 26, 2024

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 26, 2024

roryabraham commented Jan 27, 2024

roryabraham commented Jan 27, 2024

situchan commented Jan 27, 2024

marcochavezf commented Jan 27, 2024

marcochavezf commented Jan 27, 2024

bernhardoj commented Jan 27, 2024

OSBotify commented Jan 29, 2024

OSBotify commented Jan 31, 2024