[HOLD for payment 2024-02-07] [$500] IOU - App works with little delay when change the currency in Request money BNP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 4.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Click the FAB menu in LHN
4. Click on "Request money" Manual.
5. Enter an amount into the BNP (11111)
6. Tap on the currency and select another currency

Expected Result:

The change of currency was applied in the BNP

Actual Result:

App works with little delay when change the currency in Request money BNP. The amount is partly visible for a moment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6323204_1703193283892.Screenrecorder-2023-12-21-20-31-19-422.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0198afa5465e45276e
• Upwork Job ID: 1737948508527403008
• Last Price Increase: 2024-01-04
• Automatic offers:
• situchan | Contributor | 28091823

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0198afa5465e45276e

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[ZhenjaHorbach]

I don't remember, but we had a ticket related to RequestStartPage performance
If it hasn't been merged yet
Maybe it will help fix the problem

[melvin-bot]

@anmurali, @narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@anmurali, @narefyev91 Eep! 4 days overdue now. Issues have feelings too...

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The request money amount input field is shown partially after coming back from the currency selection page.

What is the root cause of that problem?

The amount input uses an autoGrow behavior. The autoGrow has an invisible input to calculate the width of the input on every layout change.

App/src/components/TextInput/BaseTextInput/index.js

Lines 405 to 422 in 7d1b0f8

	{(props.autoGrow || props.autoGrowHeight) && (
	// Add +2 to width on Safari browsers so that text is not cut off due to the cursor or when changing the value
	// https://github.com/Expensify/App/issues/8158
	// https://github.com/Expensify/App/issues/26628
	<Text
	style={[...props.inputStyle, props.autoGrowHeight && styles.autoGrowHeightHiddenInput(width, maxHeight), styles.hiddenElementOutsideOfWindow, styles.visibilityHidden]}
	onLayout={(e) => {
	let additionalWidth = 0;
	if (Browser.isMobileSafari() || Browser.isSafari()) {
	additionalWidth = 2;
	}
	setTextInputWidth(e.nativeEvent.layout.width + additionalWidth);
	setTextInputHeight(e.nativeEvent.layout.height);
	}}
	>
	{/* \u200B added to solve the issue of not expanding the text input enough when the value ends with '\n' (https://github.com/Expensify/App/issues/21271) */}
	{props.value ? `${props.value}${props.value.endsWith('\n') ? '\u200B' : ''}` : props.placeholder}
	</Text>

When we go to the currency selection page, the amount page is hidden and the display style is set to none (rn-navigation behavior). If the display is changed to none, onLayout will be triggered again with a width and height of 0.

After we go back to the amount page, the amount page is visible again and the new width and height are set again, but because some platforms are lagging, we can see a while the text input has a very small width (8px).

Why 8 and not 0? Because we have a min-width of 8 (mnw2).

App/src/components/TextInput/BaseTextInput/index.js

Line 276 in 7d1b0f8

props.autoGrow && !textInputContainerStyles.minWidth && styles.mnw2,

What changes do you think we should make in order to solve the problem?

Only update the width and height state if the layout width and height is greater than 0.

if (e.nativeEvent.layout.width > 0) {
    setTextInputWidth(e.nativeEvent.layout.width + additionalWidth);
}

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@anmurali, @narefyev91 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali, @narefyev91 10 days overdue. Is anyone even seeing these? Hello?

[anmurali]

@narefyev91 can you review the proposals submitted for this?

[situchan]

@narefyev91 is now not in C+ team.
@anmurali I can take over if needed

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@anmurali @narefyev91 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@anmurali, @narefyev91 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Sounds good, thanks for the review @situchan, assigning @bernhardoj 🚀

[bernhardoj]

PR is ready

cc: @situchan

[roryabraham]

PR causes a minor regression: #34787 (comment)

[bernhardoj]

@situchan I have opened a new PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix money request amount input is partially visible after going back from currency selection page #34787
• Fix money request amount input is partially visible after going back from currency selection page #35297

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment (Needs manual offer from BZ)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[marcochavezf]

Hi @situchan, could you complete the BZ checklist?

[situchan]

BZ Checklist:
This is polish rather than bug. The root cause existed from the beginning so no offending PR.
As this was caught by QA team, we can skip regression test.

[anmurali]

@sitchan is paid
@bernhardoj your offer is here pending you accepting

[anmurali]

@bernhardoj is also paid now.