[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

TMisiukiewicz · 2023-11-07T15:40:18Z

Details

Fixing regressions from #30242. In case no parentActions or parentReportActions were found, it was returning null instead of empty object. Additionally transactions were not passed to the component correctly, causing crashes when trying to access transaction details.

I think none of these regressions would happen if we already had Typescript in this file, really happy we are making progress in this area and seeing more and more stuff rewritten 🙌

Fixed Issues

$ #30998
PROPOSAL:

Tests

Send a picture through a chat
Open the picture
Refresh the page
Verify it refreshed correctly with no crash

Verify that no errors appear in the JS console

Offline tests

QA Steps

Send a picture through a chat
Open the picture
Refresh the page
Verify it refreshed correctly with no crash

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

ANDROID_WEB.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

IOS.WEB.mp4

MacOS: Chrome / Safari

WEB.mov

MacOS: Desktop

DESKTOP.mov

melvin-bot · 2023-11-07T18:53:27Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/LHNOptionsList/OptionRowLHNData.js

src/components/LHNOptionsList/LHNOptionsList.js

situchan · 2023-11-07T19:36:26Z

Also, pull main when ready for review

src/components/LHNOptionsList/LHNOptionsList.js

TMisiukiewicz · 2023-11-08T08:57:02Z

@situchan @mountiny thanks for your reviews. I addressed all the comments

src/components/LHNOptionsList/LHNOptionsList.js

TMisiukiewicz · 2023-11-08T11:24:07Z

@situchan thank you, could you re-review please when you have a moment?

situchan · 2023-11-08T11:29:27Z

src/components/LHNOptionsList/OptionRowLHNData.js

@@ -36,9 +36,9 @@ const propTypes = {
    }),

    /** The actions from the parent report */


Suggested change

/** The actions from the parent report */

/** The action from the parent report */

good eye! done ✅

situchan · 2023-11-08T11:45:35Z

src/components/LHNOptionsList/LHNOptionsList.js

+            const itemParentReportActions = reportActions[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${itemFullReport.parentReportID}`] || {};
+            const itemParentReportAction = itemParentReportActions[itemFullReport.parentReportActionID] || {};
+            const itemPolicy = policy[`${ONYXKEYS.COLLECTION.POLICY}${itemFullReport.policyID}`] || {};
+            const transactionID = lodashGet(itemParentReportAction, [itemFullReport.parentReportActionID, 'originalMessage', 'IOUTransactionID'], '');


Suggested change

const transactionID = lodashGet(itemParentReportAction, [itemFullReport.parentReportActionID, 'originalMessage', 'IOUTransactionID'], '');

const transactionID = lodashGet(itemParentReportAction, ['originalMessage', 'IOUTransactionID'], '');

Had to watch this with 🦅's eye 😄

oh wow, the 🦅 eye indeed 🤯

situchan · 2023-11-08T11:50:32Z

Do you think transactionID is enough to satisfy this comment? I am concerned about removing transaction from dependency

TMisiukiewicz · 2023-11-08T12:21:58Z

@situchan good point, I'd say it's safer to bring back whole transaction as a dependency. I reverted changes to use transaction.

situchan · 2023-11-08T12:36:38Z

ok scan transaction title is updated in LHN

Screen.Recording.2023-11-08.at.6.31.43.PM.mov

situchan · 2023-11-08T12:47:34Z

Console errors from bad Onyx data. Not sure if it's coming from backend or Onyx but out of scope anyway

situchan · 2023-11-08T12:57:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

mountiny

Thanks for the fix

melvin-bot · 2023-11-08T14:31:35Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2023-11-08T14:32:05Z

The failing reasssure test was because of different changes in main, none of the changes in this PR influence the ReportScreens performance

OSBotify · 2023-11-08T14:36:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…-in-lhn [CP Staging] fix: correctly pass transactions and reportActions to LHN (cherry picked from commit 73627cf)

OSBotify · 2023-11-08T15:20:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.96-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-11-09T22:45:22Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T16:01:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.98-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T21:54:39Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny changed the title ~~fix: correctly pass transactions to LHN~~ [CP Staging] fix: correctly pass transactions to LHN Nov 7, 2023

mountiny assigned TMisiukiewicz Nov 7, 2023

mountiny self-requested a review November 7, 2023 17:01

TMisiukiewicz marked this pull request as ready for review November 7, 2023 18:53

TMisiukiewicz requested a review from a team as a code owner November 7, 2023 18:53

melvin-bot bot requested review from situchan and removed request for a team November 7, 2023 18:53

TMisiukiewicz changed the title ~~[CP Staging] fix: correctly pass transactions to LHN~~ [CP Staging] fix: correctly pass transactions and reportActions to LHN Nov 7, 2023

situchan reviewed Nov 7, 2023

View reviewed changes

src/components/LHNOptionsList/OptionRowLHNData.js Show resolved Hide resolved

situchan suggested changes Nov 7, 2023

View reviewed changes

src/components/LHNOptionsList/LHNOptionsList.js Outdated Show resolved Hide resolved

src/components/LHNOptionsList/LHNOptionsList.js Outdated Show resolved Hide resolved

mountiny reviewed Nov 7, 2023

View reviewed changes

src/components/LHNOptionsList/LHNOptionsList.js Outdated Show resolved Hide resolved

src/components/LHNOptionsList/LHNOptionsList.js Show resolved Hide resolved

src/components/LHNOptionsList/LHNOptionsList.js Outdated Show resolved Hide resolved

TMisiukiewicz force-pushed the fix/missing-transactions-in-lhn branch 3 times, most recently from a469afb to a206095 Compare November 8, 2023 08:56

TMisiukiewicz requested review from mountiny and situchan November 8, 2023 08:56

situchan reviewed Nov 8, 2023

View reviewed changes

src/components/LHNOptionsList/LHNOptionsList.js Outdated Show resolved Hide resolved

TMisiukiewicz requested a review from situchan November 8, 2023 11:24

TMisiukiewicz added 3 commits November 8, 2023 12:26

correctly pass transactions to lhn

3437d1f

update types

92e72de

update transactions

f55cbc0

TMisiukiewicz force-pushed the fix/missing-transactions-in-lhn branch from 754f9f5 to 342f675 Compare November 8, 2023 11:26

situchan reviewed Nov 8, 2023

View reviewed changes

TMisiukiewicz force-pushed the fix/missing-transactions-in-lhn branch from 342f675 to 6301a8a Compare November 8, 2023 11:39

TMisiukiewicz requested a review from situchan November 8, 2023 11:40

situchan suggested changes Nov 8, 2023

View reviewed changes

update parentReportAction prop

dacaba0

TMisiukiewicz force-pushed the fix/missing-transactions-in-lhn branch from 6301a8a to dacaba0 Compare November 8, 2023 12:02

revert transaction dependency removal

46d0739

TMisiukiewicz requested a review from situchan November 8, 2023 12:22

situchan approved these changes Nov 8, 2023

View reviewed changes

mountiny approved these changes Nov 8, 2023

View reviewed changes

mountiny merged commit 73627cf into Expensify:main Nov 8, 2023
13 of 14 checks passed

melvin-bot bot added the Emergency label Nov 8, 2023

mountiny removed the Emergency label Nov 8, 2023

OSBotify pushed a commit that referenced this pull request Nov 8, 2023

Merge pull request #31007 from TMisiukiewicz/fix/missing-transactions…

9df7250

…-in-lhn [CP Staging] fix: correctly pass transactions and reportActions to LHN (cherry picked from commit 73627cf)

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

melvin-bot bot mentioned this pull request Nov 10, 2023

[HOLD for payment 2023-11-17] [$500] Chat – Page crashes when open attachment preview in any chat and reload the page (Ctrl+R) #30998

Closed

6 tasks

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-10 #31187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

TMisiukiewicz commented Nov 7, 2023 •

edited

Loading

melvin-bot bot commented Nov 7, 2023

situchan commented Nov 7, 2023

TMisiukiewicz commented Nov 8, 2023

TMisiukiewicz commented Nov 8, 2023

situchan Nov 8, 2023

TMisiukiewicz Nov 8, 2023

situchan Nov 8, 2023

TMisiukiewicz Nov 8, 2023

situchan commented Nov 8, 2023

TMisiukiewicz commented Nov 8, 2023

situchan commented Nov 8, 2023

situchan commented Nov 8, 2023

situchan commented Nov 8, 2023

mountiny left a comment

melvin-bot bot commented Nov 8, 2023

mountiny commented Nov 8, 2023

OSBotify commented Nov 8, 2023

OSBotify commented Nov 8, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

		@@ -36,9 +36,9 @@ const propTypes = {
		}),

		/** The actions from the parent report */

	/** The actions from the parent report */
	/** The action from the parent report */

	const transactionID = lodashGet(itemParentReportAction, [itemFullReport.parentReportActionID, 'originalMessage', 'IOUTransactionID'], '');
	const transactionID = lodashGet(itemParentReportAction, ['originalMessage', 'IOUTransactionID'], '');

[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

[CP Staging] fix: correctly pass transactions and reportActions to LHN #31007

Conversation

TMisiukiewicz commented Nov 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 7, 2023

situchan commented Nov 7, 2023

TMisiukiewicz commented Nov 8, 2023

TMisiukiewicz commented Nov 8, 2023

situchan Nov 8, 2023

Choose a reason for hiding this comment

TMisiukiewicz Nov 8, 2023

Choose a reason for hiding this comment

situchan Nov 8, 2023

Choose a reason for hiding this comment

TMisiukiewicz Nov 8, 2023

Choose a reason for hiding this comment

situchan commented Nov 8, 2023

TMisiukiewicz commented Nov 8, 2023

situchan commented Nov 8, 2023

situchan commented Nov 8, 2023

situchan commented Nov 8, 2023

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 8, 2023

mountiny commented Nov 8, 2023

OSBotify commented Nov 8, 2023

OSBotify commented Nov 8, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

TMisiukiewicz commented Nov 7, 2023 •

edited

Loading