Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed inconmark color for adhoc build loading screen #29383

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Oct 11, 2023

Details

Fixed Issues

$ #28603

Tests

  1. Build the desktop adhoc app version
  2. Install it
  3. Run the desktop adhoc app
  4. Notice the Expensify icon color in the loading screen is the brand green
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

  1. Open an adhoc desktop app
  2. Verify that the color of the icon is the brand green instead of the dark green
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [] I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop Screenshot 2023-10-11 at 17 01 56

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@rlinoz
Copy link
Contributor Author

rlinoz commented Oct 11, 2023

I have read the CLA Document and I hereby sign the CLA

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98f65b6
Status: ✅  Deploy successful!
Preview URL: https://4348cb62.helpdot.pages.dev
Branch Preview URL: https://fix-adhoc-loading-icon.helpdot.pages.dev

View logs

@OSBotify
Copy link
Contributor

@rlinoz rlinoz marked this pull request as ready for review October 12, 2023 13:09
@rlinoz rlinoz requested a review from a team as a code owner October 12, 2023 13:09
@melvin-bot melvin-bot bot removed the request for review from a team October 12, 2023 13:09
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Julesssss
Copy link
Contributor

Hey @ntdiary, no need for a C+ review here

@Julesssss Julesssss removed the request for review from ntdiary October 12, 2023 13:13
@Julesssss
Copy link
Contributor

Julesssss commented Oct 12, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@Julesssss
Copy link
Contributor

Ignoring the new check as it is unrelated to the changes in this PR

@Julesssss Julesssss merged commit 34c2a27 into main Oct 12, 2023
13 of 14 checks passed
@Julesssss Julesssss deleted the fix-adhoc-loading-icon branch October 12, 2023 13:16
@melvin-bot melvin-bot bot added the Emergency label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Julesssss
Copy link
Contributor

Explained here

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1265.747 ms → 1385.034 ms (+119.287 ms, +9.4%) 🔴
App start runJsBundle 871.239 ms → 944.034 ms (+72.795 ms, +8.4%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1265.747 ms
Stdev: 36.156 ms (2.9%)
Runs: 1173.2032550000586 1177.9144680001773 1190.887904000003 1205.9059750000015 1206.0476429997943 1206.2945500002243 1213.055478000082 1214.392380000092 1221.002129000146 1222.0160529999994 1222.0834289998747 1223.5081890001893 1226.7028290000744 1227.115091000218 1229.6571329999715 1230.5985460001975 1231.8569020000286 1232.213078000117 1236.0279270000756 1237.9966699997894 1239.5546749997884 1239.6440420001745 1241.5589829999954 1242.0336299999617 1242.2324810000136 1242.919261999894 1244.9484709999524 1246.4411960002035 1246.7436119997874 1246.8545039999299 1249.3601500000805 1249.6928220000118 1252.5746300001629 1252.864930999931 1254.616617999971 1255.5175529997796 1258.5392889999785 1258.607369999867 1259.187481999863 1260.4855280001648 1261.883805999998 1261.9968699999154 1264.4354409999214 1265.3565690000542 1265.7975189997815 1267.4865609998815 1268.501147000119 1268.777654999867 1269.7094789999537 1271.564276999794 1271.8687459998764 1274.4515929999761 1274.7842459999956 1276.5887350002304 1278.6627779998817 1278.857466999907 1278.9202580000274 1279.7619019998237 1281.9413049998693 1282.9597669998184 1283.6818110002205 1285.1034519998357 1285.7040189998224 1285.8353800000623 1289.033760999795 1289.295917000156 1290.5043919999152 1291.0307849999517 1294.0243799998425 1294.6875809999183 1296.7590279998258 1297.3574190000072 1299.381500999909 1301.1051529999822 1301.4889159998856 1303.9296880001202 1306.9697540001944 1308.6120179998688 1308.8873310000636 1309.8994909999892 1313.6013830001466 1314.4688120000064 1314.6241489998065 1318.2421169998124 1319.889219999779 1319.922569999937 1320.8070740001276 1333.5773260002024 1336.4910450000316 1345.1724499999546

Current
Mean: 1385.034 ms
Stdev: 59.691 ms (4.3%)
Runs: 1246.3817010000348 1273.3200570000336 1274.6729700001888 1281.5763610000722 1289.1450080000795 1313.9806149997748 1317.855700999964 1319.0731399999931 1320.5662910002284 1320.6298569999635 1321.0315700001083 1324.0412809997797 1329.7641469999216 1332.1556609999388 1334.5735820000991 1338.7924239998683 1339.404841999989 1339.8054329999723 1340.7518099998124 1341.1033700001426 1341.1278229998425 1344.4950370001607 1345.443797999993 1346.9941509999335 1347.4672139999457 1347.4804369998164 1347.833593999967 1349.8643609997816 1350.5826480002142 1351.0575359999202 1351.695392999798 1352.2615209999494 1353.775154999923 1354.2068360000849 1354.9226730000228 1355.8414030000567 1358.7786030001007 1358.7848939998075 1358.9382250001654 1359.1437769997865 1359.3769169999287 1361.432244000025 1365.0366650000215 1366.2944979998283 1369.1310339998454 1370.4598670001142 1371.2471639998257 1372.905460999813 1374.3054050002247 1375.5312549998052 1382.0994380000047 1382.7397870002314 1385.138185000047 1385.5087379999459 1386.723879000172 1387.7256860001944 1388.2593120001256 1390.3093710001558 1394.0586790000089 1401.6370190000162 1402.368762999773 1406.421680000145 1408.272925000172 1409.0120939998887 1413.4714009999298 1417.4337530001067 1419.0838190000504 1420.827277999837 1423.9709990001284 1425.1723009999841 1433.6497800000943 1435.582957000006 1440.1295520002022 1440.569163999986 1442.8399249999784 1447.0435649999417 1447.6506690001115 1455.6863409997895 1462.6756640002131 1468.8384989998303 1478.0217869998887 1479.4535190002061 1480.7205730001442 1482.6177119999193 1482.7147030001506 1484.3979799998924 1489.541664000135 1490.4146560002118 1491.1693859999068 1503.7883330001496 1519.6124390000477 1520.7173799998127
App start runJsBundle Baseline
Mean: 871.239 ms
Stdev: 31.920 ms (3.7%)
Runs: 789 806 811 814 817 818 822 827 829 830 832 832 839 841 843 844 844 846 846 847 848 850 850 851 851 853 854 855 855 857 858 858 859 862 863 863 863 865 865 869 869 870 870 871 872 875 876 876 876 877 878 878 878 879 880 882 882 882 884 887 887 890 890 893 895 896 898 898 900 901 902 902 903 904 905 905 906 906 907 908 911 911 912 913 923 927 945 963

Current
Mean: 944.034 ms
Stdev: 33.715 ms (3.6%)
Runs: 855 870 877 889 894 895 899 899 903 906 907 909 912 914 914 916 917 917 919 920 921 922 923 924 924 925 925 925 926 926 927 927 930 930 931 932 932 932 935 935 936 936 936 937 942 944 944 944 946 947 949 951 954 954 955 956 957 960 960 960 962 963 964 964 964 969 969 969 972 972 973 976 976 977 981 983 985 987 989 989 991 994 995 1001 1002 1005 1022 1029

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 631.970 ms → 646.231 ms (+14.261 ms, +2.3%)
App start nativeLaunch 21.048 ms → 23.697 ms (+2.648 ms, +12.6%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.002 ms, +11.6%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 631.970 ms
Stdev: 22.938 ms (3.6%)
Runs: 592.4121090001427 596.7482910002582 601.172038000077 602.8716230001301 606.7928469995968 607.113322999794 607.2373049999587 608.1737470002845 608.4780689999461 608.5522869997658 608.5526530002244 609.0490319998935 609.0806480003521 612.5905359997414 614.4886880000122 614.8400479997508 614.9630940002389 615.0318610002287 615.0930180000141 615.8434250000864 615.8590899999253 616.0736899999902 616.0821130000986 616.0965990000404 616.9237469998188 617.0651859999634 617.1147050000727 617.4662679997273 617.9148359997198 618.2445070003159 618.2608230002224 618.9669190002605 619.1963710002601 619.2122800000943 620.3179530003108 620.8995770001784 623.0643730000593 623.1448979997076 623.1566579998471 623.3986410000362 623.5037839999422 623.9027109998278 624.0731609999202 624.3026129999198 624.4855960002169 624.8103840001859 624.9488530000672 624.9754640003666 625.0661619999446 625.1249190000817 625.3948169997893 627.6210940000601 628.6680099996738 629.1189370001666 630.3279220000841 631.4448240003549 631.847534999717 631.9847420002334 633.0305180000141 633.1027830000967 633.1198330000043 633.4647220000625 633.7062990004197 637.6359050003812 643.3240970000625 643.4139820002019 643.9146730001085 647.9519050000235 649.0457770000212 649.2392989997752 649.8930669999681 651.1722409999929 651.8592130001634 652.4474700000137 654.915974999778 657.7086589997634 660.3564050002024 664.0163580002263 666.753987999633 667.7225750000216 669.1753739998676 669.3613690002821 671.5377199999057 673.1821300000884 674.3830980001949 675.6491299998015 682.7870689998381 683.9582930002362 691.8800459997728 698.484701000154

Current
Mean: 646.231 ms
Stdev: 27.175 ms (4.2%)
Runs: 607.5845949999057 610.8862310000695 613.7151290001348 614.9552009999752 615.0078940000385 616.725260999985 617.3377690003254 617.4437259999104 617.8341479999945 618.2319339998066 618.5088710002601 618.5849609998986 619.9785569999367 620.6872159997001 620.8199869999662 621.3567709997296 621.8762619998306 621.997762999963 622.2339689997025 623.1254480001517 623.2029220000841 623.3500569998287 623.3762209997512 624.5680340002291 624.6526689999737 627.1246340004727 628.7631840002723 629.5008140001446 629.9248449997976 630.1957609998062 630.3052980001085 630.370036999695 630.632487999741 630.8267820002511 631.2084960001521 631.3389080003835 632.6269129998982 633.6937249996699 633.8522550002672 634.0670980000868 634.5606689997949 637.0817060000263 637.221476000268 637.372233000584 638.6304529998451 639.7366130002774 639.9066169997677 639.9463700000197 640.8269859999418 641.3208419997245 641.6782639999874 641.9473069999367 644.2256680000573 645.6765549997799 647.4399410001934 647.9401050005108 648.3233239999972 649.0322670000605 649.8206790001132 650.0609539998695 651.4347329996526 651.5011809999123 655.6896979999729 656.0566409998573 657.3707679999061 664.5603439998813 664.9541009999812 665.2744550001808 665.3618570002727 665.5412610000931 666.0909839998931 666.1824139999226 666.8218590002507 670.4211029997095 671.4566659997217 671.8700769999996 674.2583829998039 678.0252689998597 684.2802329999395 688.0106209996156 688.0267340000719 695.2469080002047 697.3890789998695 697.8616940001957 698.1437180000357 701.2019040007144 707.8524169996381 709.6591799999587 714.0508220000193 721.0061040003784
App start nativeLaunch Baseline
Mean: 21.048 ms
Stdev: 1.999 ms (9.5%)
Runs: 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 25 26 27 27

Current
Mean: 23.697 ms
Stdev: 2.988 ms (12.6%)
Runs: 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 25 25 25 25 25 26 26 26 26 26 26 26 26 27 27 28 28 28 28 28 28 28 29 30 31 31 32 32
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.8%)
Runs: 0.013021000195294619 0.013103000354021788 0.013387000188231468 0.013387000188231468 0.013387000188231468 0.0134680001065135 0.01346899988129735 0.013549999799579382 0.01355000026524067 0.013712999876588583 0.013712999876588583 0.013793000020086765 0.013793999794870615 0.013794000260531902 0.013835000339895487 0.013956000097095966 0.013956999871879816 0.013956999871879816 0.013996999710798264 0.014037999790161848 0.014038000255823135 0.014039000030606985 0.014078000094741583 0.014078999869525433 0.01407900033518672 0.01407900033518672 0.014119000174105167 0.014119999948889017 0.014160000253468752 0.0142000000923872 0.014201000332832336 0.014201000332832336 0.014240999706089497 0.014283000025898218 0.0143630001693964 0.01436399994418025 0.014403999783098698 0.01444500032812357 0.014485000167042017 0.014485999941825867 0.014525999780744314 0.014566999860107899 0.014567000325769186 0.014607000164687634 0.014649000018835068 0.014649000018835068 0.01472900016233325 0.0147299999371171 0.0147299999371171 0.0147299999371171 0.0147299999371171 0.014770000241696835 0.014771000016480684 0.014771000016480684 0.014851999934762716 0.014932999853044748 0.014934000093489885 0.015054999850690365 0.015054999850690365 0.01509599993005395 0.015137000009417534 0.015176999848335981 0.015218000393360853 0.0152580002322793 0.015298999845981598 0.015298999845981598 0.015299000311642885 0.015420999843627214 0.015422000084072351 0.015625 0.0157880000770092 0.01582799991592765 0.01590899983420968 0.01599099999293685 0.016032000072300434 0.01607199991121888 0.016152999829500914 0.01627599960193038 0.016398000065237284 0.016439000144600868 0.016439000144600868 0.016561000142246485 0.016642000060528517 0.016927000135183334 0.01696799974888563 0.017212000209838152 0.017496999818831682

Current
Mean: 0.016 ms
Stdev: 0.001 ms (7.3%)
Runs: 0.013427000027149916 0.013590000104159117 0.01407900033518672 0.014160000253468752 0.014323000330477953 0.0147299999371171 0.014771000016480684 0.014810999855399132 0.0148930000141263 0.015015000011771917 0.015015000011771917 0.015176999848335981 0.015217999927699566 0.015217999927699566 0.015461999922990799 0.015503000002354383 0.015583999920636415 0.015625 0.015625 0.015664999838918447 0.015705999918282032 0.015746999997645617 0.015787999611347914 0.01582799991592765 0.015868999995291233 0.015869999770075083 0.015910000074654818 0.015949999913573265 0.015992000233381987 0.015992000233381987 0.016032000072300434 0.016032000072300434 0.01607300015166402 0.016112999990582466 0.016113999765366316 0.01615400006994605 0.01615400006994605 0.016195000149309635 0.01631700014695525 0.01643899967893958 0.016480000223964453 0.016600999981164932 0.016600999981164932 0.016600999981164932 0.01660200022161007 0.016682999674230814 0.016682999674230814 0.016682999674230814 0.01672299997881055 0.016763999592512846 0.016805000137537718 0.016845999751240015 0.016846000216901302 0.016885999590158463 0.01688600005581975 0.01696799974888563 0.01696800021454692 0.01696800021454692 0.017008000053465366 0.01704900013282895 0.017089999746531248 0.017090000212192535 0.017171000130474567 0.017172000370919704 0.0172520000487566 0.0172520000487566 0.01733399974182248 0.017456000205129385 0.017496000044047832 0.017496000044047832 0.0176189998164773 0.017659000121057034 0.017741000279784203 0.017821999732404947 0.017822999972850084 0.017862999811768532 0.017862999811768532 0.017903999891132116 0.01798499980941415 0.01798499980941415 0.017985000275075436 0.017985000275075436 0.01814799988642335 0.01904299994930625 0.01912500010803342 0.01993800001218915

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023
@Julesssss
Copy link
Contributor

NO. These results are completely unreliable, this change did not cause a performance regression.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.84-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants