Deploy Checklist: New Expensify 2023-10-13

[OSBotify]

Release Version: 1.3.84-10
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Improve Google Sign In error logging #25446
• feat(Wallet): add empty state and redesign wallet page #26406
• Show eReceipts for distance requests #27204
• refactor: transformed class component to the functional #27424
• Upgrade react-native-sdk to v8.3.0 #27432
• chore: migrate withViewportOffsetTop.js class to function component #27492
• [No QA] [TS migration] Review and clean up Styles files #27660
• Update react-native-vision-camera #27820
• [No QA] [TS migration] Migrate 'Pusher' lib to TypeScript #28116
• Hide three dot in header when request is deleted #28214
• Android - Deeplink navigation does not work for RHN links. #28278
• Trim the value when going back on connect bank account #28305
• Create removing-users.md #28732
• Improve new form validation #28821
• Fix: Footer for anonymous user sign in modal distorted #28904
• fix: show large suggestion menu only if there is space #28927
• Update and rename Report-Comments.md to Report-Audit-Log-and-Comments.md #28994
• [No QA]Update Add-a-Business-Bank-Account-(AUD).md #29026
• Implement a bash script needed to configure simulators for App development #29061
• Add files via upload - Company Cards Direct Connection Images #29071
• added composer focus glitch fix #29073
• Add pin icon in the IOU report page of request amount #29078
• Add DateTimeFormat polyfill #29113
• fix: default merchant for money request with receipt #29118
• ignore concierge report id during deep link launch #29122
• feat: enable next button #29125
• fix chat-link in end of line displays tooltip over text and not on link #29134
• Add 2x files via upload #29139
• fix check of available dates of next month #29143
• [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201
• fix: 22850 task title is not focused after refresh #29203
• fix: 25779 Accessing an attachment via link that is not found shows the error page twice #29206
• Fix report screen scrollbar on Android is on the left screen #29253
• Fix: App focuses back on composer even if RHN is open on copy link from app download link in about settings #29254
• [No QA] [TS migration] Migrate 'useDragAndDrop.js' hook to TypeScript #29257
• fix blinking loader in connect bank account page #29260
• fix: Use localized message for split requests in LHN #29263
• fix MapView.tsx cleanup when blur #29270
• [Wave 8 - ECard Transactions] Show %Name Spent:% on ReportPreview  #29287
• [Wave 8- ECard Transactions] Show [Reversed transaction] for deleted transactions #29310
• Feat: add jsDoc to billable #29327
• Fix app crash when visiting bank account page #29339
• [NoQA] Revert "Testing deploy changes" #29355
• User current location button onClick fix #29366
• Changed inconmark color for adhoc build loading screen #29383
• fix: close not-found page when dismissing modal #29404
• Fix Error message displays briefly after reopening the 2FA step 2 page #29406
• update notification count #29409
• update text and alternateText in getPolicyExpenseReportOption function #29424
• [Wave 8- ECard Transactions] Update ReportPreview styling (ReportActionItemImages) #29431
• [NoQA] Change variant to mode in run-android command in package.json #29440
• fix style console error on open avatar #29461
• [NoQA] Temporarily update the getPreviousVeriosn to skip over missing tag #29465
• fix: set default textBreakStrategy for TextInput as simple #29467
• Use getBoundingClientRect as a fallback #29468
• Update Annual-Subscription.md #29472
• fix: No margin top on zip code input #29480
• [No QA] Actions can have childReportName #29486
• Update and rename Mileage.md to distance-tracking.md #29489
• Create Additional-Travel-Integrations.md #29520
• Fix wrong onyx config in ReportFooter #29529
• Allow Welcome Message on Room Creation #29541
• fix: 29543 Dot separator in the report preview component appears bottom aligned  #29544
• [NoQA] Updated podfile #29562
• [CP Staging] [No QA] Revert "Add DateTimeFormat polyfill" #29576
• [CP Staging] Fix for Android crash and not visible labels in Request money  #29629
• [CP Staging] - Only show Pending Banner for ECard Transactions #29659
• [CP Staging] Fix error when keeping default date when splitting #29664
• [CP Staging] fixes max width and pay button for report preview #29666
• [CP Staging] Add padding left back to cardMenuItem #29677
• [CP Staging] Redefine useLocalize in SplitDetailsPage #29682
• Format line breaks in split bill description #29693
• [No QA]Upload iOS and Android releases to GitHub artifacts #29698
• [CP Staging] Revert PR 28278 #29706

Internal QA:

• Minimal server search / enable improved focus mode #27819 - @marcaaron

Deploy Blockers:

• Request Money - App crashes after tapping “Request Money” #29602
• [$250] Web - Notification count in the tab flashes when back is clicked #29604
• [$250] Android-Fab-App crashes tapping on Send message and Inviting WS members #29606
• [HOLD for payment 2023-11-13] [$125] Android - Distance - Amount in the Distance e-receipt is cut off when device font size is minimum #29616
• [HOLD for payment 2023-10-30] [$250] Distance - Waypoints are not correctly ordered in generated eReceipt #29621
• Request Money - 'Manual', 'Scan', and 'Distance' is not grayed out when they are not selected #29624
• [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Desktop - When uploading a receipt via the request money flow, it shows as Pending #29625
• [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] Smart scanning header is broken #29626
• Android - Sum is disappeared after pay elsewhere in row ’Total” #29627
• Desktop - ''Hmm... it's not here'' when navigating to 'date of birth' settings via deeplink #29631
• Request money - 3-dot menu does not disappear after deleting money request #29632
• Split - Total group split details card does not appear in chat until the chat is revisited #29634
• [HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button #29639
• [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$250] Desktop - Deeplink - Error message when navigating to a conversation after logging in #29642
• [HOLD for payment 2023-10-24] [$125] Bank Account - Some menu items left icon alignment is broken #29650
• Chat - "Pay" button is not completely fitted in request preview #29651
• [$500] [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] LHN - Split bill description having line breaks is not truncated in LHN #29676
• [HOLD for payment 2023-10-30] [$500] Copy to clipboard tooltip moves to top left corner on copy to clipboard click #29678
• [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] Split bill - App crashes when opening bill split preview #29679

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.84-0 🚀

[kavimuru]

Regression is 90% completed. PRs are still being validated.
#27204 failing with #29621, Android and iOS blocked by #29602
#27820, #29263, #29118 failing with #29602
#29206 failing with #23374 - KI - Ok to check it off?
#29544 failing with #29627

[kavimuru]

Regression is completed, Only one PR is waiting for a bug to be reported.
unchecked PRs:
#27204 failing with #29621
#27204,#29118,#29125, #29143,#29263, #29270, #29541 and #29366 blocked in Android and iOS blocked by #29602
#27820 failing with #29602
#28214 failing with #29632
#28278 failing with #29631
#29206 failing with #23374 - KI - Ok to check it off
#29409 failing with #29604
#29544 failing with #29627

[kavimuru]

Regression is completed,
unchecked PRs:
#27204 failing with #29621
#27204,#29118,#29125, #29143,#29263, #29270, #29541 and #29366 blocked in Android and iOS blocked by #29602
#27820 failing with #29602
#28214 failing with #29632
#28278 failing with #29631
#29206 failing with #23374 - KI - Ok to check it off
#29409 failing with #29604
#29544 failing with #29627
#28821 failing with #29644

[mountiny]

checking off:

• fix: 25779 Accessing an attachment via link that is not found shows the error page twice #29206 - KI
• update notification count #29409 - not a blocker
• fix: 29543 Dot separator in the report preview component appears bottom aligned  #29544 - fixed in staging
• Improve new form validation #28821 - not a blocker
• Hide three dot in header when request is deleted #28214 - not a blocker
• Update react-native-vision-camera #27820 - fixed
• Show eReceipts for distance requests #27204 - not a blocker

[mountiny]

Asked QA to retest the ones they were not able to because fo the crashes

#27204, #29143, #29270, #29541 and #29366 blocked in Android and iOS blocked by #29602

[Julesssss]

Checked off #29678 as it's not important enough to block the deploy

[kavimuru]

#29118, #29125, #29143, #29263, #29541 are pass and checking it off. #29270 and #27204 still being validated.

[francoisl]

Tested 29664 internally, checking it off

[marcaaron]

Tested and checked off 27819

[francoisl]

@kavimuru we have fixes for the following blockers that were cherry-picked, can you restest them please:

• [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] Split bill - App crashes when opening bill split preview #29679
• [HOLD for payment 2023-10-24] [$125] IOU - Expense preview card is wider than the Pay button #29639
• [$500] [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] LHN - Split bill description having line breaks is not truncated in LHN #29676

[kavimuru]

@francoisl retested and it's a pass.

[francoisl]

Excellent. The last one is #28278 / #29642, which we're reverting with #29706 and it's being cherry-picked right now. I'll run some tests when the CP finishes and we should be good to go.

[francoisl]

#29642 is passing on staging, this was the last blocker. #28278 is technically not fixed since we reverted the PR, but I'll check it off for now and we'll keep working on the issue.

[francoisl]