Update `react-native-vision-camera` #27820

AndrewGable · 2023-09-20T04:03:52Z

Details

Updates react-native-vision-camera to latest which contains two fixes:

Improvements to camera lens size detection to improve camera on Xiaomi A3 devices
Improvements to compatibility with react-native-reanimated allowing us to remove the patch-package react-native-vision-camera+2.15.4.patch

Fixed Issues

$ #27691

Tests

Verify camera works for Xiaomi A3 device via clicking FAB > Request Money > Scan
Verify camera works on all other devices via clicking FAB > Request Money > Scan

Offline tests

N/A

QA Steps

Verify camera works on all devices via clicking FAB > Request Money > Scan

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-20T04:03:57Z

@ntdiary @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

AndrewGable · 2023-09-20T04:51:12Z

Facing a runtime issue with react-native-gesture-handler and I can't tell if it's a me issue or something we need to fix 🤔

aldo-expensify · 2023-09-20T05:00:39Z

I'll try to test it

AndrewGable · 2023-09-20T05:05:55Z

Let me know - After updating react-native-gesture-handler I see a different runtime error with @react-navigation 🤔 So I think it might just be a me issue

aldo-expensify · 2023-09-20T09:14:39Z

I was able to compile without problems, but it still gets stuck on spinning forever 🤔

aldo-expensify · 2023-09-20T09:15:15Z

Are we sure that this version contains the changes?

back device is still undefined

AndrewGable · 2023-09-20T09:18:30Z

I think it should 🤔 https://github.com/mrousavy/react-native-vision-camera/releases/tag/v2.16.1

ntdiary · 2023-09-20T09:26:10Z

I can also try to compile it soon.

aldo-expensify · 2023-09-20T09:27:47Z

I think it should 🤔 https://github.com/mrousavy/react-native-vision-camera/releases/tag/v2.16.1

Yes, it should I just confirmed that the changed code is there in my node_modules

ntdiary · 2023-09-20T10:31:47Z

I can compile and run it normally, without any runtime errors.

AndrewGable · 2023-09-21T04:39:35Z

@aldo-expensify - Can you try by the QR code above?

aldo-expensify · 2023-09-21T04:53:33Z

Downloading...

aldo-expensify · 2023-09-21T05:29:01Z

Tested, infinite spinner.

ntdiary · 2023-09-26T01:16:40Z

So, it looks like this upgrade didn't resolve the camera issue on A3? 🤔

AndrewGable · 2023-09-27T19:31:09Z

No, seems like we did not.

shubham1206agra · 2023-10-04T17:37:04Z

@AndrewGable What's the status of this PR?
I want to test another issue with this PR

aldo-expensify · 2023-10-05T07:29:59Z

@AndrewGable what do you think of going straight to v3 to also fix this crash as @shubham1206agra is proposing? We could do a test and see if it fixed the issue for the Xiaomi 3 too.

mrousavy · 2023-10-05T09:53:14Z

Hey sorry just saw this now - I just submitted a (still wip) PR here: #28901

Sorry I'm not too familiar with PRs yet I need to test more things and adapt to your workflow more, but in short it just upgrades the lib and uses the new devices API.

I'll test more, we have a completely rewritten codebase in V3 so there might or might not be new issues with some various devices - but now with the more stable foundation that'll be a breeze to fix 😅

cloudflare-workers-and-pages · 2023-10-05T11:56:26Z

Deploying with Cloudflare Pages

Latest commit:	`04e3eb1`
Status:	✅ Deploy successful!
Preview URL:	https://624dcac9.helpdot.pages.dev
Branch Preview URL:	https://andrew-scan-xiaomi.helpdot.pages.dev

View logs

mountiny · 2023-10-05T12:04:26Z

I think we can bump this one now to hopefully fix iphone 15 and then v3 once we get that sorted, bumped to latest version per https://expensify.slack.com/archives/C05LX9D6E07/p1696507107779239?thread_ts=1695995214.378979&cid=C05LX9D6E07

shubham1206agra · 2023-10-05T12:20:51Z

@mountiny Please update the VisionCamera version to 2.16.2 in Podfile.lock

situchan · 2023-10-05T13:36:01Z

v3 upgrade is being worked on #28914

shubham1206agra · 2023-10-05T13:37:12Z

I think we can bump this one now to hopefully fix iphone 15 and then v3 once we get that sorted, bumped to latest version per https://expensify.slack.com/archives/C05LX9D6E07/p1696507107779239?thread_ts=1695995214.378979&cid=C05LX9D6E07

@situchan See this

situchan · 2023-10-05T13:38:23Z

I think we can bump this one now to hopefully fix iphone 15 and then v3 once we get that sorted, bumped to latest version per https://expensify.slack.com/archives/C05LX9D6E07/p1696507107779239?thread_ts=1695995214.378979&cid=C05LX9D6E07

@situchan See this

yes I know that's why I alerted. cc: @mrousavy @MonilBhavsar

AndrewGable · 2023-10-05T16:29:09Z

Closing in favor of #28914

mrousavy · 2023-10-12T13:37:41Z

This works perfectly fine on my iPhone 15 Pro!

We can go with latest V2 containing my fixes for now, and upgrade to V3 next week :)
I'll continue to improve V3 in the meantime!

OSBotify · 2023-10-12T13:38:13Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/27820/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/27820/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/27820/NewExpensify.dmg	https://27820.pr-testing.expensify.com

melvin-bot · 2023-10-12T13:42:26Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-10-12T13:43:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

iPhone X

27820-mobile-ios.MP4

Android

27820-mobile-android.mp4

puneetlath · 2023-10-12T15:54:11Z

It works!

OSBotify · 2023-10-12T16:03:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:12:37Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:13:26Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:49:46Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:52:42Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:17:27Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Update react-native-vision-camera

179f9e0

AndrewGable requested a review from aldo-expensify September 20, 2023 04:03

AndrewGable self-assigned this Sep 20, 2023

AndrewGable requested a review from a team as a code owner September 20, 2023 04:03

melvin-bot bot requested review from ntdiary and removed request for a team September 20, 2023 04:03

AndrewGable added the Ready To Build label Sep 21, 2023

shubham1206agra mentioned this pull request Oct 4, 2023

[HOLD for payment 2024-04-09] [$500] IOS - Request Money - Requesting money crashes on iPhone 15 #28341

Closed

6 tasks

Bump the react-native-vision-camera to 2.16.2

033d7fd

allroundexperts mentioned this pull request Oct 5, 2023

feat: Upgrade VisionCamera to V3 #28914

Closed

61 tasks

AndrewGable closed this Oct 5, 2023

mountiny reopened this Oct 12, 2023

Merge branch 'main' into andrew-scan-xiaomi

04e3eb1

ntdiary approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from nkuoch October 12, 2023 13:42

nkuoch approved these changes Oct 12, 2023

View reviewed changes

puneetlath approved these changes Oct 12, 2023

View reviewed changes

puneetlath merged commit 9b5f8c4 into main Oct 12, 2023
16 of 17 checks passed

puneetlath deleted the andrew-scan-xiaomi branch October 12, 2023 15:54

mountiny mentioned this pull request Oct 13, 2023

[NoQA] Updated podfile #29562

Merged

59 tasks

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot bot mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-23] #27691

Closed

6 tasks

Update react-native-vision-camera #27820

Update react-native-vision-camera #27820

Conversation

AndrewGable commented Sep 20, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2023

AndrewGable commented Sep 20, 2023

aldo-expensify commented Sep 20, 2023

AndrewGable commented Sep 20, 2023

aldo-expensify commented Sep 20, 2023

aldo-expensify commented Sep 20, 2023 • edited Loading

AndrewGable commented Sep 20, 2023

ntdiary commented Sep 20, 2023

aldo-expensify commented Sep 20, 2023 • edited Loading

ntdiary commented Sep 20, 2023

AndrewGable commented Sep 21, 2023

aldo-expensify commented Sep 21, 2023

aldo-expensify commented Sep 21, 2023

ntdiary commented Sep 26, 2023

AndrewGable commented Sep 27, 2023

shubham1206agra commented Oct 4, 2023

aldo-expensify commented Oct 5, 2023

mrousavy commented Oct 5, 2023

cloudflare-workers-and-pages bot commented Oct 5, 2023 • edited Loading

Deploying with Cloudflare Pages

mountiny commented Oct 5, 2023

shubham1206agra commented Oct 5, 2023

situchan commented Oct 5, 2023

shubham1206agra commented Oct 5, 2023

situchan commented Oct 5, 2023

AndrewGable commented Oct 5, 2023

mrousavy commented Oct 12, 2023

OSBotify commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

ntdiary commented Oct 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

puneetlath commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

Update `react-native-vision-camera` #27820

Update `react-native-vision-camera` #27820

aldo-expensify commented Sep 20, 2023 •

edited

Loading

aldo-expensify commented Sep 20, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 5, 2023 •

edited

Loading

ntdiary commented Oct 12, 2023 •

edited

Loading