-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat 22876 allow users to update the card address via update address link #28907
Merged
marcaaron
merged 64 commits into
Expensify:main
from
MrMuzyk:feat-22876-allow-users-to-update-the-card-address-via-update-address-link
Oct 16, 2023
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
3114d6b
feat: update address link
MrMuzyk d7c7289
add right icon press handler and accessibilityLabel to MenuItem
JKobrynski 8b12931
add translations for CardDetails
JKobrynski 9b263f2
create CardDetails component
JKobrynski cc5a296
format code
JKobrynski ab44a6f
remove unused prop type
JKobrynski 36c331b
improve comments grammar
JKobrynski 7b8fbf4
simplify accessibilityLabel
JKobrynski 34f5c7f
lint code
JKobrynski d626f6f
Fix translation of copy requested money action messages
rayane-djouah b5b03db
Copy email with text when iou message is copied
huzaifa-99 df153d1
Fix lint
huzaifa-99 1a9bdc5
Show payer name for paid iou/expense msg in LHN
huzaifa-99 0f075e8
upgrade to rn 0.72.4 + fix patches
fabOnReact c96e864
commit package-lock.json
fabOnReact 21df891
add back package.json over-rides
fabOnReact 5f80b41
commit Podfile.lock and package-lock.json
fabOnReact 6fb080b
add back material-top-tabs patch
fabOnReact 5e3ac2a
use attachmentmodal in reportActionItemImage
luacmartins 04faad8
Revert "use attachmentmodal in reportActionItemImage"
luacmartins 193b950
create route const, add onSubmit callback, navigate to correct route
luacmartins 614f6f7
stash work
Szymon20000 46c5060
remove console.logs
Szymon20000 0acb3d6
clean up
Szymon20000 fd7d76a
rename to waitForNetworkPromises and waitForBatchedUpdates
Szymon20000 d93bd89
add rightComponent support to MenuItem
JKobrynski 07d3aa4
add CardDetails to ExpensifyCardPage
JKobrynski 96ec68c
implement address editing functionality
JKobrynski d2d1330
remove redundant imports
JKobrynski cfafc00
apply minor fixes
JKobrynski 501c897
revert OptionsListUtils changes
JKobrynski 824ba47
revert ReportTest changes
JKobrynski accf327
revert APITest changes
JKobrynski 1ddd4a7
bring back react-native-image-manipulator patch
JKobrynski 566e598
bring back react-native-image-manipulator patch
JKobrynski 18f6ed2
bring back react-native-image-manipulator patch
JKobrynski 21f0d74
fix patch typo
JKobrynski 6280522
bring back react-native-sdk patch
JKobrynski 9299d97
bring back @react-navigation/native patch
JKobrynski a2c2b6a
Merge branch 'feature/expensify-card' of https://github.com/pasyukevi…
MrMuzyk 1eb3e9c
change useMemo to regular function
JKobrynski 16755eb
move formatPiece outside component definition
JKobrynski cada4ef
remove update address button
JKobrynski 4793d43
remove unnecessary style
JKobrynski 3fe5b96
feat: stash changes
MrMuzyk ecfaa73
Merge branch 'addRevealDetails' of https://github.com/JKobrynski/Expe…
MrMuzyk 1bffdb7
Merge remote-tracking branch 'eugene/feature/expensify-card' into add…
JKobrynski 6b54548
format address with reduce
JKobrynski 19d5d6c
remove formatPiece funciton
JKobrynski 357410a
remove pointerEvents style for pressable variants
JKobrynski d96baec
Merge branch 'addRevealDetails' of https://github.com/JKobrynski/Expe…
MrMuzyk 9aa4682
feat: connect with card page
MrMuzyk defdd1b
feat: remove test data
MrMuzyk 6ae0b78
Merge branch 'addRevealDetails' of https://github.com/JKobrynski/Expe…
MrMuzyk ae177fc
fix: remove doubled translations
MrMuzyk 0332f5f
fix: revert translation changes
MrMuzyk 665011a
fix: translations
MrMuzyk 8de2074
fix: config fix
MrMuzyk 678d070
Merge branch 'main' of github.com:MrMuzyk/App into feat-22876-allow-u…
MrMuzyk 2ba05ee
Merge branch 'addRevealDetails' of https://github.com/JKobrynski/Expe…
MrMuzyk c58c2f4
Merge branch 'main' of github.com:MrMuzyk/App into feat-22876-allow-u…
MrMuzyk 32978b7
fix: update key in personal details initial page
MrMuzyk 3616cb0
Merge branch 'main' of github.com:MrMuzyk/App into feat-22876-allow-u…
MrMuzyk 8004a76
fix: rename pages to be consistent
MrMuzyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, shouldn't the line below also be changed? I think you might forget changing that.
https://github.com/Expensify/App/blob/92813426a67df9b9a934d62dd9b1e4c41f5171a8/src/pages/settings/Wallet/ReportCardLostPage.js#L109C36-L109C63
cc @MrMuzyk, @narefyev91