feat 22876 allow users to update the card address via update address link #28907

MrMuzyk · 2023-10-05T11:45:13Z

Details

Added Update address link to allow users updating their card address

Fixed Issues

$ #22876
PROPOSAL:

Tests

Add mocked data in IntialSettingsPage.js

        window.Onyx.merge(`cardList`, {
            5678: {
                cardID: 5678,
                state: 3,
                bank: '1000',
                availableSpend: 10000,
                domainName: 'Expensify',
                lastFourPAN: '2345',
                isVirtual: false,
            },
        });

        Navigation.navigate(ROUTES.SETTINGS_WALLET_DOMAINCARDS.getRoute('expensify'));
    }, []);

follow QA steps
Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Settings/Wallet page (to load cards)
Go to Expensify Card page by navigating directly to /settings/wallet/card/expensify.com
Click on Reveal Details Button
Click on Update Address
Verify address is getting updated
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.chrome.mov

Mobile Web - Safari

ios.safari.mov

Desktop

desktop.mov

iOS

ios.native.mov

Android

android.native.mov

ds300/patch-package#455

This reverts commit 356f371.

MrMuzyk · 2023-10-09T07:08:31Z

@narefyev91

Just need to fix crash with translation

Is there something wrong with translations? I havent noticed

narefyev91 · 2023-10-09T07:47:03Z

@narefyev91

Just need to fix crash with translation
Is there something wrong with translations? I havent noticed

You changed translation key from 'homeAddress' to just 'address' - but you forgot to change it in one more place - which now cause a crash on that page #28907 (comment)

MrMuzyk · 2023-10-09T07:50:32Z

@narefyev91
Checklist is so long that I've missed that comment. Fixed!

marcaaron

code LGTM, but we have conflicts.

marcaaron · 2023-10-11T00:02:50Z

I don't think these QA steps as written are something that QA can do. I will update them for you and mark this as InternalQA

marcaaron

Found a small thing while testing.

marcaaron · 2023-10-11T00:08:53Z

src/ROUTES.ts

@@ -78,6 +78,10 @@ export default {
    SETTINGS_ADD_DEBIT_CARD: 'settings/wallet/add-debit-card',
    SETTINGS_ADD_BANK_ACCOUNT: 'settings/wallet/add-bank-account',
    SETTINGS_ENABLE_PAYMENTS: 'settings/wallet/enable-payments',
+    SETTINGS_WALLET_CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS: {
+        route: 'settings/wallet/cards/:domain/digital-details/update-address',


Actually I think it should be card and not cards. Maybe it would help to use the prefix here for consistency:

App/src/ROUTES.ts

Lines 74 to 75 in cb883e8

SETTINGS_WALLET_DOMAINCARDS: {

route: '/settings/wallet/card/:domain',

Good catch Marc, I agree. @MrMuzyk

Fixing that! There was a mistake in docs then for multiple pages

@marcaaron @grgia
looking at the codebase we actually have more cases of /cards than /card ATM. Should I change all of them to /card?

I'd go head and update them. Would be good to be consistent about this one.

marcaaron · 2023-10-11T00:11:01Z

Looks good and tests well - close to merge!

…sers-to-update-the-card-address-via-update-address-link

grgia

LGTM!

grgia · 2023-10-16T09:15:45Z

@marcaaron could you review/merge?

OSBotify · 2023-10-16T18:14:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:47:54Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

francoisl · 2023-10-17T18:54:31Z

I'm seeing a MISSING TRANSLATION on the digital-details/update-address page (step "Click on Update Address" of the QA), not sure if it's worth blocking the deploy on this?

OSBotify · 2023-10-17T23:12:39Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:58:48Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:56:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kosmydel · 2023-10-30T11:46:55Z

src/ROUTES.ts

@@ -71,22 +71,26 @@ export default {
    SETTINGS_ABOUT: 'settings/about',
    SETTINGS_APP_DOWNLOAD_LINKS: 'settings/about/app-download-links',
    SETTINGS_WALLET: 'settings/wallet',
-    SETTINGS_WALLET_DOMAINCARDS: {
+    SETTINGS_WALLET_DOMAINCARD: {


Hey, shouldn't the line below also be changed? I think you might forget changing that.

https://github.com/Expensify/App/blob/92813426a67df9b9a934d62dd9b1e4c41f5171a8/src/pages/settings/Wallet/ReportCardLostPage.js#L109C36-L109C63

cc @MrMuzyk, @narefyev91

MrMuzyk and others added 30 commits September 13, 2023 11:32

feat: update address link

3114d6b

add right icon press handler and accessibilityLabel to MenuItem

d7c7289

add translations for CardDetails

8b12931

create CardDetails component

9b263f2

format code

cc5a296

remove unused prop type

ab44a6f

improve comments grammar

36c331b

simplify accessibilityLabel

7b8fbf4

lint code

34f5c7f

Fix translation of copy requested money action messages

d626f6f

Copy email with text when iou message is copied

b5b03db

Fix lint

df153d1

Show payer name for paid iou/expense msg in LHN

1a9bdc5

upgrade to rn 0.72.4 + fix patches

0f075e8

commit package-lock.json

c96e864

add back package.json over-rides

21df891

ds300/patch-package#455

commit Podfile.lock and package-lock.json

5f80b41

add back material-top-tabs patch

6fb080b

use attachmentmodal in reportActionItemImage

5e3ac2a

Revert "use attachmentmodal in reportActionItemImage"

04faad8

This reverts commit 356f371.

create route const, add onSubmit callback, navigate to correct route

193b950

stash work

614f6f7

remove console.logs

46c5060

clean up

0acb3d6

rename to waitForNetworkPromises and waitForBatchedUpdates

fd7d76a

add rightComponent support to MenuItem

d93bd89

add CardDetails to ExpensifyCardPage

07d3aa4

implement address editing functionality

96ec68c

remove redundant imports

d2d1330

apply minor fixes

cfafc00

fix: update key in personal details initial page

32978b7

marcaaron assigned MrMuzyk Oct 10, 2023

marcaaron approved these changes Oct 10, 2023

View reviewed changes

marcaaron added the InternalQA This pull request required internal QA label Oct 11, 2023

marcaaron requested changes Oct 11, 2023

View reviewed changes

MrMuzyk added 2 commits October 12, 2023 08:54

Merge branch 'main' of github.com:MrMuzyk/App into feat-22876-allow-u…

3616cb0

…sers-to-update-the-card-address-via-update-address-link

fix: rename pages to be consistent

8004a76

MrMuzyk requested a review from marcaaron October 13, 2023 08:11

grgia approved these changes Oct 13, 2023

View reviewed changes

marcaaron approved these changes Oct 16, 2023

View reviewed changes

marcaaron merged commit e3cbbe5 into Expensify:main Oct 16, 2023
14 checks passed

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

mountiny mentioned this pull request Oct 17, 2023

[WAITING ON CHECKLIST] [$1000] Web - missing translations on additional details page in wallet enablement flow #29712

Closed

melvin-bot bot mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-24] [ECard Settings] - Allow users to update the card address via “Update address” link #22876

Closed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

kosmydel reviewed Oct 30, 2023

View reviewed changes

This was referenced Oct 30, 2023

Migrate animations to app assets and .lottie files #29975

Merged

Upgrade lottie-react-native to 6.4.0 #30772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat 22876 allow users to update the card address via update address link #28907

feat 22876 allow users to update the card address via update address link #28907

MrMuzyk commented Oct 5, 2023 •

edited by marcaaron

Loading

MrMuzyk commented Oct 9, 2023 •

edited

Loading

narefyev91 commented Oct 9, 2023

MrMuzyk commented Oct 9, 2023

marcaaron left a comment

marcaaron commented Oct 11, 2023

marcaaron left a comment

marcaaron Oct 11, 2023

grgia Oct 11, 2023

MrMuzyk Oct 12, 2023 •

edited

Loading

MrMuzyk Oct 12, 2023 •

edited

Loading

marcaaron Oct 12, 2023

marcaaron commented Oct 11, 2023

grgia left a comment

grgia commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

francoisl commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

kosmydel Oct 30, 2023

	SETTINGS_WALLET_DOMAINCARDS: {
	route: '/settings/wallet/card/:domain',

feat 22876 allow users to update the card address via update address link #28907

feat 22876 allow users to update the card address via update address link #28907

Conversation

MrMuzyk commented Oct 5, 2023 • edited by marcaaron Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MrMuzyk commented Oct 9, 2023 • edited Loading

narefyev91 commented Oct 9, 2023

MrMuzyk commented Oct 9, 2023

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron commented Oct 11, 2023

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Oct 11, 2023

Choose a reason for hiding this comment

grgia Oct 11, 2023

Choose a reason for hiding this comment

MrMuzyk Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

MrMuzyk Oct 12, 2023 • edited Loading

Choose a reason for hiding this comment

marcaaron Oct 12, 2023

Choose a reason for hiding this comment

marcaaron commented Oct 11, 2023

grgia left a comment

Choose a reason for hiding this comment

grgia commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

francoisl commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

kosmydel Oct 30, 2023

Choose a reason for hiding this comment

MrMuzyk commented Oct 5, 2023 •

edited by marcaaron

Loading

MrMuzyk commented Oct 9, 2023 •

edited

Loading

MrMuzyk Oct 12, 2023 •

edited

Loading

MrMuzyk Oct 12, 2023 •

edited

Loading