Fix/27165: Only display recent destination if search input is empty #28124

DylanDylann · 2023-09-25T10:06:22Z

Details

New design:

When the search input is focused and blank, only show the recents list.
When you start typing an address the recents list goes away as we show a list of auto-completed addresses based on your search input
When the search results return no valid addresses, only show "no results found"

Fixed Issues

$ #27165
PROPOSAL: #27165 (comment)

Tests

Go to Request Money --> Distance Request
Click on the Start point
Verify that when the search input is focused and blank, only show the recents list.
Verify that when you start typing an address the recents list goes away as we show a list of auto-completed addresses based on your search input
Verify that When the search results return no valid addresses, only show "no results found"

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Request Money --> Distance Request
Click on the Start point
Verify that when the search input is focused and blank, only show the recents list.
Verify that when you start typing an address the recents list goes away as we show a list of auto-completed addresses based on your search input
Verify that When the search results return no valid addresses, only show "no results found"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen-Recording-2023-09-26-at-12.57.49.mp4

Mobile Web - Chrome

Screen-Recording-2023-09-26-at-13.00.25.mp4

Mobile Web - Safari

Screen-Recording-2023-09-26-at-13.04.02.mp4

Desktop

Screen-Recording-2023-09-26-at-13.17.51.mp4

iOS

Screen.Recording.2023-09-27.at.11.51.46.mov

Android

Screen.Recording.2023-09-27.at.18.17.44.mov

melvin-bot · 2023-09-25T10:06:26Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-09-26T06:40:18Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2023-09-27T05:26:48Z

@burczu Could you help to review the PR on fork lib and then review this PR ?

burczu · 2023-09-27T07:01:40Z

@DylanDylann Yes - I'll review it today.

burczu · 2023-09-27T09:55:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

28124-web.mov

Mobile Web - Chrome

28124-web-chrome.mov

Mobile Web - Safari

28124-web-safari.mov

Desktop

28124-desktop.mov

iOS

28124-ios.mov

Android

28124-android.mov

burczu · 2023-09-27T10:01:56Z

@DylanDylann I think it does not work correctly... At first, it shows recent searches and thats ok, then when I start typing some incorrect address, the recents list still persists - please check the video below:

Screen.Recording.2023-09-27.at.11.58.51.mov

DylanDylann · 2023-09-27T10:07:49Z

@burczu Do you apply change in this fork lib

burczu · 2023-09-27T10:10:01Z

No - I didn't know I need to. And I think we need to wait until the other branch is merged and deployed... We can't merge this one without the other one.

DylanDylann · 2023-09-27T10:13:30Z

@burczu You can apply these change in here to node-module of App repository to test first. And then we should review/merge Expensify/react-native-google-places-autocomplete#8 after that we can update version of react-native-google-places-autocomplete in App repo to everything work well

DylanDylann · 2023-09-27T10:14:40Z

We can't merge this one without the other one.

It seems only internal engineer can merge PRs

burczu · 2023-09-27T10:17:06Z

Yes, I know I can test it this way - but still, first the other PR needs to be merged and here we need to add the update in the package.json with the version updated - then I can approve this PR as working. Also for changes in libraries you need to ask internal engineer to review I guess.

DylanDylann · 2023-09-27T10:17:13Z

@burczu This bug you got here because the logic in react-native-google-places-autocomplete lib, we always display predefined places even though no result found. So I raised a PR on that lib to fix this case

DylanDylann · 2023-09-27T10:19:17Z

@burczu I see in other issues that C+ needs to approve before requesting a review from an internal engineer in all repos of Expensify

burczu · 2023-09-27T10:20:10Z

@DylanDylann Ok, I can review the PR in the library first.

DylanDylann · 2023-09-28T10:37:01Z

@burczu Bump, I updated version of react-native-google-places-autocomplete. Could you help to review this PR?

burczu

LGTM

DylanDylann · 2023-10-02T04:38:36Z

@youssef-lr Bump, Please help to review this PR

youssef-lr

LGTM!

OSBotify · 2023-10-02T04:55:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:46:58Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:47:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:12:18Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:19:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

neil-marcellini · 2023-10-05T17:21:17Z

src/pages/iou/WaypointEditor.js

@@ -250,7 +250,6 @@ function WaypointEditor({route: {params: {iouType = '', transactionID = '', wayp
                                state: null,
                            }}
                            predefinedPlaces={recentWaypoints}
-                            resultTypes=""


Why was this removed? This is important since it allows us to get suggested addresses by the name of a place, business, etc. I created a bug for this regression. @DylanDylann @burczu @youssef-lr

add recent destination

de1db7c

DylanDylann changed the title ~~add recent destination~~ Fix/27165: Only display recent destination if search input is empty Sep 26, 2023

update translation

bffd572

DylanDylann marked this pull request as ready for review September 26, 2023 06:40

DylanDylann requested a review from a team as a code owner September 26, 2023 06:40

melvin-bot bot removed the request for review from a team September 26, 2023 06:40

melvin-bot bot requested a review from burczu September 26, 2023 06:40

DylanDylann mentioned this pull request Sep 26, 2023

[HOLD for payment 2023-10-10] [$500] [Distance] - The system does not display "No result found" when entering an invalid address. #27165

Closed

6 tasks

DylanDylann added 2 commits September 28, 2023 17:28

merge main

2fde1f8

update version react-native-google-places-autocomplete

b12711c

burczu approved these changes Sep 28, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr September 28, 2023 11:50

youssef-lr approved these changes Oct 2, 2023

View reviewed changes

youssef-lr merged commit db48d05 into Expensify:main Oct 2, 2023
13 checks passed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

lanitochka17 mentioned this pull request Oct 3, 2023

[$250] Distance IOU - 'Recent destination' disappears first then the list in the address field #28719

Closed

6 tasks

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

neil-marcellini mentioned this pull request Oct 5, 2023

[HOLD for payment 2023-10-16] [distance] suggested addresses don't appear for place names #28936

Closed

6 tasks

neil-marcellini reviewed Oct 5, 2023

View reviewed changes

neil-marcellini mentioned this pull request Oct 5, 2023

Fix show waypoint address suggestions of all types #28938

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/27165: Only display recent destination if search input is empty #28124

Fix/27165: Only display recent destination if search input is empty #28124

DylanDylann commented Sep 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 26, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

burczu commented Sep 27, 2023 •

edited

Loading

burczu commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023 •

edited

Loading

DylanDylann commented Sep 27, 2023 •

edited

Loading

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

DylanDylann commented Sep 28, 2023

burczu left a comment

DylanDylann commented Oct 2, 2023

youssef-lr left a comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

neil-marcellini Oct 5, 2023

Fix/27165: Only display recent destination if search input is empty #28124

Fix/27165: Only display recent destination if search input is empty #28124

Conversation

DylanDylann commented Sep 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 26, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

burczu commented Sep 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023 • edited Loading

DylanDylann commented Sep 27, 2023 • edited Loading

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

DylanDylann commented Sep 27, 2023

burczu commented Sep 27, 2023

DylanDylann commented Sep 28, 2023

burczu left a comment

Choose a reason for hiding this comment

DylanDylann commented Oct 2, 2023

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

neil-marcellini Oct 5, 2023

Choose a reason for hiding this comment

DylanDylann commented Sep 25, 2023 •

edited

Loading

burczu commented Sep 27, 2023 •

edited

Loading

burczu commented Sep 27, 2023 •

edited

Loading

DylanDylann commented Sep 27, 2023 •

edited

Loading