[HOLD for payment 2023-10-16] [distance] suggested addresses don't appear for place names

[neil-marcellini]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click the green plus, Request money
2. Select the distance tab
3. Click start
4. Type "Expensify lounge SF"

Expected Result:

The address for the Expensify lounge in SF should show up as a suggestion

Actual Result:

No results are found

Workaround:

Look up the address in another map application, which is bad because the user leaves our app.

Platforms:

Which of our officially supported platforms is this issue occurring on?
All, based on the code

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-10-05.at.10.11.46.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696525943231939

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[neil-marcellini]

I implemented this originally and the regression was introduced in this commit of this PR #28124. I will put up a quick fix because it's a one line change.

[neil-marcellini]

@abekkala please remind me to create propose a regression test for this

[abekkala]

Reminder for self: remind @neil-marcellini 😂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix show waypoint address suggestions of all types #28938

If no regressions arise, payment will be issued on 2023-10-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@neil-marcellini] The PR that introduced the bug has been identified. Link to the PR: Fix/27165: Only display recent destination if search input is empty #28124
• [@neil-marcellini] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix/27165: Only display recent destination if search input is empty #28124 (comment)
• [@neil-marcellini] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A we decided to add a regression test for this
• [@neil-marcellini] Determine if we should create a regression test for this bug. Yes.
• [@neil-marcellini] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[neil-marcellini]

Regression Test Proposal

1. Click the green plus, Request money
2. Select the distance tab
3. Click start
4. Type "Expensify lounge SF"
5. Verify that a suggestion for the Expensify lounge in SF shows up below the input
6. Select it
7. Verify that you are navigated back to the distance request page and the address is filled in for the start waypoint

• Do we agree 👍 or 👎

[neil-marcellini]

Looks like Melvin did a good job reminding me. All you now @abekkala 😄

[abekkala]

@neil-marcellini can I confirm that Tim Golen did your review and this particular one does not require a payment to anyone?

I can create the Regression Test GH for Applause given your steps above.

[abekkala]

@neil-marcellini can you confirm above?

[abekkala]

From what I can tell we didn't have an external contributor involved in this.
Closing.

If I have that wrong and someone needs payment reopen please