Fix an error message is in English in Spanish account when validate 2nd contact #22100

hoangzinh · 2023-07-03T11:35:01Z

Details

Fixed Issues

$ #21001
PROPOSAL: #21001 (comment)

Tests

Login with any account
Go to Settings -> Preferences -> Language -> Change language to English
Go to Profile -> Contact method -> Open any unvalidated contact method
Fill-in incorrect magic codes
Verify that it shows invalid magic codes error in English
Go to Settings -> Preferences -> Language -> Change language to Spanish
Go to Profile -> Contact method -> Open previous unvalidated contact method in step 3
Verify that it shows invalid magic code error in Spanish

Verify that no errors appear in the JS console

Offline tests

Could not test when network is not available

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-03.at.18.36.39.-.web.mp4

Mobile Web - Chrome

Screen.Recording.2023-07-03.at.18.46.23.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-07-03.at.18.49.23.-.ios.safari.mov

Desktop

Screen.Recording.2023-07-03.at.18.39.12.-.desktop.mov

iOS

Screen.Recording.2023-07-03.at.18.48.18.-.ios.mov

Android

Screen.Recording.2023-07-03.at.18.44.53.-.android.mov

melvin-bot · 2023-07-03T11:54:35Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mollfpr · 2023-07-05T15:51:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

22100.Web.mov

Mobile Web - Chrome

22100.mWeb.Chrome.webm

Mobile Web - Safari

22100.mWeb.Safari.mp4

Desktop

22100.Desktop.mov

iOS

22100.iOS.mp4

Android

22100.Android.webm

mollfpr

LGTM and tests well!

Just small fix regarding the JSDoc.

mollfpr · 2023-07-05T16:19:49Z

src/libs/ErrorUtils.js

@@ -88,6 +88,27 @@ function getLatestErrorField(onyxData, fieldName) {
        .value();
 }

+/**
+ * Get the first error in the errorFields ordering by its key


We don't need the comment because the function name already explains what it is.

mollfpr · 2023-07-05T16:21:05Z

src/libs/ErrorUtils.js

+/**
+ * Get the first error in the errorFields ordering by its key
+ *
+ * @param {Object} onyxData


Document object parameters with separate lines e.g. @param {Object} parameters followed by @param {String} parameters.field.

It is missing the field errorFields. Pretty much similar to the JSDoc on getLatestErrorField.

I just updated the above feedbacks. Please help me review this PR again. Thanks

mollfpr

LGTM and tests well 👍

Beamanator

Code looking great, but one refactor question

src/libs/ErrorUtils.js

Beamanator

LGTM

OSBotify · 2023-07-06T10:40:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-07T10:45:06Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-11T00:00:08Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Get first error object to show in validate code form

2adcdcb

hoangzinh marked this pull request as ready for review July 3, 2023 11:54

hoangzinh requested a review from a team as a code owner July 3, 2023 11:54

melvin-bot bot requested review from mollfpr and removed request for a team July 3, 2023 11:54

hoangzinh mentioned this pull request Jul 3, 2023

[HOLD for payment 2023-07-17] [$1000] Contact method - An error message is in English in Spanish account #21001

Closed

6 tasks

mollfpr suggested changes Jul 5, 2023

View reviewed changes

Update JSDoc

cc29b60

mollfpr approved these changes Jul 5, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator July 5, 2023 19:50

Beamanator reviewed Jul 6, 2023

View reviewed changes

src/libs/ErrorUtils.js Outdated Show resolved Hide resolved

Rename method as feedback

910780c

Beamanator approved these changes Jul 6, 2023

View reviewed changes

Beamanator merged commit 197cf7d into Expensify:main Jul 6, 2023

OSBotify mentioned this pull request Jul 7, 2023

Deploy Checklist: New Expensify 2023-07-07 #22399

Closed

64 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix an error message is in English in Spanish account when validate 2nd contact #22100

Fix an error message is in English in Spanish account when validate 2nd contact #22100

hoangzinh commented Jul 3, 2023 •

edited

Loading

melvin-bot bot commented Jul 3, 2023

mollfpr commented Jul 5, 2023 •

edited

Loading

mollfpr left a comment

mollfpr Jul 5, 2023

mollfpr Jul 5, 2023

hoangzinh Jul 5, 2023

mollfpr left a comment

Beamanator left a comment

Beamanator left a comment

OSBotify commented Jul 6, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

Fix an error message is in English in Spanish account when validate 2nd contact #22100

Fix an error message is in English in Spanish account when validate 2nd contact #22100

Conversation

hoangzinh commented Jul 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 3, 2023

mollfpr commented Jul 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Jul 5, 2023

Choose a reason for hiding this comment

mollfpr Jul 5, 2023

Choose a reason for hiding this comment

hoangzinh Jul 5, 2023

Choose a reason for hiding this comment

mollfpr left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 6, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

hoangzinh commented Jul 3, 2023 •

edited

Loading

mollfpr commented Jul 5, 2023 •

edited

Loading