[HOLD for payment 2023-07-17] [$1000] Contact method - An error message is in English in Spanish account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Preferences -> Language -> Change language to Spanish
4. Go to Profile -> Contact method -> Open any unvalidated contact method
5. Write a wrong magic code

Expected Result:

An error message is in Spanish

Actual Result:

An error message is in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0160ca5817cf9d9f89
• Upwork Job ID: 1671872446268678144
• Last Price Increase: 2023-06-29

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact method - An error message is in English in Spanish account

What is the root cause of that problem?

While validating secondary contact methods, we're displaying the error from server, but the server's returning message instead of phrase key, that's why even we changed the language, the error is still in English.

What changes do you think we should make in order to solve the problem?

From Frontend: Add translations key for the error from server, for example in this issue, we should add translation for invalid magic code.
From backend: Return error with the key phrase instead of english text.

What alternative solutions did you explore? (Optional)

N/A

[muttmuure]

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0160ca5817cf9d9f89

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[muttmuure]

@hungvu193's proposal looks like a good start @mollfpr

[mollfpr]

I think it's not worth using BE changes here. We already have the phrase for validating error contacts.genericFailureMessages.validateSecondaryLogin, but it displays the error message from the server instead.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact method - An error message is in English in Spanish account

What is the root cause of that problem?

• When we're failed to validate secondary login, we get current timestamp before sending API, and set a translation phrase key to the errorFields:
  

  App/src/libs/actions/User.js

  Lines 450 to 452 in b528d3a

  	errorFields: {
  	validateLogin: ErrorUtils.getMicroSecondOnyxError('contacts.genericFailureMessages.validateSecondaryLogin'),
  	},

But BE also returns an error message too with timestamp at the time that BE validate magic code. That means error message of BE always has the timestamp greater than the timestamp of FE failureData

For example:

• Thus, when we select error message to show in the Form, we select latest error message which is the BE error in this case
  

  App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

  Line 168 in b528d3a

  errors={ErrorUtils.getLatestErrorField(loginData, 'validateLogin')}

What changes do you think we should make in order to solve the problem?

I think we should select the first error message to show in this case. Because every time we call API to validate secondary login, we already cleared the errorFields and we have set an error message in the failureData in FE side so it makes sense if we should use it instead of BE error messages which usually contains either technical errors or English error messages.

In order to do it, we can make another function getFirstErrorField same as getLatestErrorField here, but it will get first. Then we use it to show in the Secondary login validation form here

Screenshot results

[mollfpr]

I agree with you @hoangzinh as I thought we could reuse the current phrase that we have.

Let's game on! The #21001 (comment) from @hoangzinh looks good to me 🚀

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account 🎉

Reviewer - [$1000] Contact method - An error message is in English in Spanish account

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account 🎉

Contributor - [$1000] Contact method - An error message is in English in Spanish account Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Beamanator]

Sorry for the delay, i was ooo last friday!

[hoangzinh]

Melvin, The PR will be ready for review within couple of hours. Btw, I haven't received the offer on Upwork yet

[hoangzinh]

@mollfpr @Beamanator PR is ready #22100. Please help me review it. Thanks ❤️

[melvin-bot]

@Beamanator, @hoangzinh, @mollfpr, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix an error message is in English in Spanish account when validate 2nd contact #22100

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/301211

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I can't make sure this, this might be related to an update in the BE.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression test should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Login with any account
2. Go to Settings -> Preferences -> Language -> Change language to English
3. Go to Profile -> Contact method -> Open any unvalidated contact method
4. Fill-in incorrect magic codes
5. Verify that it shows an invalid magic codes error in English
6. Go to Settings -> Preferences -> Language -> Change language to Spanish
7. Go to Profile -> Contact method -> Open previous unvalidated contact method in step 3
8. Verify that it shows an invalid magic code error in Spanish
9. 👍 or 👎

[mollfpr]

Posting the calculation since Melvin forget about it

The issue assignment is on Jul 3, 2023, 6:52 PM GMT+8.

PR merged is on Jul 6, 2023, 6:35 PM GMT+8.

So, July 6, 2023, 6:35 PM GMT+8 is approximately 2.958 days after July 3, 2023, 6:52 PM GMT+8, which is nearly 3 days later.

This is still eligible for the bonus.

[muttmuure]

Everybody got paid