feat: use `accountID` instead of email in `WithCurrentUserPersonalDetails` #20034

BeeMargarida · 2023-06-02T07:54:25Z

Details

A part of the 'Secure Logins' issue, point 4. This PR changes the WithCurrentUserPersonalDetails hook to use accountID instead of email.

An additional change was made in getPersonalDetailsByIDs, which is only used in 2 places, only 1 that passes the field currentUserAccountID. This field was supposed to be a number and then was converted to string. With the current changes in WithCurrentUserPersonalDetails, it will now always be a string, so the conversion is not necessary.

There are several ways of testing this, since it used throughout the app.

Fixed Issues

$ #19007
#19007 (comment)

Tests

Open a chat with a message that has several reactions of other users
Add the same reaction as other users
Hover over the reaction
Check that the tooltip contains the name of the users that reacted and 'You'.
Left click on the reaction to see the list of people that reacted, the information should be correct
Go to Settings -> Profile
Check that the data is correct

Verify that no errors appear in the JS console

Offline tests

Behaviour should not change.

QA Steps

Open a chat with a message that has several reactions of other users
Add the same reaction as other users
Hover over the reaction
Check that the tooltip contains the name of the users that reacted and 'You'.
Left click on the reaction to see the list of people that reacted, the information should be correct
Go to Settings -> Profile
Check that the data is correct

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

current_user_ios.mov

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

fabioh8010 · 2023-06-02T08:06:29Z

src/ONYXKEYS.js

@@ -45,6 +45,9 @@ export default {
    // Contains all the personalDetails the user has access to
    PERSONAL_DETAILS: 'personalDetails',

+    // Contains all the personalDetails the user has access to [new version]
+    PERSONAL_DETAILS_LIST: 'personalDetailsList',


Context: #19007 (comment)

melvin-bot · 2023-06-02T08:18:00Z

@Beamanator @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/PersonalDetailsUtils.js

BeeMargarida · 2023-06-02T08:58:27Z

Updated!

src/components/withCurrentUserPersonalDetails.js

Beamanator

Looks great!! One super tiny comment but I think we can 👍

src/ONYXKEYS.js

Beamanator

Awesome, thanks @BeeMargarida !

0xmiros · 2023-06-02T16:43:41Z

Code looks good. Testing now

0xmiros · 2023-06-02T17:46:24Z

Please add one more test case affected by this change:

0xmiros · 2023-06-05T07:58:32Z

@BeeMargarida please check #20034 (comment).

Also:

Go to Settings -> Profile -> Personal Details

Check that the data is correct

Step 5 is not correct. Personal Details page is using different onyx data (private_personalDetails), neither personalDetailsList nor personalDetails.
It should be corrected to:

Go to Settings -> Profile

BeeMargarida · 2023-06-05T08:09:21Z

@0xmiroslav Updated the PR description with the fixes you mentioned, thank you!

0xmiros · 2023-06-05T08:57:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiros

LGTM!

Beamanator · 2023-06-05T15:06:26Z

@BeeMargarida mind fixing the conflict? 🙏

…ersonal_details

BeeMargarida · 2023-06-05T15:09:23Z

mind fixing the conflict? 🙏

@Beamanator Done! 👍

OSBotify · 2023-06-05T15:22:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-05T19:24:56Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2023-06-05T23:11:54Z

Created PR to revert this here

OSBotify · 2023-06-07T03:28:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-07T13:20:25Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.24-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

feat: use accountID instead of email in WithCurrentUserPersonalDetails

70df92a

fabioh8010 reviewed Jun 2, 2023

View reviewed changes

BeeMargarida marked this pull request as ready for review June 2, 2023 08:17

BeeMargarida requested a review from a team as a code owner June 2, 2023 08:17

melvin-bot bot requested review from 0xmiros and Beamanator and removed request for a team June 2, 2023 08:17

0xmiros reviewed Jun 2, 2023

View reviewed changes

src/libs/PersonalDetailsUtils.js Outdated Show resolved Hide resolved

fix: doc types

7f593e9

feat: update to PERSONAL_DETAILS_LIST in personal details utils

ca8a629

puneetlath reviewed Jun 2, 2023

View reviewed changes

src/components/withCurrentUserPersonalDetails.js Show resolved Hide resolved

puneetlath previously approved these changes Jun 2, 2023

View reviewed changes

Beamanator previously approved these changes Jun 2, 2023

View reviewed changes

src/ONYXKEYS.js Outdated Show resolved Hide resolved

fix: small fix in key comment

d98451d

BeeMargarida dismissed stale reviews from Beamanator and puneetlath via d98451d June 2, 2023 15:00

Beamanator approved these changes Jun 2, 2023

View reviewed changes

puneetlath approved these changes Jun 2, 2023

View reviewed changes

0xmiros approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'main' into feat/19007-secure_logins_with_current_user_p…

5502554

…ersonal_details

Beamanator merged commit 24d622e into Expensify:main Jun 5, 2023

OSBotify mentioned this pull request Jun 5, 2023

Deploy Checklist: New Expensify 2023-06-05 #20195

Closed

51 tasks

This was referenced Jun 5, 2023

[HOLD for payment 2023-06-13] Profile - Timezone toggle is not working when going offline #20209

Closed

Revert PERSONAL_DETAILS_LIST Onyx changes #20220

Merged

kbecciv mentioned this pull request Jun 6, 2023

[HOLD for payment 2023-06-28] [$1000] Chat - Email address is displayed instead of 'You' when pulling up the reaction detail #20267

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 6, 2023

[HOLD for payment 2023-06-28] [Secure Logins] Replace login uses with accountIDs throughout App (when accessing Onyx) #19007

Closed

Beamanator mentioned this pull request Jun 6, 2023

Start personalDetails migration to *List #20323

Merged

57 tasks

s-alves10 mentioned this pull request Jun 7, 2023

Fix cutoff emojis inside code blocks #20287

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use `accountID` instead of email in `WithCurrentUserPersonalDetails` #20034

feat: use `accountID` instead of email in `WithCurrentUserPersonalDetails` #20034

BeeMargarida commented Jun 2, 2023 •

edited

Loading

fabioh8010 Jun 2, 2023

melvin-bot bot commented Jun 2, 2023

BeeMargarida commented Jun 2, 2023

Beamanator left a comment

Beamanator left a comment

0xmiros commented Jun 2, 2023

0xmiros commented Jun 2, 2023

0xmiros commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

0xmiros commented Jun 5, 2023

0xmiros left a comment

Beamanator commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

roryabraham commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

feat: use accountID instead of email in WithCurrentUserPersonalDetails #20034

feat: use accountID instead of email in WithCurrentUserPersonalDetails #20034

Conversation

BeeMargarida commented Jun 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fabioh8010 Jun 2, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Jun 2, 2023

BeeMargarida commented Jun 2, 2023

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

0xmiros commented Jun 2, 2023

0xmiros commented Jun 2, 2023

0xmiros commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

0xmiros commented Jun 5, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

Beamanator commented Jun 5, 2023

BeeMargarida commented Jun 5, 2023

OSBotify commented Jun 5, 2023

OSBotify commented Jun 5, 2023

roryabraham commented Jun 5, 2023

OSBotify commented Jun 7, 2023

OSBotify commented Jun 7, 2023

feat: use `accountID` instead of email in `WithCurrentUserPersonalDetails` #20034

feat: use `accountID` instead of email in `WithCurrentUserPersonalDetails` #20034

BeeMargarida commented Jun 2, 2023 •

edited

Loading