[HOLD for payment 2023-06-13] Profile - Timezone toggle is not working when going offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open Staging New Dot App
2. Tap on Profile image
3. Tap on Profile
4. Tap on Timezone

Expected Result:

Toggle button to detect timezone must work either in online or offline mode (With wifi or airplane mode).

Actual Result:

Toggle button does not work on offline mode (when airplane is activated).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6081476_az_recorder_20230605_144608.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

I suspect this may be caused by #20034, which changed the shape of Onyx data without creating a migration

[stitesExpensify]

What makes you think that? I'm not seeing console errors or anything

[fedirjh]

@roryabraham I think this will be fixed by #20035 , I tested locally and it seems working fine. It looks like this issue #19007 was divided into multiple PRs, and it appears that they should be merged together.

[roryabraham]

Ok, so this was definitely caused by #20034, which switched the data source for withCurrentUserPersonalDetails when it was not yet guaranteed that the data was going to be available in the new location.

A few options:

1. Revert feat: use accountID instead of email in WithCurrentUserPersonalDetails #20034, but that might have other side-effects since other features were updated to use the new Onyx data.
2. Finish feat: use accountID instead of email in AuthScreens logic #20035, but it seems it's not passing tests.
3. Create a new PR to update withCurrentUserPersonalDetails to get data from both sources, the old key and the new key, and fallback on data from the old key if data from the new key is not present. Then create a follow-up PR to remove that logic.

2 seems like the best option if we can pull it off.

[Beamanator]

I think the only tests not passing are the Reviewer Checklist, right? So 2 seems solid to me

[roryabraham]

Another option could be to revert all three PRs that affect the currentUserPersonalDetails:

• feat: use accountID instead of email in WithCurrentUserPersonalDetails #20034
• feat: use accountID in App.js #20036
• feat: use accountID in DateUtils #20037

Maybe that's the best course of action so we're not introducing a big new change while QA is ongoing.

[roryabraham]

Got consensus in slack to move forward with the revert PR: https://expensify.slack.com/archives/C03TQ48KC/p1686004751513199

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

Verified that this is no longer reproducible

[Beamanator]

Looks like this was fixed by the revert 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert PERSONAL_DETAILS_LIST Onyx changes #20220

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty