Updated storybook to use new theme #17700

alitoshmatov · 2023-04-20T06:14:23Z

Details

This pr contains changes to update story book ui with new expensify theme

Fixed Issues

$ #16752
PROPOSAL: #16752 (comment)

Tests

Go to storybook page
Check if colors matching New expensify color scheme
Check if favicon is changed to new expensify logo
Check logomark in sidebar is from New expensify

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to storybook page
Check if colors matching New expensify color scheme
Check if favicon is changed to new expensify logo
Check logomark in sidebar is from New expensify

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

N/A

iOS

N/A

Android

N/A

MelvinBot · 2023-04-20T06:14:32Z

@roryabraham @fedirjh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-04-20T06:14:41Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

alitoshmatov · 2023-04-20T06:16:04Z

I have read the CLA Document and I hereby sign the CLA

fedirjh

Looks good

fedirjh · 2023-04-20T17:27:44Z

.storybook/theme.js

+    appContentBg: colors.greenAppBackground,
+    textColor: colors.white,
+    barTextColor: colors.white,
+    barSelectedColor: colors.blueLink,


Suggested change

barSelectedColor: colors.blueLink,

barSelectedColor: colors.green,

This should match colorSecondary

fedirjh · 2023-04-20T17:29:59Z

.storybook/theme.js

    fontBase: 'ExpensifyNeue-Regular',
    fontCode: 'monospace',
-    textInverseColor: colors.black,
+    appBg: colors.greenAppBackground,


Suggested change

appBg: colors.greenAppBackground,

appBg: colors.greenHighlightBackground,

fedirjh · 2023-04-20T17:34:37Z

.storybook/theme.js

+    textColor: colors.white,
+    barTextColor: colors.white,
+    barSelectedColor: colors.blueLink,
+    barBg: colors.greenHighlightBackground,


Suggested change

barBg: colors.greenHighlightBackground,

barBg: colors.greenAppBackground,

fedirjh · 2023-04-20T17:48:08Z

cc @shawnborton , do have any feedback ?

alitoshmatov · 2023-04-20T17:54:41Z

@fedirjh Applied your suggestions
After:

fedirjh · 2023-04-20T17:56:35Z

@alitoshmatov Could you please fix this :

Screen.Recording.2023-04-20.at.6.53.28.PM.mov

alitoshmatov · 2023-04-20T18:11:54Z

@fedirjh Updated, forgot to set dark mode. Styling dropdown is very limited and only texts could be styled. That is why black-ish background is here

fedirjh · 2023-04-20T18:51:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

shawnborton · 2023-04-20T18:53:56Z

Looking pretty good!

Rather than using green for the selected row color, can we mirror what we do in the left hand nav and use the same shade of green here?

alitoshmatov · 2023-04-20T19:15:55Z

@shawnborton updated selected row color in sidebar

shawnborton · 2023-04-20T19:29:17Z

Awesome, thanks!

fedirjh · 2023-04-20T19:39:57Z

Suggestion : maybe we can adjust the border-radius here . It can be achieved with appBorderRadius: 8,

Actual 4px	8px

shawnborton · 2023-04-20T19:44:09Z

That sounds good to me

alitoshmatov · 2023-04-20T19:51:16Z

Updated border radius in app and input fields to 8px

fedirjh

Looking pretty neat!

@roryabraham, over to you.

🎀👀🎀 C+ reviewed

fedirjh · 2023-04-24T22:34:53Z

Little bump @roryabraham

roryabraham · 2023-04-25T17:07:44Z

.storybook/theme.js

-    barSelectedColor: colors.blue,
-    base: 'light',
-    brandTitle: 'Expensify UI Docs',
+    brandTitle: 'New Expensify UI Docs',


NAB Would be nice to alphabetize this

roryabraham

Overall this code looks fine and tests well though, so I'm not going to delay merging on alphabetization of the style object.

OSBotify · 2023-04-25T17:29:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-26T06:34:31Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-27T04:49:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov added 2 commits April 20, 2023 10:03

Changed favicon logo, logomark, and colors

b583832

Removed textInverseColor to fix snackbar

9b3a08d

alitoshmatov requested a review from a team as a code owner April 20, 2023 06:14

melvin-bot bot requested review from fedirjh and roryabraham and removed request for a team April 20, 2023 06:14

alitoshmatov mentioned this pull request Apr 20, 2023

[PAID] [$1000] Storybook page Expensify branding is not updated #16752

Closed

6 tasks

fedirjh reviewed Apr 20, 2023

View reviewed changes

Applied suggestions by @fedirjh

dbbddd2

Fixed dark mode

c0756c9

Updated sidebar selected row color, and font color

52e2d2f

Added border radius to app and input

4ad92c8

fedirjh approved these changes Apr 20, 2023

View reviewed changes

roryabraham reviewed Apr 25, 2023

View reviewed changes

roryabraham approved these changes Apr 25, 2023

View reviewed changes

roryabraham merged commit ef71ebd into Expensify:main Apr 25, 2023

OSBotify mentioned this pull request Apr 26, 2023

Deploy Checklist: New Expensify 2023-04-26 #18017

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated storybook to use new theme #17700

Updated storybook to use new theme #17700

alitoshmatov commented Apr 20, 2023 •

edited

Loading

MelvinBot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023 •

edited

Loading

alitoshmatov commented Apr 20, 2023

fedirjh left a comment

fedirjh Apr 20, 2023

fedirjh Apr 20, 2023

fedirjh Apr 20, 2023

fedirjh Apr 20, 2023

fedirjh commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

fedirjh commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

fedirjh commented Apr 20, 2023 •

edited

Loading

shawnborton commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

shawnborton commented Apr 20, 2023

fedirjh commented Apr 20, 2023 •

edited

Loading

shawnborton commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023 •

edited

Loading

fedirjh left a comment

fedirjh commented Apr 24, 2023

roryabraham Apr 25, 2023

roryabraham left a comment

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

	barSelectedColor: colors.blueLink,
	barSelectedColor: colors.green,

	appBg: colors.greenAppBackground,
	appBg: colors.greenHighlightBackground,

	barBg: colors.greenHighlightBackground,
	barBg: colors.greenAppBackground,

Updated storybook to use new theme #17700

Updated storybook to use new theme #17700

Conversation

alitoshmatov commented Apr 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 20, 2023

github-actions bot commented Apr 20, 2023 • edited Loading

alitoshmatov commented Apr 20, 2023

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh Apr 20, 2023

Choose a reason for hiding this comment

fedirjh Apr 20, 2023

Choose a reason for hiding this comment

fedirjh Apr 20, 2023

Choose a reason for hiding this comment

fedirjh Apr 20, 2023

Choose a reason for hiding this comment

fedirjh commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

fedirjh commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

fedirjh commented Apr 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023

shawnborton commented Apr 20, 2023

fedirjh commented Apr 20, 2023 • edited Loading

shawnborton commented Apr 20, 2023

alitoshmatov commented Apr 20, 2023 • edited Loading

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented Apr 24, 2023

roryabraham Apr 25, 2023

Choose a reason for hiding this comment

roryabraham left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

OSBotify commented Apr 27, 2023

alitoshmatov commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading

fedirjh commented Apr 20, 2023 •

edited

Loading

fedirjh commented Apr 20, 2023 •

edited

Loading

alitoshmatov commented Apr 20, 2023 •

edited

Loading