[PAID] [$1000] Storybook page Expensify branding is not updated

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/docs/index.html?path=/story/components-addresssearch--default

Expected Result:

Branding should be updated

Actual Result:

Not updated

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680169185824069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e9901c04b7ca8a73
• Upwork Job ID: 1643666574534430720
• Last Price Increase: 2023-04-19

[MelvinBot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@greg-schroeder Eep! 4 days overdue now. Issues have feelings too...

[greg-schroeder]

Sorry for the delay, reviewing now

[greg-schroeder]

checking to see if this should be Internal or External in slack

[greg-schroeder]

External per slack discussion!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01e9901c04b7ca8a73

[MelvinBot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[MelvinBot]

Triggered auto assignment to @roryabraham (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Milos213]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Storybook page Expensify is using old branding

What is the root cause of that problem?

When create Storybook theme, brandImage is set as logomark.svg.
logo.png and logomark.svg are old branding images. They are located in ./storybook/public.

What changes do you think we should make in order to solve the problem?

replace them with new ones

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Branding in storybook should be updated

What is the root cause of that problem?

The old branding still used

What changes do you think we should make in order to solve the problem?

We should update every instance of old branding used to new one. Changes:
-Logo
-Logomark
-Colors used to customize in storybook/public/index.css file
-Theme configs in .storybook/theme.js
-Fonts

What alternative solutions did you explore? (Optional)

[Milos213]

Proposal

Updated

[greg-schroeder]

Hey @shawnborton - I'm going to add you to this one just in case you want to monitor the brand updates. Feel free to unassign if you don't have the bandwidth.

[roryabraham]

There's a bit more to the storybook theme than is included in any of these proposals so far. It was very hacked together in an attempt to make storybook seem more legit and integrated, but IIRC storybook gives only very limited configuration options: #7154

[fedirjh]

Branding should be updated

cc @shawnborton , @roryabraham what are your thoughts on the expected outcome of the update? The proposals we've received only suggest updating the logo. Is that enough, or do you think we need to make additional changes?

[shawnborton]

I think we'd want to do Logo + some color changes as well, basically to match the same dark greens we're using throughout the app.

[shawnborton]

Also, it would be great if we can adjust the font too.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Updated storybook to use new theme #17700

If no regressions arise, payment will be issued on 2023-05-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - Internal report
• Contributor that fixed the issue - @alitoshmatov - $1000 + $500 (speed bonus) = $1500
• Contributor+ that helped on the issue and/or PR - @fedirjh - $1000 + $500 (speed bonus) = $1500

Speed bonus analysis: PR submitted on April 19 / PR merged on April 25 = 4 business days
Note: Looks like the C+ asked for our review on the PR on April 20 and we were bumped on April 24th. With a delay on our side in the review, in addition to the delay in payment for the job, I'm going to approve the speed bonus.

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alitoshmatov]

Looks like it is ready for payment

[fedirjh]

cc @greg-schroeder I don't think the BugZero Checklist applies to this issue. We made an improvement rather than fixing a bug. Please let me know your thoughts.

[alitoshmatov]

Any updates?

[conorpendergrast]

I'm working with Greg to reassign some issues and un-stick the work!

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[strepanier03]

Working on this now, will have an update soon.

[strepanier03]

I don't think the BugZero Checklist applies to this issue. We made an improvement rather than fixing a bug. Please let me know your thoughts.

@fedirjh - I agree with you. I checked off the boxes and we can consider it good there.

---

@fedirjh and @alitoshmatov - I've created a job and hired you to it. I'll be around for a bit longer today so I'll check back in before I log for the night and see if I can pay either of you before I go.

[strepanier03]

Finalized payment for @fedirjh, thank you for accepting so quickly.

I'll check in tomorrow morning for @alitoshmatov and wrap this up then.

Thank you all for the patience 🙌

[alitoshmatov]

@strepanier03 Accepted offer.

[strepanier03]

Thank you @alitoshmatov, I've finished payment and closed the contract as well.

---

Now that this is wrapped up I'm going to close as completed, cheers!