[HOLD for payment 2024-11-01] Validate - Magic code RHP does not animate correctly from pay someone confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account (unvalidated).
3. Complete the onboarding.
4. Open DM with any user.
5. Click + > Pay.
6. Enter amount in USD > Next.
7. Click Pay with Expensify.

Expected Result:

Magic code RHP will animate correctly.

Actual Result:

Magic code RHP does not animate correctly from pay someone confirmation page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642223_1729612138746.20241022_234422.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-22 17:44:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Magic code RHP does not animate correctly from pay someone confirmation page

What is the root cause of that problem?

The problem here is that we are opening another right modal while one right modal is opened.

App/src/components/SettlementButton/index.tsx

Lines 193 to 195 in 21f7842

	if (!isUserValidated) {
	Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(ROUTES.SETTINGS_ADD_BANK_ACCOUNT));
	return;

What changes do you think we should make in order to solve the problem?

1. We should use Navigation.dismissModal() to dismiss the first right modal then open next right modal like we did here
   

   App/src/pages/Search/AdvancedSearchFilters.tsx

   Lines 274 to 280 in 3e27050

   	Navigation.dismissModal();
   	Navigation.navigate(
   	ROUTES.SEARCH_CENTRAL_PANE.getRoute({
   	query: queryString,
   	}),
   	);
   	};

2. We need to update backTo here correctly.

    const activeRoute = Navigation.getActiveRoute();
    Navigation.dismissModal();
    Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(activeRoute));

App/src/components/SettlementButton/index.tsx

Lines 193 to 195 in 21f7842

	if (!isUserValidated) {
	Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.getRoute(ROUTES.SETTINGS_ADD_BANK_ACCOUNT));
	return;

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[francoisl]

This will be fixed by #51267

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-10-30. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[yuwenmemon]

https://expensify.slack.com/archives/C07J32337/p1729726700727579

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-11-01. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Processing

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.