[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Profile > Contact method.
3. Click New contact method.
4. Enter a new contact method > Click Add.
5. Enter incorrect magic code.
6. Click RHP back button without clearing the magic code and the error message.
7. Click Add.
8. Enter incorrect magic code.
9. Clear the field.
10. Enter the correct magic code, then hit Enter (important, do not use cursor to click Verify).
11. Note that the new contact method shows "Failed to add this contact method.".
12. Click on the new contact method.
13. Magic code page opens despite the error message.

Expected Result:

In Step 11, there should not be "Failed to add this contact method." error under the new contact method, because the correct magic code is entered in Step 10, and also magic code page opens in the next step (Step 13) which means there is no issue with adding the contact method.

Actual Result:

In Step 11, there is "Failed to add this contact method." error under the new contact method.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642214_1729611656948.20241022_232609.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rlinoz]

Caused by: #49445

Looks like a fix is almost ready: #51267

[getusha]

I am not able to reproduce this issue

Screen.Recording.2024-10-22.at.9.01.34.at.night.mov

[rlinoz]

@getusha I think you skipped step 8

[getusha]

@rlinoz managed to reproduce it,
it only happens when using the enter key + seems very specific case. do you think we can demote it as non blocker?

[getusha]

nvm i think i found the root cause

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rlinoz]

Fixed by the CP: https://expensify.slack.com/archives/C9YU7BX5M/p1729644038488489?thread_ts=1729642519.167879&cid=C9YU7BX5M

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-10-30. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rlinoz] Determine if we should create a regression test for this bug.
• [@rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tgolen]

@rlinoz Why was this one closed without filling out the checklist?

[yuwenmemon]

https://expensify.slack.com/archives/C07J32337/p1729726700727579

[rlinoz]

DM'd Tim to better understand the process of dealing with deploy blockers, but meanwhile here is the checklist:

• The PR that introduced the bug has been identified. Link to the PR: Refactor: reuse ValidateCodeActionModal #49445
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor: reuse ValidateCodeActionModal #49445 (comment), fix was implemented by author so the why is not outlined
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: We have test cases for this, so no need

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-11-01. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
• [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rlinoz] Determine if we should create a regression test for this bug.
• [@rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@rlinoz - I see contributors mentioned in some of the PRs listed here. Are their payments being handled in other GHs or do we need to reopen this one for payments?

[rlinoz]

@alexpensify no need, it was a follow up to a previous PR that they worked on

[alexpensify]

Ok, keeping this one closed - No payment