[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Account Settings - I don't receive the magic code to verify the account in wallet section

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5110296&group_by=cases:section_id&group_order=asc&group_id=229064
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Complete onboarding.
4. Go to Account Settings and click on the Wallet section.
5. Scroll down and click on the "Enable Wallet" option.

Expected Result:

The magic code to validate the account should be mailed on your first attempt.

Actual Result:

The magic code isn't received unless the option “Didn't receive a magic code?” is clicked.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642092_1729604981091.StagingND.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[trjExpensify]

Testing now and chatting in the slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1729607715820819

For the breadcrumbs: Confirmed I can repro and on staging only.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Account Settings - I don't receive the magic code to verify the account in wallet section

What is the root cause of that problem?

We remove the User.requestValidateCodeAction(); from useEffect here

What changes do you think we should make in order to solve the problem?

Add the User.requestValidateCodeAction(); back to useEffect

useEffect(() => {
    User.requestValidateCodeAction();
    return () => User.clearUnvalidatedNewContactMethodAction();
}, []);

What alternative solutions did you explore? (Optional)

[hungvu193]

Taking a look 👀

[luacmartins]

Being discussed here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[luacmartins]

PR merged and being CPed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-10-30. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Refactor: reuse ValidateCodeActionModal #49445
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor: reuse ValidateCodeActionModal #49445 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1729607715820819
• [@luacmartins] Determine if we should create a regression test for this bug. Regression tests caught this so no need for additional tests
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[yuwenmemon]

Removing DeployBlockerCash label as this has been Cp'ed

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: reuse ValidateCodeActionModal in wallet settings page #51267

If no regressions arise, payment will be issued on 2024-11-01. 🎊

[aimane-chnaif]

Please assign me for C+ payment

[luacmartins]

Done!

[trjExpensify]

Payment summary as follows:

• $250 to @aimane-chnaif for the C+ review.

Offer sent!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @aimane-chnaif paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Waiting for @aimane-chnaif to accept the offer.

[trjExpensify]

Paid, closing!

[melvin-bot]

@trjExpensify @luacmartins Be sure to fill out the Contact List!