[HOLD for Payment 2024-09-02] [$250] Send invoice - Individual workspace is in 'Send from' field

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3073286
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: account has Individual workspace as default and at least one existing group workspace.

1. FAB > Send invoice
2. Enter amount > Next
3. Choose a user

Expected Result:

The 'Send from' default workspace is one of listed sender's existing default workspaces.

Actual Result:

The 'Send from' default workspace is Individual workspace. When click on field, the list of sender's existing workspaces is displayed. But if you change the default workspace (one of group WS in OldDot), the individual WS is not displayed in the list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6559066_1722589049090.individual_ws.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107661f51eb3a2eee
• Upwork Job ID: 1821429613810291281
• Last Price Increase: 2024-08-08
• Automatic offers:
• rojiphil | Reviewer | 103496757
• nkdengineer | Contributor | 103496758

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #vip-bills.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Individual workspace is in 'Send from' field

What is the root cause of that problem?

We return the default policy on getPrimaryPolicy function without excluding the personal policy

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 210 in 30cfaef

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];
	}

What changes do you think we should make in order to solve the problem?

return the first activeAdminWorkspaces if the type of default policy is personal

    if (primaryPolicy?.type === CONST.POLICY.TYPE.PERSONAL) {
        return activeAdminWorkspaces[0];
    }

What alternative solutions did you explore? (Optional)

[github-actions]

true

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The 'Send from' default workspace is Individual workspace. When click on field, the list of sender's existing workspaces is displayed. But if you change the default workspace (one of group WS in OldDot), the individual WS is not displayed in the list.

What is the root cause of that problem?

We always set the default WS in the send invoice flow is the default WS if it exists without checking it is a personal WS or not

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 209 in fefda46

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];

What changes do you think we should make in order to solve the problem?

Instead of getting primaryPolicy from allPolicies, we can get this policy from the activeAdminWorkspaces which already filtered the hidden policy

function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
    const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
    const primaryPolicy: Policy | null | undefined = activeAdminWorkspaces.find((policy) => policy.id === activePolicyID);
    return primaryPolicy ?? activeAdminWorkspaces[0];
}

App/src/libs/actions/Policy/Policy.ts

Lines 205 to 209 in fefda46

	function getPrimaryPolicy(activePolicyID?: OnyxEntry<string>): Policy | undefined {
	const activeAdminWorkspaces = PolicyUtils.getActiveAdminWorkspaces(allPolicies);
	const primaryPolicy: Policy | null | undefined = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID ?? '-1'}`];
	return primaryPolicy ?? activeAdminWorkspaces[0];

What alternative solutions did you explore? (Optional)

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

I can't seem to recreate this on v9.0.16-5 - @izarutskaya can you still reproduce this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0107661f51eb3a2eee

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[rojiphil]

@nkdengineer Is there any distinct advantage to your proposed solution compared to @nyomanjyotisa proposal here?
It seems like you are the doing the same thing but in a different way.

[nkdengineer]

@rojiphil getActiveAdminWorkspaces function also filters out the WS that is pending deletion. If the default WS is pending deletion we should not show it as default in the send invoice. The proposal from @nyomanjyotisa doesn't cover this case (see the video below). For this case, we should use getActiveAdminWorkspaces as I mentioned in my proposal or update ONYXKEYS.NVP_ACTIVE_POLICY_ID when we delete the default WS.

Screen.Recording.2024-08-12.at.11.43.29.mov

[rojiphil]

getActiveAdminWorkspaces function also filters out the WS that is pending deletion

Thanks. Using getActiveAdminWorkspaces for filtering make sense as it has the additional advantage.
@nkdengineer proposal LGTM
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@rojiphil this PR is ready for review

[melvin-bot]

This issue has not been updated in over 15 days. @rojiphil, @thienlnam, @adelekennedy, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[rojiphil]

@adelekennedy Looks like the automation did not work here.
This issue is due for payment as the fix has been in production since the last 2 weeks as mentioned here

[adelekennedy]

Payouts due:

Sorry about that! Updated title and moving forward with payments

• Contributor: $250 @nkdengineer
• Contributor+: $250 @rojiphil, @rojiphil it looks like the offer is still pending in the Upwork job am I looking at this wrong, does something need to be corrected or will you accept the offer?

Upwork job is here.

[adelekennedy]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil ] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil ] Determine if we should create a regression test for this bug.
• [@rojiphil ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR

• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment

• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist is good enough to capture such issues.

• [@rojiphil] Determine if we should create a regression test for this bug. : Yes. We can

• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

  1 FAB > Send invoice
  2 Enter amount > Next
  3 Choose a user
  4 Verify that: The 'Send from' default workspace is one of listed sender's existing default workspaces.
  5 Go offline
  6 Delete a workspace
  7 Repeat steps 1, 2, 3
  8 Verify that: the deleted workspace isn't in the list of workspaces

[rojiphil]

• $250 @rojiphil, @rojiphil it looks like the offer is still pending in the Upwork job am I looking at this wrong, does something need to be corrected or will you accept the offer?

@adelekennedy Completed BZ checklist and accepted offer too. Awaiting payment. Thanks

[adelekennedy]

https://github.com/Expensify/Expensify/issues/428716