[$500] Thread-For parent message, many options missing in context menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on chat
3. Send a message
4. Long press the message, select reply in thread
5. In thread page, long press the parent message
6. Note many options missing in context menu like edit comment
7. Send a message
8. Long press the parent message and note still many options missing in context menu
9. Tap header from link
10. Long press the parent message and note all options in context menu
11. Tap reply
12. In thread page, long press the parent message and note context menu

Expected Result:

In thread page, long pressing parent message must display context menu showing all available options in it

Actual Result:

In thread page, long pressing parent message, displays context menu with many options missing in it like "edit comment"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6302293_1701804778049.task.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ee468ff09cf7c667
• Upwork Job ID: 1732125012164255744
• Last Price Increase: 2023-12-12

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ee468ff09cf7c667

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[akinwale]

@yh-0218 Could you please put some more effort into your proposal?

1. The re-state problem is simply a copy of the issue title.
2. Explain the root cause of the issue in more detail.
3. Provide details about the actual fix for the issue here.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread first chat misses many context menu options when we don't send any message in the thread.

What is the root cause of that problem?

When we create a thread and don't send any messages, reportAction doesn't contain childReportID field

App/src/libs/ReportUtils.ts

Line 916 in 5a0b7fd

return reportAction?.childReportID?.toString() === reportID;

So isThreadFirstChat function returns false and then getOriginalReportID returns the wrong report which makes the context menu option wrong

App/src/libs/ReportUtils.ts

Lines 3919 to 3923 in 5a0b7fd

	function getOriginalReportID(reportID: string, reportAction: OnyxEntry<ReportAction>): string | undefined {
	const currentReportAction = ReportActionsUtils.getReportAction(reportID, reportAction?.reportActionID ?? '');
	return isThreadFirstChat(reportAction, reportID) && Object.keys(currentReportAction ?? {}).length === 0
	? allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.parentReportID
	: reportID;

What changes do you think we should make in order to solve the problem?

If we don't want to fix this from BE we can update isThreadFirstChat function to compare report.parentReportActionID and reportAction.reportActionID instead of comparing reportAction.childReportID and reportID

What alternative solutions did you explore? (Optional)

BE should return childReportID for parent report action when we create a thread

[shubham1206agra]

Same RCA #32485

[yh-0218]

hi, @akinwale My proposal is updated.
Please check. thansk.

[paultsimura]

Please take a look at this: #32485 (comment) and this: #32485 (comment)

A lot of thread-related issues now seem to be related to BE regression.

[laurenreidexpensify]

@akinwale have you had a chance to review ^^

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[akinwale]

I will review proposals in a few hours.

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread-For parent message, many options missing in context menu

What is the root cause of that problem?

This is backend issue.
But we can fix this on app easily.

What changes do you think we should make in order to solve the problem?

We can open again parentReport before navigate to childReport to update parentReport.

@akinwale
https://github.com/Expensify/App/assets/65789015/4685d83b-ec6f-4e31-9f99-a25f381e6521

What alternative solutions did you explore? (Optional)

[melvin-bot]

@akinwale, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

[akinwale]

After reviewing the proposals, we can move forward with @dukenv0307's proposal here.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[yh-0218]

This is fixed already by backend PR. I think.

[situchan]

Seems like this is being fixed in https://github.com/Expensify/Auth/pull/9419

[paultsimura]

BE PR https://github.com/Expensify/Web-Expensify/pull/40080 was deployed on Staging, and this issue is not reproducible there anymore.

[melvin-bot]

@deetergp @akinwale @laurenreidexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[laurenreidexpensify]

@akinwale can you confirm the above ^^ and if we should close. thanks

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@deetergp, @akinwale, @laurenreidexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@deetergp @akinwale @laurenreidexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[deetergp]

Bump @akinwale