[HOLD for payment 2024-01-24] [$500] Thread - Edit box with parent message not in focus when there many comments in thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

**Version Number:**1.3.95-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
**Issue reported by:**Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Navigate to any chat
3. Send a message and start a thread
4. Send some messages > 14
5. Long tap the parent message
6. Select "Edit comment"

Expected Result:

The edit box with the parent message is in focus, and the user is able to see it

Actual Result:

The edit box with the parent is not in focus until the user starts typing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6261528_1698963049662.video_2023-11-02_17-19-30.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7c8ad57a6053cea
• Upwork Job ID: 1720205591610355712
• Last Price Increase: 2023-11-02
• Automatic offers:
• aimane-chnaif | Reviewer | 28062420
• Krishna2323 | Contributor | 28062421

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7c8ad57a6053cea

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Edit box with parent message not in focus when there many comments in thread

What is the root cause of that problem?

We are always passing '0' as the index for the parent message, but since the list is inverted, '0' actually corresponds to the index of the last message in the thread, not the parent message's index.

App/src/pages/home/report/ReportActionItemParentAction.js

Line 73 in d53a03e

index={0}

What changes do you think we should make in order to solve the problem?

We need to pass the length of the list minus one to accurately set the index of the parent message, since the list is inverted. We get the sortedReportActions in ReportActionsListItemRenderer, so we can pass index={sortedReportActions.length - 1} to ReportActionItemParentAction or we can simply pass the index like we are passing to child actions.

Result

fix_demo.mp4

[aimane-chnaif]

@Krishna2323's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Krishna2323]

@aimane-chnaif @aldo-expensify, we should wait until #30729 is fixed otherwise it will cause problems while recording the video for IOS as it will cause infinite GetNewerActions calls

[aimane-chnaif]

Agree. I also noticed while testing

[abekkala]

still holding on this one

[abekkala]

still holding on 30729

[abekkala]

still on hold

[abekkala]

Still waiting on 30729
I'll be ooo until Mon 11/27 and will check on this one at that time.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@aimane-chnaif, now we need to wait for this issue 🥲. @aldo-expensify can we proceed without this? since this is a very simple fix (just passing the correct prop).

[aimane-chnaif]

@Krishna2323 I am not sure it will block testing. That bug won't be gone after refresh app?

[Krishna2323]

@aimane-chnaif, it will block testing as the edit option will be unavailable on the parent message.

[aimane-chnaif]

That bug won't be gone after refresh app?

@Krishna2323 have you tried restart app? It will be available after refresh thread

Screen.Recording.2023-12-17.at.10.32.17.AM.mov

[Krishna2323]

@aimane-chnaif, edit option was working few minutes back but when I tried after pulling the latest code the app is crashing after just after starting. Will try again later today.

app_crash.mp4

[Krishna2323]

@aimane-chnaif, PR ready for a review.

[melvin-bot]

This issue has not been updated in over 15 days. @abekkala, @Krishna2323, @aldo-expensify, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: edit box with parent message not focused. #33365

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment automatic offer (Contributor)
• @aimane-chnaif requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENTS FOR JAN 24

• Issue reported by: Applause - Internal Team
• Fix: @Krishna2323 requires payment automatic offer [$500, if no regressions]
• PR Review: @aimane-chnaif requires payment automatic offer [$500, if no regressions]

[Krishna2323]

@abekkala bump for payments here

[abekkala]

@aimane-chnaif can you please complete the checklist above?

[abekkala]

@Krishna2323 payment sent and contract ended - thank you! 🎉

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: New Thread Report Empty State, Header, LHN, OpenReport, Buttons for DEV #18522
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18522/files#r1467016568
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This was caught by QA team so no need regression test
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[abekkala]

@aimane-chnaif payment sent and contract ended - thank you 🎉